Skip to contentSkip to conversation

Linux 2.4.21-rc4

PATCH In review Marcelo Tosatti 2 participants 3 messages May 26, 2003 – May 27, 2003

lore
Share & tools
lore
#0 lore raw

Hi,

Here goes -rc4, hopefully fixing all problems now.

rc5 will only be released in case of REALLY bad problems.

Please test it extensively.

Summary of changes from v2.4.21-rc3 to v2.4.21-rc4
============================================

<[email protected]>:
o IPMI fixes

<[email protected]>:
o Fix writing to /dev/console

Barry K. Nathan <[email protected]>:
o Correctly fix the ioperm issue

Benjamin Herrenschmidt <[email protected]>:
o Update ide/ppc/pmac.c
o Fix controlfb build with gcc3.3
o PPC32 Fix warning with ndelay (with patch !)

Marcelo Tosatti <[email protected]>:
o Changed EXTRAVERSION to -rc4

  o Cset exclude: [email protected]|ChangeSet|20030526190224|33683

o Really fix xconfig breakage

#1 lore raw

PATCH 1/1 IDE config correctness (was: Linux 2.4.21-rc4)

Quoted 5 lines · Marcelo Tosatti

Hi,

Here goes -rc4, hopefully fixing all problems now.

rc5 will only be released in case of REALLY bad problems.

Not really a bad problem, but CONFIG_PDC202XX_BURST should be selectable even if CONFIG_BLK_DEV_PDC202XX_OLD=m
You decide if this goes into 2.4.21. I do not feel strongly about it.

Quoted 2 lines
  o Cset exclude: [email protected]|ChangeSet|20030526190224|33683

o Really fix xconfig breakage

My fix for the xconfig breakage also included this IDE config fix. When you excluded the cset, it got lost.

Attached is the diff on top of your tree.

Regards,
Carl-Daniel

===== drivers/ide/Config.in 1.31 vs edited =====

drivers/ide/Config.in +1 -1
@@ -63,7 +63,7 @@
 	    dep_tristate '    NS87415 chipset support' CONFIG_BLK_DEV_NS87415 $CONFIG_BLK_DEV_IDEDMA_PCI
 	    dep_tristate '    OPTi 82C621 chipset enhanced support (EXPERIMENTAL)' CONFIG_BLK_DEV_OPTI621 $CONFIG_EXPERIMENTAL
 	    dep_tristate '    PROMISE PDC202{46|62|65|67} support' CONFIG_BLK_DEV_PDC202XX_OLD $CONFIG_BLK_DEV_IDEDMA_PCI
-	    dep_bool     '      Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX_OLD $CONFI_BLK_DEV_IDEDMA_PCI
+	    dep_mbool    '      Special UDMA Feature' CONFIG_PDC202XX_BURST $CONFIG_BLK_DEV_PDC202XX_OLD $CONFI_BLK_DEV_IDEDMA_PCI
 	    dep_tristate '    PROMISE PDC202{68|69|70|71|75|76|77} support' CONFIG_BLK_DEV_PDC202XX_NEW $CONFIG_BLK_DEV_IDEDMA_PCI
 		# FIXME - probably wants to be one for old and for new
 if [ "$CONFIG_BLK_DEV_PDC202XX_OLD" = "y" -o "$CONFIG_BLK_DEV_PDC202XX_OLD" = "m" -o "$CONFIG_BLK_DEV_PDC202XX_NEW" = "y" -o "$CONFIG_BLK_DEV_PDC202XX_NEW" = "m" ]; then
#2 lore raw

Re: [PATCH] IDE config correctness (was: Linux 2.4.21-rc4)

It seems Alan still has some very important fixes pending. If so, I'll release -rc5 tomorrow with your stuff.

Otherwise it will have to wait for .22-pre.

Quoted 23 lines · Carl-Daniel Hailfinger
Quoted 5 lines · Marcelo Tosatti

Hi,

Here goes -rc4, hopefully fixing all problems now.

rc5 will only be released in case of REALLY bad problems.

Not really a bad problem, but CONFIG_PDC202XX_BURST should be selectable even if CONFIG_BLK_DEV_PDC202XX_OLD=m
You decide if this goes into 2.4.21. I do not feel strongly about it.

Quoted 2 lines
  o Cset exclude: [email protected]|ChangeSet|20030526190224|33683

o Really fix xconfig breakage

My fix for the xconfig breakage also included this IDE config fix. When you excluded the cset, it got lost.

Attached is the diff on top of your tree.

Regards,
Carl-Daniel