PATCH: scsi_debug bug

No response the first time. Resending.

Can someone look at this patch and approve it, please?

It looks like an obvious bug and fix to me: MODE_SENSE_10 allocation length LSB is in cdb byte 8, not byte 6.

This bug is present in both 2.4 and 2.5.

Jeff

===== drivers/scsi/scsi_debug.c 1.39 vs edited =====

@@ -687,7 +687,7 @@
 	pcontrol = (cmd[2] & 0xc0) >> 6;
 	pcode = cmd[2] & 0x3f;
 	msense_6 = (MODE_SENSE == cmd[0]);
-	alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[6]);
+	alloc_len = msense_6 ? cmd[4] : ((cmd[7] << 8) | cmd[8]);
 	/* printk(KERN_INFO "msense: dbd=%d pcontrol=%d pcode=%d "
 		"msense_6=%d alloc_len=%d\n", dbd, pcontrol, pcode, "
 		"msense_6, alloc_len); */

Quoting Jeff Garzik <[email protected]>:

Jeff,
Guilty as charged.

Sorry for the long delay in responding. Hopefully James and/or Mike Anderson can put the patch in the bk scsi repository for the lk 2.5 series.

For the lk 2.4 series, please send a patch to Marcelo and cc Alan.

Doug Gilbert

-------------------------------------------------
This mail sent through IMP: http://horde.org/imp/

Already merged