Skip to contentSkip to conversation

2.4 direct_IO API changing?

DISCUSSION Jeff Garzik 2 participants 2 messages Jul 6, 2003

lore
Share & tools
lore
#0 lore raw

I see in 2.4.22-BK-latest:

Review

Quoted 2 lines
(quoted diff) +1 -1
-       int (*direct_IO)(int, struct inode *, struct kiobuf *, unsigned long, int);
+       int (*direct_IO)(int, struct file *, struct kiobuf *, unsigned long, int

Should this really be changing in the middle of a stable series?

I realize that vendor's are already shipping this difference, but still... it's a bit of an abrupt midseries change that can potentially break working code.

Jeff

#1 lore raw
Quoted 11 lines · Jeff Garzik

I see in 2.4.22-BK-latest:

Review

Quoted 2 lines
(quoted diff) +1 -1
-       int (*direct_IO)(int, struct inode *, struct kiobuf *, unsigned long, int);
+       int (*direct_IO)(int, struct file *, struct kiobuf *, unsigned long, int

Should this really be changing in the middle of a stable series?

I realize that vendor's are already shipping this difference, but still... it's a bit of an abrupt midseries change that can potentially break working code.

Its something most people are already shipping and something you actually do need for some of the direct IO stuff.

BTW: Marcelo your mail system is broken *again*