Problems building ./tools

Hi there,

I just pulled U-Boot CVS and tried to build a standard target:

~ # make TQM860L_config
rm -f include/config.h include/config.mk
Configuring for TQM860L board...
~ # CROSS_COMPILE=ppc_8xx- LANG=en make all

But I do get

make[1]: Entering directory `/home/denx/CVSDENX/u-boot/tools'
/bin/sh: -c: line 1: syntax error near unexpected token `;'
/bin/sh: -c: line 1: `for dir in ; do make HOSTOS=linux HOSTARCH=i386 HOST_CFLAGS="-Wall -pedantic" HOST_LDFLAGS="" -C $dir || exit 1 ; done' make[1]: *** [subdirs] Error 2
make[1]: Leaving directory `/home/denx/CVSDENX/u-boot/tools'
make: *** [subdirs] Error 1

Troublemakers are the lines in tools/Makefile:

subdirs:

                 @for dir in $(TOOLSUBDIRS) ; do \
                     $(MAKE) \
                         HOSTOS=$(HOSTOS) \
                         HOSTARCH=$(HOSTARCH) \
                         HOST_CFLAGS="$(HOST_CFLAGS)" \
                         HOST_LDFLAGS="$(HOST_LDFLAGS)" \
                         -C $$dir || exit 1 ; \
                 done

since TOOLSUBDIRS is explicitly set emtpy in tools/Makefile!

???

Steven

Dear Steven,

This has been reported before, and I posted the folowing patch to the list:

@@ -152,6 +152,9 @@
 		$(CC) -g $(CFLAGS) -c $<
 
 subdirs:
+ifeq ($(TOOLSUBDIRS),)
+		@:
+else
 		@for dir in $(TOOLSUBDIRS) ; do \
 		    $(MAKE) \
 			HOSTOS=$(HOSTOS) \

@@ -160,6 +163,8 @@
 		   	HOST_LDFLAGS="$(HOST_LDFLAGS)" \
 			-C $$dir || exit 1 ; \
 		done
+endif
+
 environment.c:
 		ln -s ../common/environment.c environment.c
 

Sorry that I didn't find the time yet to push it too CVS.

Best regards,

Wolfgang Denk

Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-4596-87  Fax: (+49)-8142-4596-88  Email: [email protected]
You can do this in a number of ways.     IBM chose to do all of them.
Why do you find that funny?        -- D. Taylor, Computer Science 350