Skip to contentSkip to conversation

Problem with extended-match deletion

DISCUSSION Massimiliano Cuzzoli 1 participant 2 messages Aug 19, 2003 3 messages not in the archive netfilter

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20030819102424.16725.44717.Mailman@kashyyyk

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw

Hi Sumit,
I try to write a kernel module similar to ipt_limit.c:

-->>> My match structure is:
struct ipt_bwctrl_info {
unsigned long rate; /* in Kbit/sec */
unsigned long mark;
unsigned long burst; /* in Kbit */

unsigned long old_tstamp;
unsigned long bit_burst; /* in bit */
unsigned long bit_bonus; /* in bit */
unsigned long bit_per_jiffy; /* in bit */

/* As master field of ipt_limit.h !!!! */
struct ipt_bwctrl_info *original;
};

-->>> My check_entry function:
static int bwcontrol_checkentry(const char *tablename, const struct ipt_ip *ip,

				void *matchinfo, unsigned int matchsize,
				unsigned int hookmask) {

struct ipt_bwctrl_info *bw_info;

  if (matchsize!=IPT_ALIGN(sizeof(struct ipt_bwctrl_info))) {
    return(0);
  }

  bw_info=(struct ipt_bwctrl_info *) matchinfo;

/* Init *bw_info fields... */
/* ........................*/

bw_info->original=bw_info; /* for SMP */

return(1);
}

-->>> My match function:
static int bwcontrol_match(const struct sk_buff *skb,
const struct net_device *in, const struct net_device *out, const void *matchinfo, int offset, const void *hdr, u_int16_t datalen, int *hotdrop) {

struct ipt_bwctrl_info *bw_info;

bw_info=((struct ipt_bwctrl_info *) matchinfo)->original; /*for SMP*/

spin_lock_bh(&bwcontrol_lock); /* SMP lock */

/* Match controls ......... */
/* ........................ */

spin_unlock_bh(&bwcontrol_lock); /* SMP unlock */

return(1);
}

Regards.

Quoted 21 lines · Sumit Pandya has
Quoted 4 lines

Date: Mon, 18 Aug 2003 17:34:40 +0200
From: Massimiliano Cuzzoli <[email protected]>

Hi all,

Hi

Quoted 1 line

I've wrote a new match for iptables 1.2.7a.

Will you write more details? Some of its intended purpose ;-)

Quoted 2 lines

All features, that I've implemented in it, run very well but there is a problem when I try to remove the rule with my match.

Are you sure you not changing (void*) matchinfo structure from matchentry function within kernel module?

Quoted 1 line

Can Anybody help me???

Hope this helps :-)
-- Sumit

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw

Ok Sumit,
now perhaps I've found my error:
I define:

static struct iptables_match bwcontrol = {
NULL,
"bwcontrol",
NETFILTER_VERSION, IPT_ALIGN(sizeof(struct ipt_bwctrl_info)),
-->>>> IPT_ALIGN(sizeof(struct ipt_bwctrl_info)),
&help_bwcontrol,
&init_bwcontrol,
&parse_bwcontrol,
&final_check,
&print_bwcontrol,
&save_bwcontrol,
opts
};

Thank you very much!!!

Quoted 27 lines · Sumit Pandya

I think you have overlooked some text from my previous reply

Quoted 1 line
Quoted 1 line

Are you sure you not changing (void*) matchinfo structure from

matchentry

Quoted 1 line
Quoted 1 line

function within kernel module?

From your reply it seems that bwcontrol_checkentry is doing what I
doubted. If it is so then in your userland library you need this kind of defination
static
struct iptables_match bwcontrol = {
NULL,
"bwcontrol",
NETFILTER_VERSION,
IPT_ALIGN(sizeof(struct ipt_bwctrl_info)), offsetof(struct ipt_bwctrl_info, original), &help_bwcontrol,
&init_bwcontrol,
&parse_bwcontrol,
&final_check,
&print_bwcontrol,
&save_bwcontrol,
opts
};
--Sumit