libip6t_MARK.c
PATCH 1/1 libip6t_MARK.c
Harald,
here's another userspace patch:
1- remove unused struct markinfo,
2- print_mark() was only used once, so I removed it and changed print() accordingly, 3- C99 initializers.
Please apply,
Stephane
userspace/extensions/libip6t_MARK.c +16 -28
@@ -8,11 +8,6 @@#include <linux/netfilter_ipv6/ip6_tables.h> #include <linux/netfilter_ipv6/ip6t_MARK.h> -struct markinfo { -struct ip6t_entry_target t; -struct ip6t_mark_target_info mark; -}; -/* Function which prints out usage message. */ static void help (void )
@@ -25,8 +20,8 @@ }static struct option opts[] = { - {"set-mark" ,1 ,0 ,'1' }, - {0 } + { .name ="set-mark" , .has_arg =1 , .flag =0 , .val ='1' }, + { .name =0 } };/* Initialize the target. */
@@ -72,12 +67,6 @@ "MARK target: Parameter --set-mark is required"); } -static void -print_mark (unsigned long mark,int numeric) -{ -printf ("0x%lx " , mark); -} -/* Prints out the targinfo. */ static void print(const struct ip6t_ip6 *ip,
@@ -86,8 +75,8 @@ {const struct ip6t_mark_target_info *markinfo = (const struct ip6t_mark_target_info *)target->data; -printf ("MARK set " ); -print_mark (markinfo->mark, numeric); + +printf ("MARK set 0x%lx " , markinfo->mark); }/* Saves the union ipt_targinfo in parsable form to stdout. */
@@ -101,19 +90,18 @@ }static -struct ip6tables_target mark -= {NULL , -"MARK" , -IPTABLES_VERSION , -IP6T_ALIGN (sizeof (struct ip6t_mark_target_info )), -IP6T_ALIGN (sizeof (struct ip6t_mark_target_info )), - &help, - &init, - &parse, - &final_check, - &print, - &save, - opts +struct ip6tables_target mark = { + .name ="MARK" , + .version =IPTABLES_VERSION , + .size =IP6T_ALIGN (sizeof (struct ip6t_mark_target_info )), + .userspacesize =IP6T_ALIGN (sizeof (struct ip6t_mark_target_info )), + .help = &help, + .init = &init, + .parse = &parse, + .final_check = &final_check, + .print = &print, + .save = &save, + .extra_opts = opts };void _init (void )
Harald Welte
AppliedQuoted 2 lines · Stephane Ouellette
Harald,
Please apply,
thanks, applied.
Quoted 1 line
Stephane
Signature · 5 lines
- Harald Welte <[email protected]> http://www.netfilter.org/ ============================================================================ "Fragmentation is like classful addressing -- an interesting early architectural error that shows how much experimentation was going on while IP was being designed." -- Paul Vixie