Missing memory barrier on net/core/dev.c

Hi Dave,

I *think* net/core/dev.c is missing a mb() before calling
schedule_timoeut.

	Feel free to prove me wrong, though ;)

	Patch against 2.6.0-test5.

	Please review.

	Cheers,

Felipe

@@ -2753,9 +2753,9 @@
 			rebroadcast_time = jiffies;
 		}
 
-		current->state = TASK_INTERRUPTIBLE;
+		set_current_state(TASK_INTERRUPTIBLE);
 		schedule_timeout(HZ / 4);
-		current->state = TASK_RUNNING;
+		__set_current_state(TASK_RUNNING);
 
 		if (time_after(jiffies, warning_time + 10 * HZ)) {
 			printk(KERN_EMERG "unregister_netdevice: "

I have another patch in my queue from Andrew Morton that removes the TASK_RUNNING setting altogether, schedule_timeout() always returns with the task in that state.

	Hi,

Ok, although that was not the main point of the patch :)

What about the "set_current_state" before calling schedule_timeout.
Isn't that mb() needed?

Cheers,

Felipe