Altix console driver

2.6 Altix serial console driver add

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas:

#	           ChangeSet	1.1347  -> 1.1348 
#	drivers/char/Kconfig	1.24    -> 1.25   
#	         MAINTAINERS	1.174   -> 1.175  

# drivers/char/Makefile 1.60 -> 1.61
# (new) -> 1.1 drivers/char/sn_serial.c
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/21 [email protected] 1.1348
# Altix serial console patch
# --------------------------------------------
#

diff -Nru a/MAINTAINERS b/MAINTAINERS
@@ -1753,6 +1753,12 @@
 W:	http://www.nsa.gov/selinux
 S:	Supported
 
+SGI SN-IA64 (Altix) SERIAL CONSOLE DRIVER
+P:	Pat Gefre
+M:	[email protected]
+L:	[email protected]
+S:	Supported
+
 SGI VISUAL WORKSTATION 320 AND 540
 P:	Andrey Panin
 M:	[email protected]

diff -Nru a/drivers/char/Kconfig b/drivers/char/Kconfig
@@ -373,6 +373,22 @@
 	  If you have an Alchemy AU1000 processor (MIPS based) and you want
 	  to use serial ports, say Y.  Otherwise, say N.
 
+config SGI_L1_SERIAL
+	bool "SGI Altix L1 serial support"
+	depends on SERIAL_NONSTANDARD && IA64
+	help
+	  If you have an SGI Altix and you want to use the serial port
+	  connected to the system controller (you want this!), say Y.
+	  Otherwise, say N.
+
+config SGI_L1_SERIAL_CONSOLE
+	bool "SGI Altix L1 serial console support"
+	depends on SGI_L1_SERIAL
+	help
+	  If you have an SGI Altix and you would like to use the system
+	  controller serial port as your console (you want this!), 
+	  say Y.  Otherwise, say N.
+
 config AU1000_SERIAL_CONSOLE
 	bool "Enable Au1000 serial console"
 	depends on AU1000_UART

diff -Nru a/drivers/char/Makefile b/drivers/char/Makefile
@@ -42,6 +42,7 @@
 obj-$(CONFIG_SH_SCI)		+= sh-sci.o generic_serial.o
 obj-$(CONFIG_HVC_CONSOLE)	+= hvc_console.o
 obj-$(CONFIG_RAW_DRIVER)	+= raw.o
+obj-$(CONFIG_SGI_L1_SERIAL)	+= sn_serial.o
 
 obj-$(CONFIG_PRINTER) += lp.o
 obj-$(CONFIG_TIPAR) += tipar.o

Were all the points which Christoph raised considered?

http://www.ussg.iu.edu/hypermail/linux/kernel/0309.2/0465.html

On Tue, 21 Oct 2003, Andrew Morton wrote:

+ Patrick Gefre <[email protected]> wrote:
+ >
+ > 2.6 Altix serial console driver add
+
+ Were all the points which Christoph raised considered? +
+ http://www.ussg.iu.edu/hypermail/linux/kernel/0309.2/0465.html
+

I addressed as many as I could - almost all of them I think. FWIW this driver is very close to the one I sent for 2.4. I would like to, eventually, convert the code to use the serial_core calls....

-- Pat

No.

On Wed, 22 Oct 2003, Christoph Hellwig wrote:

+ On Tue, Oct 21, 2003 at 03:00:27PM -0700, Andrew Morton wrote:
+ > Patrick Gefre <[email protected]> wrote:
+ > >
+ > > 2.6 Altix serial console driver add
+ >
+ > Were all the points which Christoph raised considered? +
+ No.
+

Which item(s), specifically, do you have an issue with ?

You're still registering with the normal serial major/minor without using serial core. That means the normal serial driver can't be used when sn_serial is loaded, e.g. for using a pci serial card in an altix. The irq mess still isn't fixed - this isn't exactly an issue with this driver but I exposing the bloody mess outside arch/ia64/sn is a very bad idea. I'd suggest kicking ajm to fix that up.

pciio.h has no business beeing included in this driver that doesn't use anything PCIish, again a core SN issue that needs fixing.

Also after reading through the new comment ontop of the file it might be a good idea to rename it to sn_console.c, especially now that there is a real ioc4 serial driver.