Skip to contentSkip to conversation

more eepro100 boards

PATCH In review Xose Vazquez Perez 2 participants 3 messages Nov 18, 2003 – Feb 1, 2005

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Xose Vazquez Perez

author
#0 lore raw

PATCH 1/1 more eepro100 boards

deleted PCI_DEVICE_ID_INTEL_82801BA_7, it's a duplicate of 0x2449

and added five boards:

0x1051
0x1052
0x1053
0x1054
0x1055

These should be deleted:

0x1035
0x1036
0x1037
0x1227
0x1228
0x5200
0x5201

Time ago, in conversation with some intel guys, they said me that those boards are not compatibles with the driver. Do anyone run eepro100 with any of those boards?

-thanks-

drivers/net/eepro100.c +5 -2
@@ -2374,8 +2374,6 @@
 		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82559ER,
 		PCI_ANY_ID, PCI_ANY_ID, },
-	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
-		PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1029, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1030, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1031, PCI_ANY_ID, PCI_ANY_ID, },

@@ -2393,6 +2391,11 @@
 	{ PCI_VENDOR_ID_INTEL, 0x103D, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x103E, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1050, PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1051, PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1052, PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1053, PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1054, PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1055, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1059, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1227, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1228, PCI_ANY_ID, PCI_ANY_ID, },
#1 lore raw
Quoted 21 lines · Xose Vazquez Perez

deleted PCI_DEVICE_ID_INTEL_82801BA_7, it's a duplicate of 0x2449

and added five boards:

0x1051
0x1052
0x1053
0x1054
0x1055

These should be deleted:

0x1035
0x1036
0x1037
0x1227
0x1228
0x5200
0x5201

Quoted 3 lines

Time ago, in conversation with some intel guys, they said me that those boards are not compatibles with the driver. Do anyone run eepro100 with any of those boards?

Indeed.... I would like to delay this patch, until we are confirmed that these pci ids do indeed work with eepro100.c. Once we get confirmation, I am OK with applying.

Jeff

author
#2 lore raw

PATCH 1/1 2.6 eepro100: replace and delete duplicate ids

In reply to Xose Vazquez Perez

hi,

- replace PCI_DEVICE_ID_INTEL_82557 and PCI_DEVICE_ID_INTEL_82559ER with theirs hex numbers
- PCI_DEVICE_ID_INTEL_82801BA_7 is a duplicate of 0x2449.

-thanks-

drivers/net/eepro100.c +2 -6
@@ -2355,12 +2355,8 @@
 }
 
 static struct pci_device_id eepro100_pci_tbl[] = {
-	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82557,
-		PCI_ANY_ID, PCI_ANY_ID, },
-	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82559ER,
-		PCI_ANY_ID, PCI_ANY_ID, },
-	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801BA_7,
-		PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1229, PCI_ANY_ID, PCI_ANY_ID, },
+	{ PCI_VENDOR_ID_INTEL, 0x1209, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1029, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1030, PCI_ANY_ID, PCI_ANY_ID, },
 	{ PCI_VENDOR_ID_INTEL, 0x1031, PCI_ANY_ID, PCI_ANY_ID, },