Skip to contentSkip to conversation

more RTL-8139 clone boards

PATCH Applied Xose Vazquez Perez 3 participants 4 messages Nov 18, 2003 – Nov 19, 2003

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 more RTL-8139 clone boards

0x018A 0x0106 LevelOne FPC-0106TX 0x126C 0x1211 Nortel Networks 10/100BaseTX 0x1743 0x8139 Peppercon AG ROL-F 0x021B 0x8139 Compaq HNE-300

--
HTML mails are going to trash automagically

drivers/net/8139too.c +4 -0
@@ -250,6 +250,10 @@
 	{0x11db, 0x1234, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
 	{0x1432, 0x9130, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
 	{0x02ac, 0x1012, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+	{0x018a, 0x0106, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+	{0x126c, 0x1211, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+	{0x1743, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 },
+	{0x021b, 0x8139, PCI_ANY_ID, PCI_ANY_ID, 0, 0, RTL8139 }, 
 
 #ifdef CONFIG_SH_SECUREEDGE5410
 	/* Bogus 8139 silicon reports 8129 without external PROM :-( */
#3 lore raw
Quoted 11 lines · Stephen Hemminger
Quoted 4 lines · On Tue, 18 Nov 2003 20:46:34 +0100 Xose Vazquez Perez <[email protected]> wrote:

0x018A 0x0106 LevelOne FPC-0106TX 0x126C 0x1211 Nortel Networks 10/100BaseTX 0x1743 0x8139 Peppercon AG ROL-F 0x021B 0x8139 Compaq HNE-300

Maybe time to start using pci_ids.h?

This is mainly a matter of opinion. My opinion: no. ;-)

I think it's rather silly to keep adding to pci_ids.h, when the ids are just arbitrary hex numbers with no useful value. I certainly support mnemonic constants when they have value... but if the _only_ place a PCI id constant exists is (a) in a pci_device_id list and (b) in pci_ids.h, then it seems rather wasteful rather than helpful.

IMO, the constants just bloat the pci_device_id list, whereas the ones with hex numbers are nice, single lines.

As an aside, include/linux/pci_ids.h is a heavily patched file, and conflicts occur all the time.

Jeff