Skip to contentSkip to conversation

Inconsistent LVM code in 2.4.23-rc1

linux-lvm Xose Vazquez Perez 1 participant 1 message Nov 20, 2003

lore
Share & tools
lore

Xose Vazquez Perez

author
#0 lore raw
Quoted 25 lines · James G. Sack (jim)

1587,1588c1587
< if (minor >= ABS_MAX_VG) {
< kfree(vg_ptr);
---

Quoted 1 line

if (minor >= ABS_MAX_VG)

1590d1588
< }
1658c1656,1657
< goto copy_fault;
---

Quoted 2 lines
				lvm_do_vg_remove(minor);
				return -EFAULT;

1669c1668,1669
< goto copy_fault;
---

Quoted 2 lines
				lvm_do_vg_remove(minor);
				return -EFAULT;

1679c1679,1680
< goto copy_fault;
---

Quoted 2 lines
			lvm_do_vg_remove(minor);
			return -EFAULT;

1682c1683,1684
< goto copy_fault;
---

Quoted 7 lines
Quoted 2 lines
			lvm_do_vg_remove(minor);
			return -EFAULT;

1697,1700d1698
< copy_fault:
< lvm_do_vg_remove(minor);
< vfree(snap_lv_ptr);
< return -EFAULT;

I believe that these changes were done in *kernel lvm_1.0.5+* release.

Quoted 6 lines

2597c2595
< vg_ptr->pe_allocated -= old_lv->lv_allocated_le;
---

Quoted 1 line
		vg_ptr->pe_allocated -= old_lv->lv_allocated_snapshot_le;

2598a2597

Quoted 1 line
		old_lv->lv_allocated_snapshot_le = new_lv->lv_allocated_le;

rest are 1.0.7 -> 1.0.8 'official' changes

I sent to marcelo a diff 1.0.7 kernel version vs 1.0.8 sistina last days

Signature · 1 line
HTML mails are going to trash automagically