Skip to contentSkip to conversation

fix static build of drivers/mtd/chips/jedec_probe.c

PATCH In review Bernardo Innocenti 2 participants 3 messages Dec 23, 2003

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix static build of drivers/mtd/chips/jedec_probe.c

Hello,

one liner fix for building jedec_probe statically in m68knommu and possibly other archs.

Applies to 2.6.0.

mtd/chips/jedec_probe.c.orig renamed from mtd/chips/jedec_probe.c +0 -0
@@ -8,7 +8,6 @@
 

#include <linux/config.h>
#include <linux/module.h>
-#include <linux/init.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <asm/io.h>

Signature · 2 lines
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/
#1 lore raw
Quoted 12 lines · Bernardo Innocenti

Hello,

one liner fix for building jedec_probe statically in m68knommu and possibly other archs.

Applies to 2.6.0.

mtd/chips/jedec_probe.c.orig line 13

Quoted 7 lines
mtd/chips/jedec_probe.c.orig renamed from mtd/chips/jedec_probe.c +0 -1
@@ -8,7 +8,6 @@
 
 #include <linux/config.h>
 #include <linux/module.h>
-#include <linux/init.h>
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <asm/io.h>

Inclusion of init.h shouldn't break anything. What is the error?

#2 lore raw
Quoted 13 lines · Andrew Morton
Quoted 11 lines · Bernardo Innocenti

Hello,

one liner fix for building jedec_probe statically in m68knommu and possibly other archs.

Applies to 2.6.0.

mtd/chips/jedec_probe.c.orig renamed from mtd/chips/jedec_probe.c +0 -0
@@ -8,7 +8,6 @@
 
Quoted 8 lines

mtd/chips/jedec_probe.c.orig line 13

Quoted 6 lines
mtd/chips/jedec_probe.c.orig renamed from mtd/chips/jedec_probe.c +0 -1
 #include <linux/config.h>
 #include <linux/module.h>
-#include <linux/init.h>
 #include <linux/types.h>
 #include <linux/kernel.h>
 #include <asm/io.h>

Inclusion of init.h shouldn't break anything. What is the error?

OOPS, I reversed the diff by mistake. The patch was supposed to *add* that line ;-)

Signature · 2 lines
 // Bernardo Innocenti - Develer S.r.l., R&D dept.
\X/  http://www.develer.com/