MIPS: ingenic: gcw0: Fix HP detection GPIO.
Subsystems (4)
PATCH 1/1 MIPS: ingenic: gcw0: Fix HP detection GPIO.
Previously marked as active high, but is in reality active low.
Fixes b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")
Signed-off-by João H. Spies <[email protected]>
--- arch/mips/boot/dts/ingenic/gcw0.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/mips/boot/dts/ingenic/gcw0.dts +1 -1
@@ -92,7 +92,7 @@ "MIC1N", "Built-in Mic"; simple-audio-card,pin-switches = "Speaker", "Headphones"; - simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>; + simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>; simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>; simple-audio-card,bitclock-master = <&dai_codec>;
Signature · 1 line
2.17.1
Hi João,
Quoted 5 lines · João H. Spies
Previously marked as active high, but is in reality active low.
Fixes b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")Signed-off-by João H. Spies <[email protected]>
Good catch.
Tested-by Paul Cercueil <[email protected]>
Reviewed-by Paul Cercueil <[email protected]>
Cheers,
-Paul
Quoted 20 lines
--- arch/mips/boot/dts/ingenic/gcw0.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/mips/boot/dts/ingenic/gcw0.dts +1
-2@@ -92,7 +92,7 @@ "MIC1N", "Built-in Mic"; simple-audio-card,pin-switches = "Speaker", "Headphones"; - simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_HIGH>; + simple-audio-card,hp-det-gpio = <&gpf 21 GPIO_ACTIVE_LOW>; simple-audio-card,aux-devs = <&speaker_amp>, <&headphones_amp>; simple-audio-card,bitclock-master = <&dai_codec>; --2.17.1
Quoted 8 lines · João H. Spies
Previously marked as active high, but is in reality active low.
Fixes b1bfdb660516 ("MIPS: ingenic: DTS: Update GCW0 support")Signed-off-by João H. Spies <[email protected]>--- arch/mips/boot/dts/ingenic/gcw0.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
applied to mips-fixes.
Thomas.
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]