scsi: ufs: dt-bindings: common: Fix a grammar error
Subsystems (3)
PATCH 1/1 scsi: ufs: dt-bindings: common: Fix a grammar error
Fix a minor grammar error.
--- Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/ufs/ufs-common.yaml +1 -1
@@ -48,7 +48,7 @@ properties: enum: [1, 2] default: 2 description: - Number of lanes available per direction. Note that it is assume same + Number of lanes available per direction. Note that it is assumed same number of lanes is used both directions at once. vdd-hba-supply:
Signature · 1 line
2.51.0
Bart Van Assche
reviewerDocumentation/devicetree/bindings/ufs/ufs-common.yaml
Quoted 1 line · Zhaoming Luo
Documentation/devicetree/bindings/ufs/ufs-common.yaml +0
-0
Who is the maintainer for this file? The MAINTAINERS entry for this file does not mention a maintainer:
UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER
R: Alim Akhtar <[email protected]> R: Avri Altman <[email protected]> R: Bart Van Assche <[email protected]> L: [email protected] S: Supported F: Documentation/devicetree/bindings/ufs/ F: Documentation/scsi/ufs.rst F: drivers/ufs/core/ F: include/ufs/
Thanks,
Bart.
Quoted 6 lines · Bart Van Assche
Documentation/devicetree/bindings/ufs/ufs-common.yaml
Quoted 1 line · Zhaoming Luo
Documentation/devicetree/bindings/ufs/ufs-common.yaml +0
-0Who is the maintainer for this file? The
MAINTAINERSentry for this file does not mention a maintainer:
Quoted 7 lines
UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER
R: Alim Akhtar <[email protected]> R: Avri Altman <[email protected]> R: Bart Van Assche <[email protected]> L: [email protected] S: Supported F: Documentation/devicetree/bindings/ufs/
Here ^^^
Plus maintainer is also written in the file itself.
Anyway, author did not Cc necessary people...
Best regards,
Krzysztof
Quoted 4 lines · Zhaoming Luo
Fix a minor grammar error.
Signed-off-by Zhaoming Luo <[email protected]>---
Please use subject prefixes matching the subsystem. You can get them for example with git log --oneline -- DIRECTORY_OR_FILE on the directory your patch is touching. For bindings, the preferred subjects are explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.
Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.
You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time.
Please kindly resend and include all necessary To/Cc entries.
Best regards,
Krzysztof