arm64: smp: Include smp_plat.h from smp.h
cover arm64: smp: Include smp_plat.h from smp.h
Hi ARM64 maintainers,
This patch series aims at enabling irq-bcm7038-l1.c on ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in order to avoid adding a CONFIG_ARM64 conditional inclusion of smp_plat.h, instead smp.h includes smp_plat.h, which is in turn included by linux/smp.h.
If you like the approach, I would suggest to carry that through the Broadcom ARM64 SoC pull request for 5.3.
Thank you!
Florian Fainelli (2):
arm64: smp: Include smp_plat.h from smp.h
arm64: Enable BCM7038_L1_IRQ for ARCH_BRCMSTB
arch/arm64/Kconfig.platforms | 1 + arch/arm64/include/asm/smp.h | 1 + arch/arm64/include/asm/smp_plat.h | 1 + 3 files changed, 3 insertions(+)
Signature · 1 line
2.17.1
PATCH 1/2 arm64: smp: Include smp_plat.h from smp.h
Most architectures provide the cpu_logical_map[] definition as part of asm/smp.h, which is included by linux/smp.h. For irqchip drivers that work across a variety of platforms (MIPS, ARM, ARM64, etc.), and making use of cpu_logical_map[] this avoids making any architecture specific include in those drivers.
smp_plat.h uses -EINVAL, so make sure that header file include linux/errmo.h.
--- arch/arm64/include/asm/smp.h | 1 + arch/arm64/include/asm/smp_plat.h | 1 + 2 files changed, 2 insertions(+)
arch/arm64/include/asm/smp.h +1 -0
@@ -37,6 +37,7 @@#ifndef __ASSEMBLY__#include <asm/percpu.h> +#include <asm/smp_plat.h> #include <linux/threads.h> #include <linux/cpumask.h>
arch/arm64/include/asm/smp_plat.h +1 -0
@@ -20,6 +20,7 @@#define __ASM_SMP_PLAT_H#include <linux/cpumask.h> +#include <linux/errno.h> #include <asm/types.h>
Signature · 1 line
2.17.1
PATCH 2/2 arm64: Enable BCM7038_L1_IRQ for ARCH_BRCMSTB
In reply to Florian FainelliARCH_BRCMSTB makes use of the irq-bcm7038-l1.c irqchip driver, enable it.
--- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+)
arch/arm64/Kconfig.platforms +1 -0
@@ -66,6 +66,7 @@ config ARCH_BITMAIN config ARCH_BRCMSTB bool "Broadcom Set-Top-Box SoCs" + select BCM7038_L1_IRQ select BRCMSTB_L2_IRQ select GENERIC_IRQ_CHIP help
Signature · 1 line
2.17.1
Florian Fainelli
AppliedRe: [PATCH 2/2] arm64: Enable BCM7038_L1_IRQ for ARCH_BRCMSTB
Quoted 4 lines · Florian Fainelli
ARCH_BRCMSTBmakes use of theirq-bcm7038-l1.cirqchip driver, enable it.Signed-off-by Florian Fainelli <[email protected]>
Applied to soc-arm64/next, thanks!
Signature · 1 line
Florian
Quoted 10 lines · Florian Fainelli
Hi ARM64 maintainers,
This patch series aims at enabling
irq-bcm7038-l1.con ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in order to avoid adding aCONFIG_ARM64conditional inclusion ofsmp_plat.h, insteadsmp.hincludessmp_plat.h, which is in turn included bylinux/smp.h.If you like the approach, I would suggest to carry that through the Broadcom ARM64 SoC pull request for 5.3.
ARM (32-bit) needs the same thing kind of thing so a conditional include may be appropriate after all...
Quoted 12 lines
Thank you!
Florian Fainelli (2):
arm64: smp: Includesmp_plat.hfromsmp.h
arm64: EnableBCM7038_L1_IRQforARCH_BRCMSTBarch/arm64/Kconfig.platforms | 1 + arch/arm64/include/asm/smp.h | 1 + arch/arm64/include/asm/smp_plat.h | 1 + 3 files changed, 3 insertions(+)
Signature · 1 line
Florian
Quoted 9 lines · Florian Fainelli
Quoted 8 lines · Florian Fainelli
Hi ARM64 maintainers,
This patch series aims at enabling
irq-bcm7038-l1.con ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in order to avoid adding aCONFIG_ARM64conditional inclusion ofsmp_plat.h, insteadsmp.hincludessmp_plat.h, which is in turn included bylinux/smp.h.
Quoted 5 lines
Quoted 2 lines
If you like the approach, I would suggest to carry that through the Broadcom ARM64 SoC pull request for 5.3.
ARM (32-bit) needs the same thing kind of thing so a conditional include may be appropriate after all...
The whole idea of the smp_plat.h vs smp.h separation is to avoid including lots of arch-private stuff in the rest of the kernel build, thereby exposing arch-private stuff to the world. I'm be opposed to that.
Quoted 23 lines
Quoted 13 lines
Thank you!
Florian Fainelli (2):
arm64: smp: Includesmp_plat.hfromsmp.h
arm64: EnableBCM7038_L1_IRQforARCH_BRCMSTBarch/arm64/Kconfig.platforms | 1 + arch/arm64/include/asm/smp.h | 1 + arch/arm64/include/asm/smp_plat.h | 1 + 3 files changed, 3 insertions(+)Signature · 6 lines
Florian _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Quoted 13 lines · Russell King - ARM Linux admin
Quoted 12 lines · Florian Fainelli
Quoted 10 lines · Florian Fainelli
Hi ARM64 maintainers,
This patch series aims at enabling
irq-bcm7038-l1.con ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in order to avoid adding aCONFIG_ARM64conditional inclusion ofsmp_plat.h, insteadsmp.hincludessmp_plat.h, which is in turn included bylinux/smp.h.If you like the approach, I would suggest to carry that through the Broadcom ARM64 SoC pull request for 5.3.
Quoted 7 lines
Quoted 2 lines
ARM (32-bit) needs the same thing kind of thing so a conditional include may be appropriate after all...
The whole idea of the
smp_plat.hvssmp.hseparation is to avoid including lots of arch-private stuff in the rest of the kernel build, thereby exposing arch-private stuff to the world. I'm be opposed to that.
I was on the fence, sent it just in case, but ended up doing this:
https://lore.kernel.org/patchwork/patch/1082410/
will take patch #2 through the Broadcom ARM64 SoC tree once this patch above gets accepted.
Signature · 1 line
Florian
Quoted 22 lines · Florian Fainelli
Quoted 13 lines · Russell King - ARM Linux admin
Quoted 12 lines · Florian Fainelli
Quoted 10 lines · Florian Fainelli
Hi ARM64 maintainers,
This patch series aims at enabling
irq-bcm7038-l1.con ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in order to avoid adding aCONFIG_ARM64conditional inclusion ofsmp_plat.h, insteadsmp.hincludessmp_plat.h, which is in turn included bylinux/smp.h.If you like the approach, I would suggest to carry that through the Broadcom ARM64 SoC pull request for 5.3.
Quoted 7 lines
Quoted 2 lines
ARM (32-bit) needs the same thing kind of thing so a conditional include may be appropriate after all...
The whole idea of the
smp_plat.hvssmp.hseparation is to avoid including lots of arch-private stuff in the rest of the kernel build, thereby exposing arch-private stuff to the world. I'm be opposed to that.
Quoted 6 lines
I was on the fence, sent it just in case, but ended up doing this:
https://lore.kernel.org/patchwork/patch/1082410/
will take patch #2 through the Broadcom ARM64 SoC tree once this patch above gets accepted.
Well, there's another alternative: we move just what is required from smp_plat.h to smp.h.
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Quoted 25 lines · Russell King - ARM Linux admin
Quoted 24 lines · Florian Fainelli
Quoted 13 lines · Russell King - ARM Linux admin
Quoted 12 lines · Florian Fainelli
Quoted 10 lines · Florian Fainelli
Hi ARM64 maintainers,
This patch series aims at enabling
irq-bcm7038-l1.con ARM64/ARCH_BRCMSTB, this driver makes use of cpu_logical_map[] and in order to avoid adding aCONFIG_ARM64conditional inclusion ofsmp_plat.h, insteadsmp.hincludessmp_plat.h, which is in turn included bylinux/smp.h.If you like the approach, I would suggest to carry that through the Broadcom ARM64 SoC pull request for 5.3.
Quoted 7 lines
Quoted 2 lines
ARM (32-bit) needs the same thing kind of thing so a conditional include may be appropriate after all...
The whole idea of the
smp_plat.hvssmp.hseparation is to avoid including lots of arch-private stuff in the rest of the kernel build, thereby exposing arch-private stuff to the world. I'm be opposed to that.I was on the fence, sent it just in case, but ended up doing this:
Quoted 7 lines
Quoted 4 lines
https://lore.kernel.org/patchwork/patch/1082410/
will take patch #2 through the Broadcom ARM64 SoC tree once this patch above gets accepted.
Well, there's another alternative: we move just what is required from
smp_plat.htosmp.h.
I think that's the best course of action, and would align arm/arm64 with mips, sparc, sh, xtensa and parisc.
Florian, do you mind writing these two patches?
Thanks,
M.
Signature · 1 line
Jazz is not dead. It just smells funny...