Skip to contentSkip to conversation

i40e: Remove unused RX realloc stat

PATCH New Joe Damato 3 participants 3 messages Jan 5, 2022 – Jan 14, 2022

Subsystems (2)
lore
Share & tools
lore

Joe Damato

author
#0 lore raw

PATCH v2 1/1 i40e: Remove unused RX realloc stat

After commit 1a557afc4dd5 ("i40e: Refactor receive routine"), rx_stats.realloc_count is no longer being incremented, so remove it.

The debugfs string was left, but hardcoded to 0. This is intended to prevent breaking any existing code / scripts that are parsing debugfs for i40e.

Fixes 1a557afc4dd5 ("i40e: Refactor receive routine")

---
v1 -> v2: Fix commit message to include one-line SHA summary. Patch is now
based on next-queue.
---

 drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +--
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_debugfs.c +1 -2
index 1e57cc8..90fff05 100644
@@ -275,9 +275,8 @@ static void i40e_dbg_dump_vsi_seid(struct i40e_pf *pf, int seid)
 			 rx_ring->rx_stats.alloc_page_failed,
 			 rx_ring->rx_stats.alloc_buff_failed);
 		dev_info(&pf->pdev->dev,
-			 "    rx_rings[%i]: rx_stats: realloc_count = %lld, page_reuse_count = %lld\n",
+			 "    rx_rings[%i]: rx_stats: realloc_count = 0, page_reuse_count = %lld\n",
 			 i,
-			 rx_ring->rx_stats.realloc_count,
 			 rx_ring->rx_stats.page_reuse_count);
 		dev_info(&pf->pdev->dev,
 			 "    rx_rings[%i]: size = %i\n",
drivers/net/ethernet/intel/i40e/i40e_txrx.h +0 -1
index fd22e2f..324699e 100644
@@ -298,7 +298,6 @@ struct i40e_rx_queue_stats {
 	u64 alloc_page_failed;
 	u64 alloc_buff_failed;
 	u64 page_reuse_count;
-	u64 realloc_count;
 	u64 page_alloc_count;
 	u64 page_waive_count;
 	u64 page_busy_count;
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 i40e: Remove unused RX realloc stat

Quoted 7 lines · Joe Damato

After commit 1a557afc4dd5 ("i40e: Refactor receive routine"), rx_stats.realloc_count is no longer being incremented, so remove it.

The debugfs string was left, but hardcoded to 0. This is intended to prevent breaking any existing code / scripts that are parsing debugfs for i40e.

Quoted 6 lines
Fixes 1a557afc4dd5 ("i40e: Refactor receive routine")

---
v1 -> v2: Fix commit message to include one-line SHA summary. Patch is now
based on next-queue.

#2 lore raw

PATCH v2 1/1 i40e: Remove unused RX realloc stat

In reply to Joe Damato
Quoted 19 lines

-----Original Message-----
From: Joe Damato <[email protected]>
Sent: Wednesday, January 5, 2022 9:19 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Brandeburg, Jesse <[email protected]>; Nguyen, Anthony L <[email protected]>; Joe Damato <[email protected]>
Subject: [next-queue,v2] i40e: Remove unused RX realloc stat

After commit 1a557afc4dd5 ("i40e: Refactor receive routine"), rx_stats.realloc_count is no longer being incremented, so remove it.

The debugfs string was left, but hardcoded to 0. This is intended to prevent breaking any existing code / scripts that are parsing debugfs for i40e.

Fixes 1a557afc4dd5 ("i40e: Refactor receive routine")
Quoted 8 lines

---
v1 -> v2: Fix commit message to include one-line SHA summary. Patch is now
based on next-queue.

---
 drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 3 +--
 drivers/net/ethernet/intel/i40e/i40e_txrx.h    | 1 -
 2 files changed, 1 insertion(+), 3 deletions(-)