Skip to contentSkip to conversation

x86/xen: remove deprecated IRQF_DISABLED

PATCH Boris Ostrovsky 2 participants 3 messages Sep 8, 2013 – Sep 9, 2013

lore
Share & tools
lore
#0 lore raw
Quoted 10 lines · ----- [email protected] wrote:

This patch proposes to remove the IRQF_DISABLED flag from x86/xen code. It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker
<[email protected]>

---
 arch/x86/xen/smp.c      | 10 +++++-----
 arch/x86/xen/spinlock.c |  2 +-
 arch/x86/xen/time.c     |  3 +--
 3 files changed, 7 insertions(+), 8 deletions(-)

If you are cleaning up Xen's use of IRQF_DISABLED then you should probably also update drivers/xen/evtchn.c and drivers/xen/platform-pci.c

-boris

#1 lore raw

Hi Boris,

Thanks for your review!

Quoted 13 lines · Boris Ostrovsky
Quoted 10 lines · ----- [email protected] wrote:

This patch proposes to remove the IRQF_DISABLED flag from x86/xen code. It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker
<[email protected]>

---
 arch/x86/xen/smp.c      | 10 +++++-----
 arch/x86/xen/spinlock.c |  2 +-
 arch/x86/xen/time.c     |  3 +--
 3 files changed, 7 insertions(+), 8 deletions(-)
Quoted 2 lines

If you are cleaning up Xen's use of IRQF_DISABLED then you should probably also update drivers/xen/evtchn.c and drivers/xen/platform-pci.c

This definitely makes sense to do this at the same time. I've just submitted a separate patch for this.

Thanks again,

Michael.

Signature · 4 lines
Michael Opdenacker, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
#2 lore raw
In reply to Boris Ostrovsky

Hi Boris,

Thanks for your review!

Quoted 13 lines · Boris Ostrovsky
Quoted 10 lines · ----- [email protected] wrote:

This patch proposes to remove the IRQF_DISABLED flag from x86/xen code. It's a NOOP since 2.6.35 and it will be removed one day.

Signed-off-by: Michael Opdenacker
<[email protected]>

---
 arch/x86/xen/smp.c      | 10 +++++-----
 arch/x86/xen/spinlock.c |  2 +-
 arch/x86/xen/time.c     |  3 +--
 3 files changed, 7 insertions(+), 8 deletions(-)
Quoted 2 lines

If you are cleaning up Xen's use of IRQF_DISABLED then you should probably also update drivers/xen/evtchn.c and drivers/xen/platform-pci.c

This definitely makes sense to do this at the same time. I've just submitted a separate patch for this.

Thanks again,

Michael.

Signature · 4 lines
Michael Opdenacker, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098