Skip to contentSkip to conversation

e1000e: Add support to 0x15F5 Device Id of Tiger Lake

PATCH New Vitaly Lifshits 2 participants 5 messages Jan 19, 2020 – Jan 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Added support to 0x15F5 Device ID which is part of Intel Tiger Lake Platforms. This patch follows commit:
776f5d57ee ("e1000e: Add support for Tiger Lake").

---
 drivers/net/ethernet/intel/e1000e/hw.h     | 1 +
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
 2 files changed, 2 insertions(+)
drivers/net/ethernet/intel/e1000e/hw.h +1 -0
index f556163481cb..b85210ef31d9 100644
@@ -97,6 +97,7 @@ struct e1000_hw;
 #define E1000_DEV_ID_PCH_TGP_I219_LM14		0x15F9
 #define E1000_DEV_ID_PCH_TGP_I219_V14		0x15FA
 #define E1000_DEV_ID_PCH_TGP_I219_LM15		0x15F4
+#define E1000_DEV_ID_PCH_TGP_I219_V15		0x15F5
 
 #define E1000_REVISION_4	4
 
drivers/net/ethernet/intel/e1000e/netdev.c +1 -0
index 8797913b2702..3c3624f276d5 100644
@@ -7764,6 +7764,7 @@ static const struct pci_device_id e1000_pci_tbl[] = {
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM14), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V14), board_pch_cnp },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM15), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V15), board_pch_cnp },
 
 	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
 };
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Quoted 28 lines · Vitaly Lifshits

Added support to 0x15F5 Device ID which is part of Intel Tiger Lake Platforms. This patch follows commit:
776f5d57ee ("e1000e: Add support for Tiger Lake").

---
  drivers/net/ethernet/intel/e1000e/hw.h     | 1 +
  drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
  2 files changed, 2 insertions(+)
drivers/net/ethernet/intel/e1000e/hw.h +1 -0
index f556163481cb..b85210ef31d9 100644
@@ -97,6 +97,7 @@ struct e1000_hw;
  #define E1000_DEV_ID_PCH_TGP_I219_LM14		0x15F9
  #define E1000_DEV_ID_PCH_TGP_I219_V14		0x15FA
  #define E1000_DEV_ID_PCH_TGP_I219_LM15		0x15F4
+#define E1000_DEV_ID_PCH_TGP_I219_V15		0x15F5
 
  #define E1000_REVISION_4	4
 
drivers/net/ethernet/intel/e1000e/netdev.c +0 -0
index 8797913b2702..3c3624f276d5 100644

drivers/net/ethernet/intel/e1000e/netdev.c static const struct pci_device_id e1000_pci_tbl[] = { · line 7770

Quoted 7 lines
drivers/net/ethernet/intel/e1000e/netdev.c +1 -0
@@ -7764,6 +7764,7 @@ static const struct pci_device_id e1000_pci_tbl[] = {
  	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM14), board_pch_cnp },
  	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V14), board_pch_cnp },
  	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_LM15), board_pch_cnp },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_TGP_I219_V15), board_pch_cnp },
 
  	{ 0, 0, 0, 0, 0, 0, 0 }	/* terminate list */
  };
#2 lore raw

PATCH 1/1 e1000e: Add support to 0x15F5 Device Id of Tiger Lake

In reply to Vitaly Lifshits
Quoted 23 lines

From: Intel-wired-lan <[email protected]> On Behalf Of Vitaly Lifshits
Sent: Sunday, January 19, 2020 2:08 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Added support to 0x15F5 Device ID which is part of Intel Tiger Lake Platforms. This patch follows commit:
776f5d57ee ("e1000e: Add support for Tiger Lake").

---
 drivers/net/ethernet/intel/e1000e/hw.h     | 1 +
 drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
 2 files changed, 2 insertions(+)
drivers/net/ethernet/intel/e1000e/hw.h +0 -0
index f556163481cb..b85210ef31d9 100644

drivers/net/ethernet/intel/e1000e/hw.h struct e1000_hw; · line 100

Quoted 4 lines
drivers/net/ethernet/intel/e1000e/hw.h +1 -0
@@ -97,6 +97,7 @@ struct e1000_hw;
 #define E1000_DEV_ID_PCH_TGP_I219_LM14		0x15F9
 #define E1000_DEV_ID_PCH_TGP_I219_V14		0x15FA
 #define E1000_DEV_ID_PCH_TGP_I219_LM15		0x15F4
+#define E1000_DEV_ID_PCH_TGP_I219_V15		0x15F5

<snip>

Something seems to be missing. After building and booting to the kernel with this patch included I do not see the 15f5 device from modinfo:
u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5
u1519:[1]/usr/src/kernels/next-queue>

#3 lore raw

PATCH 1/1 e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Quoted 29 lines · Aaron F
Quoted 27 lines

From: Intel-wired-lan <[email protected]> On Behalf Of Vitaly Lifshits
Sent: Sunday, January 19, 2020 2:08 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Added support to 0x15F5 Device ID which is part of Intel Tiger Lake Platforms. This patch follows commit:
776f5d57ee ("e1000e: Add support for Tiger Lake").

---
  drivers/net/ethernet/intel/e1000e/hw.h     | 1 +
  drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
  2 files changed, 2 insertions(+)
drivers/net/ethernet/intel/e1000e/hw.h +1 -0
index f556163481cb..b85210ef31d9 100644
@@ -97,6 +97,7 @@ struct e1000_hw;
  #define E1000_DEV_ID_PCH_TGP_I219_LM14		0x15F9
  #define E1000_DEV_ID_PCH_TGP_I219_V14		0x15FA
  #define E1000_DEV_ID_PCH_TGP_I219_LM15		0x15F4
+#define E1000_DEV_ID_PCH_TGP_I219_V15		0x15F5

<snip>

Quoted 4 lines

Something seems to be missing. After building and booting to the kernel with this patch included I do not see the 15f5 device from modinfo:
u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5
u1519:[1]/usr/src/kernels/next-queue>

If I understand your test correctly, I think you should run:

Quoted 1 line

modinfo e1000e | grep -i 15f5

Since the patch is to e1000e module and not igc.

#4 lore raw

PATCH 1/1 e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Quoted 7 lines

From: Lifshits, Vitaly <[email protected]>
Sent: Saturday, January 25, 2020 4:22 AM
To: Brown, Aaron F <[email protected]>; intel-wired- lan at lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5 Device Id of Tiger Lake

Quoted 19 lines
Quoted 1 line · Aaron F
Quoted 1 line

From: Intel-wired-lan <[email protected]> On Behalf

Of

Quoted 4 lines
Quoted 4 lines

Vitaly Lifshits
Sent: Sunday, January 19, 2020 2:08 AM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH v1] e1000e: Add support to 0x15F5

Device

Quoted 11 lines
Quoted 11 lines

Id of Tiger Lake

Added support to 0x15F5 Device ID which is part of Intel Tiger Lake Platforms. This patch follows commit:
776f5d57ee ("e1000e: Add support for Tiger Lake").

---
  drivers/net/ethernet/intel/e1000e/hw.h     | 1 +
  drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
  2 files changed, 2 insertions(+)
Quoted 4 lines
Quoted 3 lines
Quoted 1 line

<snip>

Something seems to be missing. After building and booting to the kernel

with this patch included I do not see the 15f5 device from modinfo:

Quoted 8 lines
Quoted 3 lines

u1519:[1]/usr/src/kernels/next-queue> modinfo igc|grep -i 15f5 u1519:[1]/usr/src/kernels/next-queue>

If I understand your test correctly, I think you should run:

Quoted 1 line

modinfo e1000e | grep -i 15f5

Since the patch is to e1000e module and not igc.

Yes of course, thanks. End of a long week ://)

u1459:[1]/usr/src/kernels/next-queue> modinfo e1000e | grep -i 15f5
alias: pci:v00008086d000015F5sv*sd*bc*sc*i*
u1459:[1]/usr/src/kernels/next-queue>