Skip to contentSkip to conversation

wvstreams: fixing segfault with new gcc optimizations

PATCH In review Ray Kinsella 2 participants 3 messages May 6, 2016 – Jun 14, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wvstreams: fixing segfault with new gcc optimizations

Recent GCC optimizations -ftree-dce and -foptimize-sibling-calls are causing a segfault in the wvstream stackmaster. Fedora had the same problem and resolved the issue by removing these optimizations.

See: https://bugzilla.redhat.com/show_bug.cgi?id=812651

---
 meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb +2 -0
index 73cfb03..6199a2f 100644
@@ -20,6 +20,8 @@ inherit autotools-brokensep pkgconfig
 
 PARALLEL_MAKE = ""
 
+TARGET_CFLAGS_append = " -fno-tree-dce -fno-optimize-sibling-calls"
+
 LDFLAGS_append = " -Wl,-rpath-link,${CROSS_DIR}/${TARGET_SYS}/lib"
 
 EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-valgrind"
Signature · 1 line
1.8.5.6
#1 lore raw

Hi Martin,

What should I do to progress this?

Ray K

Quoted 25 lines · Ray

Recent GCC optimizations -ftree-dce and -foptimize-sibling-calls are causing a segfault in the wvstream stackmaster. Fedora had the same problem and resolved the issue by removing these optimizations.

See: https://bugzilla.redhat.com/show_bug.cgi?id=812651

---
 meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb +2 -0
index 73cfb03..6199a2f 100644
@@ -20,6 +20,8 @@ inherit autotools-brokensep pkgconfig
 
 PARALLEL_MAKE = ""
 
+TARGET_CFLAGS_append = " -fno-tree-dce -fno-optimize-sibling-calls"
+
 LDFLAGS_append = " -Wl,-rpath-link,${CROSS_DIR}/${TARGET_SYS}/lib"
 
 EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-valgrind"
#2 lore raw
Quoted 3 lines · Ray

Hi Martin,

What should I do to progress this?

What progress you're expecting? it was merged more than a month ago:

commit 786ab843f0eb825781df5b4c639b6ae5f4c74c41

Author:     Kinsella, Ray <[email protected]>
AuthorDate: Fri May 6 14:49:19 2016 +0100
Commit:     Martin Jansa <[email protected]>
CommitDate: Tue May 10 20:18:56 2016 +0200
Quoted 29 lines

Ray K

Quoted 25 lines · Ray

Recent GCC optimizations -ftree-dce and -foptimize-sibling-calls are causing a segfault in the wvstream stackmaster. Fedora had the same problem and resolved the issue by removing these optimizations.

See: https://bugzilla.redhat.com/show_bug.cgi?id=812651

---
 meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-connectivity/wvdial/wvstreams_4.6.1.bb +2 -0
index 73cfb03..6199a2f 100644
@@ -20,6 +20,8 @@ inherit autotools-brokensep pkgconfig
 
 PARALLEL_MAKE = ""
 
+TARGET_CFLAGS_append = " -fno-tree-dce -fno-optimize-sibling-calls"
+
 LDFLAGS_append = " -Wl,-rpath-link,${CROSS_DIR}/${TARGET_SYS}/lib"
 
 EXTRA_OECONF = " --without-tcl --without-qt --without-pam --without-valgrind"
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]