Skip to contentSkip to conversation

scsi: qla2xxx: remove trailing semicolon in macro definition

PATCH In review [email protected] 2 participants 5 messages Nov 27, 2020 – Nov 30, 2020 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: qla2xxx: remove trailing semicolon in macro definition

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

---
 drivers/scsi/qla2xxx/qla_def.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_def.h +1 -1
index ed9b10f8537d..86d249551b2d 100644
@@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
 } while (0)
 
 #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
-	atomic_dec(&__qpair->ref_count);		\
+	atomic_dec(&__qpair->ref_count)		\
 
 
 #define QLA_ENA_CONF(_ha) {\
Signature · 1 line
2.18.4
Reviewed-by on v1 1/1
#1 lore raw

Hi Tom,

Quoted 5 lines · On Fri, Nov 27, 2020 at 10:27:41AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

Quoted 9 lines
---
 drivers/scsi/qla2xxx/qla_def.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_def.h +0 -0
index ed9b10f8537d..86d249551b2d 100644

drivers/scsi/qla2xxx/qla_def.h struct secure_flash_update_block_pk { · line 4973

Quoted 5 lines
drivers/scsi/qla2xxx/qla_def.h +1 -1
@@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
 } while (0)
 
 #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
-	atomic_dec(&__qpair->ref_count);		\
+	atomic_dec(&__qpair->ref_count)		\

Nitpick, please insert an additional tab after the remove so that the backlashes align again.

Thanks,
Daniel

A message that is not in the archive (sent off-list or not yet received): CAHo-Oow4nPR9ODya-cPHZrsMFFPF9aUJJXfrFqLCxRzmJVMrmA@mail.gmail.com

#3 lore raw
Quoted 5 lines · Maciej Żenczykowski
Quoted 4 lines · Daniel Wagner
Quoted 3 lines

#define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \

drivers/scsi/qla2xxx/qla_def.h +1 -1
-     atomic_dec(&__qpair->ref_count);                \
+     atomic_dec(&__qpair->ref_count)         \
Quoted 7 lines
Quoted 3 lines

Nitpick, please insert an additional tab after the remove so that the backlashes align again.

Uhm, if there's no semicolon, then presumably it's the final line of the macro, and thus there should be no tabs and no backslash at the end of the line.

Right! Didn't realize it. The backslash should be removed.

author
#4 lore raw
In reply to Daniel Wagner
Quoted 21 lines · Daniel Wagner

Hi Tom,

Quoted 5 lines · On Fri, Nov 27, 2020 at 10:27:41AM -0800, [email protected] wrote:

From: Tom Rix <[email protected]>

The macro use will already have a semicolon.

Quoted 11 lines
---
 drivers/scsi/qla2xxx/qla_def.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qla2xxx/qla_def.h +0 -0
index ed9b10f8537d..86d249551b2d 100644
@@ -4970,7 +4970,7 @@ struct secure_flash_update_block_pk {
 } while (0)
 
Quoted 5 lines

drivers/scsi/qla2xxx/qla_def.h struct secure_flash_update_block_pk { · line 4973

Quoted 3 lines
drivers/scsi/qla2xxx/qla_def.h +1 -1
 #define QLA_QPAIR_MARK_NOT_BUSY(__qpair)		\
-	atomic_dec(&__qpair->ref_count);		\
+	atomic_dec(&__qpair->ref_count)		\

Nitpick, please insert an additional tab after the remove so that the backlashes align again.

How about removing the last escaped newline and the next empty line ?

Tom

Quoted 4 lines

Thanks,
Daniel

#5 lore raw
Quoted 7 lines
Quoted 5 lines

drivers/scsi/qla2xxx/qla_def.h struct secure_flash_update_block_pk { · line 4973

Quoted 3 lines

#define QLA_QPAIR_MARK_NOT_BUSY(__qpair) \

drivers/scsi/qla2xxx/qla_def.h +1 -1
-	atomic_dec(&__qpair->ref_count);		\
+	atomic_dec(&__qpair->ref_count)		\

Nitpick, please insert an additional tab after the remove so that the backlashes align again.

How about removing the last escaped newline and the next empty line ?

Yes please.