drm/amdgpu: add tmr mac address
Subsystems (2)
PATCH 1/4 drm/amdgpu: add tmr mac address
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +3 -0
@@ -226,6 +226,9 @@ struct amdgpu_firmware_info {void *kaddr;/* ucode_size_bytes */ uint32_t ucode_size; +/* starting tmr mc address */ +uint32_t tmr_mc_addr_lo; +uint32_t tmr_mc_addr_hi; };void amdgpu_ucode_print_mc_hdr (const struct common_firmware_header *hdr);
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1533829288-3490-1-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org
PATCH 2/4 drm/amdgpu: update tmr mac address
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +++++ 1 file changed, 5 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +5 -0
@@ -131,6 +131,11 @@ psp_cmd_submit_buf(struct psp_context *psp,msleep (1 ); } +if (ucode) { + ucode->tmr_mc_addr_lo = psp->cmd_buf_mem->resp.fw_addr_lo; + ucode->tmr_mc_addr_hi = psp->cmd_buf_mem->resp.fw_addr_hi; + } +return ret; }
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1533829288-3490-2-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Reviewed-byRe: [PATCH 2/4] drm/amdgpu: update tmr mac address
Quoted 1 line · James Zhu
Signed-off-by James Zhu <[email protected]>
Please include a patch description. E.g.,
Track the TMR address returned by the PSP for later use by the driver when setting up the IPs.
With that fixed:
Quoted 23 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 5 +++++ 1 file changed, 5 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c +5
-1@@ -131,6 +131,11 @@ psp_cmd_submit_buf(struct psp_context *psp,msleep (1 ); } +if (ucode) { + ucode->tmr_mc_addr_lo = psp->cmd_buf_mem->resp.fw_addr_lo; + ucode->tmr_mc_addr_hi = psp->cmd_buf_mem->resp.fw_addr_hi; + } +return ret; } --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 3/4 drm/amdgpu: add unicode AMDGPU_UCODE_ID_VCN
In reply to a message not in the archive--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 +++ 2 files changed, 4 insertions(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +1 -0
@@ -194,6 +194,7 @@ enum AMDGPU_UCODE_ID {AMDGPU_UCODE_ID_SMC ,AMDGPU_UCODE_ID_UVD ,AMDGPU_UCODE_ID_VCE , +AMDGPU_UCODE_ID_VCN , AMDGPU_UCODE_ID_MAXIMUM, };
drivers/gpu/drm/amd/amdgpu/psp_v10_0.c +3 -0
@@ -88,6 +88,9 @@ psp_v10_0_get_fw_type(struct amdgpu_firmware_info *ucode, enum psp_gfx_fw_type *case AMDGPU_UCODE_ID_VCE : *type =GFX_FW_TYPE_VCE ;break ; +case AMDGPU_UCODE_ID_VCN : + *type =GFX_FW_TYPE_VCN ; +break ;case AMDGPU_UCODE_ID_MAXIMUM :default :return -EINVAL ;
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1533829288-3490-3-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org
Re: [PATCH 3/4] drm/amdgpu: add unicode AMDGPU_UCODE_ID_VCN
Quoted 1 line · James Zhu
Signed-off-by James Zhu <[email protected]>
The subject doesn't really make sense. Please also include a patch description. This should also be split into two patches, one to add the new id to the enum and one to add support for VCN to the psp driver.
Alex
Quoted 34 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 1 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 3 +++ 2 files changed, 4 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +1
-0@@ -194,6 +194,7 @@ enum AMDGPU_UCODE_ID {AMDGPU_UCODE_ID_SMC ,AMDGPU_UCODE_ID_UVD ,AMDGPU_UCODE_ID_VCE , +AMDGPU_UCODE_ID_VCN , AMDGPU_UCODE_ID_MAXIMUM, };drivers/gpu/drm/amd/amdgpu/psp_v10_0.c +3
-1@@ -88,6 +88,9 @@ psp_v10_0_get_fw_type(struct amdgpu_firmware_info *ucode, enum psp_gfx_fw_type *case AMDGPU_UCODE_ID_VCE : *type =GFX_FW_TYPE_VCE ;break ; +case AMDGPU_UCODE_ID_VCN : + *type =GFX_FW_TYPE_VCN ; +break ;case AMDGPU_UCODE_ID_MAXIMUM :default :return -EINVAL ; --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
PATCH 4/4 drm/amdgpu: add psp firmware loading for vcn
In reply to a message not in the archive--- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 17 +++++++++------ drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 38 ++++++++++++++++++++++++++------- 2 files changed, 40 insertions(+), 15 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +10 -7
@@ -111,9 +111,10 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev) version_major, version_minor, family_id); } - bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) - +AMDGPU_VCN_STACK_SIZE +AMDGPU_VCN_HEAP_SIZE + bo_size =AMDGPU_VCN_STACK_SIZE +AMDGPU_VCN_HEAP_SIZE +AMDGPU_VCN_SESSION_SIZE *40 ; +if (adev->firmware.load_type !=AMDGPU_FW_LOAD_PSP ) + bo_size +=AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ); r =amdgpu_bo_create_kernel (adev, bo_size,PAGE_SIZE ,AMDGPU_GEM_DOMAIN_VRAM , &adev->vcn.vcpu_bo, &adev->vcn.gpu_addr, &adev->vcn.cpu_addr);
@@ -189,11 +190,13 @@ int amdgpu_vcn_resume(struct amdgpu_device *adev)unsigned offset; hdr = (const struct common_firmware_header *)adev->vcn.fw->data; - offset =le32_to_cpu (hdr->ucode_array_offset_bytes); -memcpy_toio (adev->vcn.cpu_addr, adev->vcn.fw->data + offset, -le32_to_cpu (hdr->ucode_size_bytes)); - size -=le32_to_cpu (hdr->ucode_size_bytes); - ptr +=le32_to_cpu (hdr->ucode_size_bytes); +if (adev->firmware.load_type !=AMDGPU_FW_LOAD_PSP ) { + offset =le32_to_cpu (hdr->ucode_array_offset_bytes); +memcpy_toio (adev->vcn.cpu_addr, adev->vcn.fw->data + offset, +le32_to_cpu (hdr->ucode_size_bytes)); + size -=le32_to_cpu (hdr->ucode_size_bytes); + ptr +=le32_to_cpu (hdr->ucode_size_bytes); + }memset_io (ptr,0 , size); }
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c +30 -8
@@ -100,6 +100,16 @@ static int vcn_v1_0_sw_init(void *handle)if (r)return r; +if (adev->firmware.load_type ==AMDGPU_FW_LOAD_PSP ) { +const struct common_firmware_header *hdr; + hdr = (const struct common_firmware_header *)adev->vcn.fw->data; + adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].ucode_id =AMDGPU_UCODE_ID_VCN ; + adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].fw = adev->vcn.fw; + adev->firmware.fw_size += +ALIGN (le32_to_cpu (hdr->ucode_size_bytes),PAGE_SIZE ); +DRM_INFO ("PSP loading VCN firmware\n" ); + } + r =amdgpu_vcn_resume (adev);if (r)return r;
@@ -265,26 +275,38 @@ static int vcn_v1_0_resume(void *handle)static void vcn_v1_0_mc_resume (struct amdgpu_device *adev) {uint32_t size =AMDGPU_GPU_PAGE_ALIGN (adev->vcn.fw->size +4 ); - -WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW, +uint32_t offset; + +if (adev->firmware.load_type ==AMDGPU_FW_LOAD_PSP ) { +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW, + (adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].tmr_mc_addr_lo)); +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH, + (adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].tmr_mc_addr_hi)); +WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET0,0 ); + offset =0 ; + }else { +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW,lower_32_bits (adev->vcn.gpu_addr)); -WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH, +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH,upper_32_bits (adev->vcn.gpu_addr)); -WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET0, + offset = size; +WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET0,AMDGPU_UVD_FIRMWARE_OFFSET >>3 ); + } +WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_SIZE0, size);WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE1_64BIT_BAR_LOW, -lower_32_bits (adev->vcn.gpu_addr + size)); +lower_32_bits (adev->vcn.gpu_addr + offset));WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE1_64BIT_BAR_HIGH, -upper_32_bits (adev->vcn.gpu_addr + size)); +upper_32_bits (adev->vcn.gpu_addr + offset));WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET1,0 );WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_SIZE1,AMDGPU_VCN_HEAP_SIZE );WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE2_64BIT_BAR_LOW, -lower_32_bits (adev->vcn.gpu_addr + size +AMDGPU_VCN_HEAP_SIZE )); +lower_32_bits (adev->vcn.gpu_addr + offset +AMDGPU_VCN_HEAP_SIZE ));WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE2_64BIT_BAR_HIGH, -upper_32_bits (adev->vcn.gpu_addr + size +AMDGPU_VCN_HEAP_SIZE )); +upper_32_bits (adev->vcn.gpu_addr + offset +AMDGPU_VCN_HEAP_SIZE ));WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET2,0 );WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_SIZE2,AMDGPU_VCN_STACK_SIZE + (AMDGPU_VCN_SESSION_SIZE *40 ));
Signature · 6 lines
2.7.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 1533829288-3490-4-git-send-email-James.Zhu-5C7GfCeVMHo@public.gmane.org
Alex Deucher
Reviewed-byRe: [PATCH 4/4] drm/amdgpu: add psp firmware loading for vcn
Quoted 1 line · James Zhu
Signed-off-by James Zhu <[email protected]>
Please include a patch description. E.g., update VCN code to handle firmware loading via the psp. With that fixed:
Alex
Quoted 112 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 17 +++++++++------ drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 38 ++++++++++++++++++++++++++------- 2 files changed, 40 insertions(+), 15 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c +10
-7@@ -111,9 +111,10 @@ int amdgpu_vcn_sw_init(struct amdgpu_device *adev) version_major, version_minor, family_id); } - bo_size =AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ) - +AMDGPU_VCN_STACK_SIZE +AMDGPU_VCN_HEAP_SIZE + bo_size =AMDGPU_VCN_STACK_SIZE +AMDGPU_VCN_HEAP_SIZE +AMDGPU_VCN_SESSION_SIZE *40 ; +if (adev->firmware.load_type !=AMDGPU_FW_LOAD_PSP ) + bo_size +=AMDGPU_GPU_PAGE_ALIGN (le32_to_cpu (hdr->ucode_size_bytes) +8 ); r =amdgpu_bo_create_kernel (adev, bo_size,PAGE_SIZE ,AMDGPU_GEM_DOMAIN_VRAM , &adev->vcn.vcpu_bo, &adev->vcn.gpu_addr, &adev->vcn.cpu_addr);@@ -189,11 +190,13 @@ int amdgpu_vcn_resume(struct amdgpu_device *adev)unsigned offset; hdr = (const struct common_firmware_header *)adev->vcn.fw->data; - offset =le32_to_cpu (hdr->ucode_array_offset_bytes); -memcpy_toio (adev->vcn.cpu_addr, adev->vcn.fw->data + offset, -le32_to_cpu (hdr->ucode_size_bytes)); - size -=le32_to_cpu (hdr->ucode_size_bytes); - ptr +=le32_to_cpu (hdr->ucode_size_bytes); +if (adev->firmware.load_type !=AMDGPU_FW_LOAD_PSP ) { + offset =le32_to_cpu (hdr->ucode_array_offset_bytes); +memcpy_toio (adev->vcn.cpu_addr, adev->vcn.fw->data + offset, +le32_to_cpu (hdr->ucode_size_bytes)); + size -=le32_to_cpu (hdr->ucode_size_bytes); + ptr +=le32_to_cpu (hdr->ucode_size_bytes); + }memset_io (ptr,0 , size); }drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c +30
-9@@ -100,6 +100,16 @@ static int vcn_v1_0_sw_init(void *handle)if (r)return r; +if (adev->firmware.load_type ==AMDGPU_FW_LOAD_PSP ) { +const struct common_firmware_header *hdr; + hdr = (const struct common_firmware_header *)adev->vcn.fw->data; + adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].ucode_id =AMDGPU_UCODE_ID_VCN ; + adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].fw = adev->vcn.fw; + adev->firmware.fw_size += +ALIGN (le32_to_cpu (hdr->ucode_size_bytes),PAGE_SIZE ); +DRM_INFO ("PSP loading VCN firmware\n" ); + } + r =amdgpu_vcn_resume (adev);if (r)return r;@@ -265,26 +275,38 @@ static int vcn_v1_0_resume(void *handle)static void vcn_v1_0_mc_resume (struct amdgpu_device *adev) {uint32_t size =AMDGPU_GPU_PAGE_ALIGN (adev->vcn.fw->size +4 ); - -WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW, +uint32_t offset; + +if (adev->firmware.load_type ==AMDGPU_FW_LOAD_PSP ) { +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW, + (adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].tmr_mc_addr_lo)); +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH, + (adev->firmware.ucode[AMDGPU_UCODE_ID_VCN ].tmr_mc_addr_hi)); +WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET0,0 ); + offset =0 ; + }else { +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_LOW,lower_32_bits (adev->vcn.gpu_addr)); -WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH, +WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH,upper_32_bits (adev->vcn.gpu_addr)); -WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET0, + offset = size; +WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET0,AMDGPU_UVD_FIRMWARE_OFFSET >>3 ); + } +WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_SIZE0, size);WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE1_64BIT_BAR_LOW, -lower_32_bits (adev->vcn.gpu_addr + size)); +lower_32_bits (adev->vcn.gpu_addr + offset));WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE1_64BIT_BAR_HIGH, -upper_32_bits (adev->vcn.gpu_addr + size)); +upper_32_bits (adev->vcn.gpu_addr + offset));WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET1,0 );WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_SIZE1,AMDGPU_VCN_HEAP_SIZE );WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE2_64BIT_BAR_LOW, -lower_32_bits (adev->vcn.gpu_addr + size +AMDGPU_VCN_HEAP_SIZE )); +lower_32_bits (adev->vcn.gpu_addr + offset +AMDGPU_VCN_HEAP_SIZE ));WREG32_SOC15 (UVD ,0 , mmUVD_LMI_VCPU_CACHE2_64BIT_BAR_HIGH, -upper_32_bits (adev->vcn.gpu_addr + size +AMDGPU_VCN_HEAP_SIZE )); +upper_32_bits (adev->vcn.gpu_addr + offset +AMDGPU_VCN_HEAP_SIZE ));WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_OFFSET2,0 );WREG32_SOC15 (UVD ,0 , mmUVD_VCPU_CACHE_SIZE2,AMDGPU_VCN_STACK_SIZE + (AMDGPU_VCN_SESSION_SIZE *40 )); --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
Reviewed-byQuoted 1 line · James Zhu
Signed-off-by James Zhu <[email protected]>
Please include a commit message. E.g., Track the TMR address for VCN PSP firmware loading.
With that added:
Quoted 21 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +3
-1@@ -226,6 +226,9 @@ struct amdgpu_firmware_info {void *kaddr;/* ucode_size_bytes */ uint32_t ucode_size; +/* starting tmr mc address */ +uint32_t tmr_mc_addr_lo; +uint32_t tmr_mc_addr_hi; };void amdgpu_ucode_print_mc_hdr (const struct common_firmware_header *hdr); --2.7.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): CADnq5_NWem6wbZNLCaFMmsHkkOo+mx2xbtbHme4pTgriiP7FWA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org
Hi Alex
Sure, I will send out V2 with the fix.
thanks!
James Zhu
Quoted 25 lines · Alex Deucher
Quoted 1 line · James Zhu
Signed-off-by James Zhu <[email protected]>Please include a commit message. E.g., Track the TMR address for VCN PSP firmware loading.
With that added:
Reviewed-by Alex Deucher <[email protected]>Quoted 17 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +3
-0@@ -226,6 +226,9 @@ struct amdgpu_firmware_info {void *kaddr;/* ucode_size_bytes */ uint32_t ucode_size; +/* starting tmr mc address */ +uint32_t tmr_mc_addr_lo; +uint32_t tmr_mc_addr_hi; };
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +0
-1void amdgpu_ucode_print_mc_hdr (const struct common_firmware_header *hdr); --2.7.4
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
I just read the headline and thought, what are we doing with "mac addresses"? This is not a network driver.
I think MC address stands for "memory controller" address. I think nowadays that's basically a synonym for VMID 0 virtual address.
Regards,
Felix
Quoted 10 lines · James Zhu
Signed-off-by James Zhu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 3 +++ 1 file changed, 3 insertions(+)drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h struct amdgpu_firmware_info { · line 234
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h +3
-0@@ -226,6 +226,9 @@ struct amdgpu_firmware_info {void *kaddr;/* ucode_size_bytes */ uint32_t ucode_size; +/* starting tmr mc address */ +uint32_t tmr_mc_addr_lo; +uint32_t tmr_mc_addr_hi; };void amdgpu_ucode_print_mc_hdr (const struct common_firmware_header *hdr);
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx