scsi: ufs: Fix the build for the old ARM OABI
PATCH 1/1 scsi: ufs: Fix the build for the old ARM OABI
All structs and unions are word aligned when using the OABI. Mark the union in struct utp_upiu_header as packed to prevent that the compiler inserts padding bytes.
--- include/uapi/scsi/scsi_bsg_ufs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/uapi/scsi/scsi_bsg_ufs.h +1 -1
@@ -83,7 +83,7 @@ struct utp_upiu_header {union {__u8 tm_function;__u8 query_function; - }; + } __attribute__((packed));__u8 response;__u8 status;__u8 ehs_length;
Quoted 10 lines · Bart Van Assche
All structs and unions are word aligned when using the OABI. Mark the union in struct
utp_upiu_headeras packed to prevent that the compiler inserts padding bytes.Cc Arnd Bergmann <[email protected]>Reported-by kernel test robot <[email protected]>Closes:
https://lore.kernel.org/oe-kbuild-all/[email protected]/Fixes 617bfaa8dd50 ("scsi: ufs: Simplify response header parsing")Signed-off-by Bart Van Assche <[email protected]>
Quoted 9 lines · Bart Van Assche
All structs and unions are word aligned when using the OABI. Mark the union in struct
utp_upiu_headeras packed to prevent that the compiler inserts padding bytes.Cc Arnd Bergmann<[email protected]>Reported-by kernel test robot<[email protected]>Fixes 617bfaa8dd50 ("scsi: ufs: Simplify response header parsing")Signed-off-by Bart Van Assche<[email protected]>
Thanks for the prompt fix!
Martin K. Petersen
AppliedBart,
Quoted 3 lines
All structs and unions are word aligned when using the OABI. Mark the union in struct
utp_upiu_headeras packed to prevent that the compiler inserts padding bytes.
Applied to 6.6/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 5 lines · Bart Van Assche
All structs and unions are word aligned when using the OABI. Mark the union in struct
utp_upiu_headeras packed to prevent that the compiler inserts padding bytes.
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: ufs: Fix the build for the old ARM OABI
https://git.kernel.org/mkp/scsi/c/d0bac0ec89d6
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering