fixes and cleanups for block_device refcounting v2
Subsystems (3)
Hi Jens,
this series fixes up a possible race with the block_device lookup changes, and the finishes off the conversion to stop using the inode refcount for block devices.
Changes since v1:
- clean up btrfs even more by storing a bdev instead of the disk
- keep a persistent disk reference in the bdev
- a bunch of cleanups to make the above change easier
Diffstat:
block/genhd.c | 12 +----- block/partitions/core.c | 34 ++++++++++--------- drivers/block/loop.c | 5 -- fs/block_dev.c | 83 ++++++++++++++---------------------------------- fs/btrfs/inode.c | 2 - fs/btrfs/ordered-data.c | 2 - fs/btrfs/ordered-data.h | 3 - fs/btrfs/zoned.c | 12 ++---- include/linux/blkdev.h | 2 - 9 files changed, 52 insertions(+), 103 deletions(-)
PATCH 1/9 block: delay freeing the gendisk
blkdev_get_no_open acquires a reference to the block_device through the block device inode and then tries to acquire a device model reference to the gendisk. But at this point the disk migh already be freed (although the race is free). Fix this by only freeing the gendisk from the whole device bdevs ->free_inode callback as well.
--- block/genhd.c | 3 +-- fs/block_dev.c | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-)
block/genhd.c +1 -2
@@ -1079,10 +1079,9 @@ static void disk_release(struct device *dev)disk_release_events (disk);kfree (disk->random);xa_destroy (&disk->part_tbl); -bdput (disk->part0);if (test_bit (GD_QUEUE_REF , &disk->state) && disk->queue)blk_put_queue (disk->queue); -kfree (disk); +bdput (disk->part0);/* frees the disk */ }struct class block_class = { .name ="block" ,
fs/block_dev.c +2 -0
@@ -812,6 +812,8 @@ static void bdev_free_inode(struct inode *inode)free_percpu (bdev->bd_stats);kfree (bdev->bd_meta_info); +if (!bdev_is_partition (bdev)) +kfree (bdev->bd_disk);kmem_cache_free (bdev_cachep,BDEV_I (inode)); }
Signature · 1 line
2.30.2
PATCH 2/9 block: assert the locking state in delete_partition
In reply to Christoph HellwigAdd a lockdep assert instead of the outdated locking comment.
--- block/partitions/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
block/partitions/core.c +2 -4
@@ -281,12 +281,10 @@ struct device_type part_type = { .uevent = part_uevent, }; -/* -* Must be called either with open_mutex held, before a disk can be opened or -* after all disk users are gone. -*/ static void delete_partition (struct block_device *part) { +lockdep_assert_held (&part->bd_disk->open_mutex); +fsync_bdev (part);__invalidate_device (part, true);
Signature · 1 line
2.30.2
Re: [PATCH 2/9] block: assert the locking state in delete_partition
Quoted 19 lines · Christoph Hellwig
Add a lockdep assert instead of the outdated locking comment.
Signed-off-by Christoph Hellwig <[email protected]>Reviewed-by Josef Bacik <[email protected]>Reviewed-by Ming Lei <[email protected]>--- block/partitions/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)block/partitions/core.c +0
-1@@ -281,12 +281,10 @@ struct device_type part_type = { .uevent = part_uevent, }; -/*
block/partitions/core.c struct device_type part_type = { · line 290
Quoted 10 lines
block/partitions/core.c +2
-3-* Must be called either with open_mutex held, before a disk can be opened or -* after all disk users are gone. -*/ static void delete_partition (struct block_device *part) { +lockdep_assert_held (&part->bd_disk->open_mutex); +fsync_bdev (part);__invalidate_device (part, true);
Signature · 1 line
-ck
PATCH 3/9 block: unhash the whole device inode earlier
In reply to Christoph HellwigUnhash the whole device inode early in del_gendisk. This allows to remove the first GENHD_FL_UP check in the open path as we simply won't find a just removed inode. The second non-racy check after taking open_mutex is still kept.
--- block/genhd.c | 7 +------ fs/block_dev.c | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-)
block/genhd.c +1 -6
@@ -585,6 +585,7 @@ void del_gendisk(struct gendisk *disk)disk_del_events (disk);mutex_lock (&disk->open_mutex); +remove_inode_hash (disk->part0->bd_inode); disk->flags &= ~GENHD_FL_UP ;blk_drop_partitions (disk);mutex_unlock (&disk->open_mutex);
@@ -592,12 +593,6 @@ void del_gendisk(struct gendisk *disk)fsync_bdev (disk->part0);__invalidate_device (disk->part0, true); -/* -* Unhash the bdev inode for this device so that it can't be looked -* up any more even if openers still hold references to it. -*/ -remove_inode_hash (disk->part0->bd_inode); -set_capacity (disk,0 );if (!(disk->flags &GENHD_FL_HIDDEN )) {
fs/block_dev.c +1 -1
@@ -1340,7 +1340,7 @@ struct block_device *blkdev_get_no_open(dev_t dev) disk = bdev->bd_disk;if (!kobject_get_unless_zero (&disk_to_dev (disk)->kobj)) goto bdput; -if ((disk->flags & (GENHD_FL_UP |GENHD_FL_HIDDEN )) !=GENHD_FL_UP ) +if (disk->flags &GENHD_FL_HIDDEN ) goto put_disk;if (!try_module_get (bdev->bd_disk->fops->owner)) goto put_disk;
Signature · 1 line
2.30.2
Re: [PATCH 3/9] block: unhash the whole device inode earlier
Quoted 41 lines · Christoph Hellwig
Unhash the whole device inode early in
del_gendisk. This allows to remove the firstGENHD_FL_UPcheck in the open path as we simply won't find a just removed inode. The second non-racy check after takingopen_mutexis still kept.Signed-off-by Christoph Hellwig <[email protected]>--- block/genhd.c | 7 +------ fs/block_dev.c | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-)block/genhd.c +1
-6@@ -585,6 +585,7 @@ void del_gendisk(struct gendisk *disk)disk_del_events (disk);mutex_lock (&disk->open_mutex); +remove_inode_hash (disk->part0->bd_inode); disk->flags &= ~GENHD_FL_UP ;blk_drop_partitions (disk);mutex_unlock (&disk->open_mutex);@@ -592,12 +593,6 @@ void del_gendisk(struct gendisk *disk)fsync_bdev (disk->part0);__invalidate_device (disk->part0, true); -/* -* Unhash the bdev inode for this device so that it can't be looked -* up any more even if openers still hold references to it. -*/ -remove_inode_hash (disk->part0->bd_inode); -set_capacity (disk,0 );if (!(disk->flags &GENHD_FL_HIDDEN )) {fs/block_dev.c +0
-0
fs/block_dev.c struct block_device *blkdev_get_no_open(dev_t dev) · line 1343
Quoted 5 lines
fs/block_dev.c +1
-1@@ -1340,7 +1340,7 @@ struct block_device *blkdev_get_no_open(dev_t dev) disk = bdev->bd_disk;if (!kobject_get_unless_zero (&disk_to_dev (disk)->kobj)) goto bdput; -if ((disk->flags & (GENHD_FL_UP |GENHD_FL_HIDDEN )) !=GENHD_FL_UP ) +if (disk->flags &GENHD_FL_HIDDEN )
But del_gendisk() can be called just between bdget() and checking GENHD_FL_UP.
And not see difference by moving remove_inode_hash() with disk open_mutex held.
Thanks,
Ming
Re: [PATCH 3/9] block: unhash the whole device inode earlier
Quoted 7 lines · Ming Lei
fs/block_dev.c struct block_device *blkdev_get_no_open(dev_t dev) · line 1343
Quoted 3 lines
fs/block_dev.c +1
-1goto bdput; -if ((disk->flags & (GENHD_FL_UP |GENHD_FL_HIDDEN )) !=GENHD_FL_UP ) +if (disk->flags &GENHD_FL_HIDDEN )But
del_gendisk()can be called just betweenbdget()and checkingGENHD_FL_UP.And not see difference by moving
remove_inode_hash()with diskopen_mutexheld.
The difference is not about having the open_mutex held, but about doing it earlier.
The only check that matters is the GENHD_FL_UP check in blkdev_get_by_dev. The earlier check just reduces the amount of work we're doing for a disk already being delete. With the early unhash there is no need for that check as we won't even find the inode for a disk in del_gendisk. We still need the non-racy check under the lock, but the patch doesn't touch that one.
Maybe I need to split this into two patches and improve the commit log.
PATCH 4/9 block: allocate bd_meta_info later in add_partitions
In reply to Christoph HellwigMove the allocation of bd_meta_info after initializing the struct device to avoid the special bdput error handling path.
--- block/partitions/core.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-)
block/partitions/core.c +7 -10
@@ -356,13 +356,6 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, bdev->bd_start_sect = start;bdev_set_nr_sectors (bdev, len); -if (info) { - err = -ENOMEM ; - bdev->bd_meta_info =kmemdup (info,sizeof (*info),GFP_KERNEL ); -if (!bdev->bd_meta_info) - goto out_bdput; - } - pdev = &bdev->bd_device; dname =dev_name (ddev);if (isdigit (dname[strlen (dname) -1 ]))
@@ -386,6 +379,13 @@ static struct block_device *add_partition(struct gendisk *disk, int partno, } pdev->devt = devt; +if (info) { + err = -ENOMEM ; + bdev->bd_meta_info =kmemdup (info,sizeof (*info),GFP_KERNEL ); +if (!bdev->bd_meta_info) + goto out_put; + } +/* delay uevent until 'holders' subdir is created */ dev_set_uevent_suppress (pdev,1 ); err =device_add (pdev);
@@ -415,9 +415,6 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,kobject_uevent (&pdev->kobj,KOBJ_ADD );return bdev; -out_bdput: -bdput (bdev); -return ERR_PTR (err); out_del:kobject_put (bdev->bd_holder_dir);device_del (pdev);
Signature · 1 line
2.30.2
Re: [PATCH 4/9] block: allocate bd_meta_info later in add_partitions
Quoted 4 lines · Christoph Hellwig
Move the allocation of
bd_meta_infoafter initializing the struct device to avoid the special bdput error handling path.Signed-off-by Christoph Hellwig <[email protected]>
Signature · 1 line
Ming
PATCH 5/9 block: change the refcounting for partitions
In reply to Christoph HellwigInstead of acquiring an inode reference on open make sure partitions always hold device model references to the disk while alive, and switch open to grab only a device model reference to the opened block device. If that is a partition the disk reference is transitively held by the partition already.
--- block/partitions/core.c | 9 ++++++- fs/block_dev.c | 60 ++++++++++++++++------------------------- 2 files changed, 31 insertions(+), 38 deletions(-)
block/partitions/core.c +8 -1
@@ -261,6 +261,7 @@ static void part_release(struct device *dev) {if (MAJOR (dev->devt) ==BLOCK_EXT_MAJOR )blk_free_ext_minor (MINOR (dev->devt)); +put_disk (dev_to_bdev (dev)->bd_disk);bdput (dev_to_bdev (dev)); }
@@ -349,9 +350,13 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,if (xa_load (&disk->part_tbl, partno))return ERR_PTR (-EBUSY ); +/* ensure we always have a reference to the whole disk */ +get_device (disk_to_dev (disk)); + + err = -ENOMEM ; bdev =bdev_alloc (disk, partno);if (!bdev) -return ERR_PTR (-ENOMEM ); + goto out_put_disk; bdev->bd_start_sect = start;bdev_set_nr_sectors (bdev, len);
@@ -420,6 +425,8 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,device_del (pdev); out_put:put_device (pdev); +out_put_disk: +put_disk (disk);return ERR_PTR (err); }
fs/block_dev.c +23 -37
106 lines not on this page · raw message
Signature · 1 line
2.30.2
Re: [PATCH 5/9] block: change the refcounting for partitions
Quoted 38 lines · Christoph Hellwig
Instead of acquiring an inode reference on open make sure partitions always hold device model references to the disk while alive, and switch open to grab only a device model reference to the opened block device. If that is a partition the disk reference is transitively held by the partition already.
--- block/partitions/core.c | 9 ++++++- fs/block_dev.c | 60 ++++++++++++++++------------------------- 2 files changed, 31 insertions(+), 38 deletions(-)block/partitions/core.c +6
-1@@ -261,6 +261,7 @@ static void part_release(struct device *dev) {if (MAJOR (dev->devt) ==BLOCK_EXT_MAJOR )blk_free_ext_minor (MINOR (dev->devt)); +put_disk (dev_to_bdev (dev)->bd_disk);bdput (dev_to_bdev (dev)); }@@ -349,9 +350,13 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,if (xa_load (&disk->part_tbl, partno))return ERR_PTR (-EBUSY ); +/* ensure we always have a reference to the whole disk */ +get_device (disk_to_dev (disk)); + + err = -ENOMEM ; bdev =bdev_alloc (disk, partno);if (!bdev) -return ERR_PTR (-ENOMEM ); + goto out_put_disk; bdev->bd_start_sect = start;bdev_set_nr_sectors (bdev, len);
block/partitions/core.c static struct block_device *add_partition(struct gendisk *disk, int partno, · line 429
Quoted 5 lines
block/partitions/core.c +2
-0@@ -420,6 +425,8 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,device_del (pdev); out_put:put_device (pdev); +out_put_disk: +put_disk (disk);
put_disk() is only needed for failure of bdev_alloc(). Once bdev->bd_device is initialized, the disk reference will be dropped via part_release().
Thanks,
Ming
Re: [PATCH 5/9] block: change the refcounting for partitions
Quoted 8 lines · Ming Lei
block/partitions/core.c static struct block_device *add_partition(struct gendisk *disk, int partno, · line 429
Quoted 5 lines
block/partitions/core.c +2
-0device_del (pdev); out_put:put_device (pdev); +out_put_disk: +put_disk (disk);
put_disk()is only needed for failure ofbdev_alloc(). Oncebdev->bd_deviceis initialized, the disk reference will be dropped viapart_release().
Indeed.
PATCH 6/9 btrfs: store a block_device in struct btrfs_ordered_extent
In reply to Christoph HellwigStore the block device instead of the gendisk in the btrfs_ordered_extent structure intead of acquiring a reference to it later.
--- fs/btrfs/inode.c | 2 +- fs/btrfs/ordered-data.c | 2 -- fs/btrfs/ordered-data.h | 3 +-- fs/btrfs/zoned.c | 12 ++++-------- 4 files changed, 6 insertions(+), 13 deletions(-)
fs/btrfs/inode.c +1 -1
@@ -2992,7 +2992,7 @@ static int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent) goto out; } -if (ordered_extent->disk) +if (ordered_extent->bdev)btrfs_rewrite_logical_zoned (ordered_extent);btrfs_free_io_failure_record (inode, start, end);
fs/btrfs/ordered-data.c +0 -2
@@ -190,8 +190,6 @@ static int __btrfs_add_ordered_extent(struct btrfs_inode *inode, u64 file_offset entry->truncated_len = (u64)-1 ; entry->qgroup_rsv = ret; entry->physical = (u64)-1 ; - entry->disk =NULL ; - entry->partno = (u8)-1 ; ASSERT(type == BTRFS_ORDERED_REGULAR || type == BTRFS_ORDERED_NOCOW ||
fs/btrfs/ordered-data.h +1 -2
@@ -145,8 +145,7 @@ struct btrfs_ordered_extent {* command in a workqueue context */ u64 physical; -struct gendisk *disk; -u8 partno; +struct block_device *bdev; };/*
fs/btrfs/zoned.c +4 -8
@@ -1349,8 +1349,7 @@ void btrfs_record_physical_zoned(struct inode *inode, u64 file_offset,return ; ordered->physical = physical; - ordered->disk = bio->bi_bdev->bd_disk; - ordered->partno = bio->bi_bdev->bd_partno; + ordered->bdev = bio->bi_bdev;btrfs_put_ordered_extent (ordered); }
@@ -1362,18 +1361,16 @@ void btrfs_rewrite_logical_zoned(struct btrfs_ordered_extent *ordered)struct extent_map_tree *em_tree;struct extent_map *em;struct btrfs_ordered_sum *sum; -struct block_device *bdev;u64 orig_logical = ordered->disk_bytenr;u64 *logical =NULL ;int nr, stripe_len;/* Zoned devices should not have partitions. So, we can assume it is 0 */ -ASSERT (ordered->partno ==0 ); - bdev =bdgrab (ordered->disk->part0); -if (WARN_ON (!bdev)) +ASSERT (!bdev_is_partition (ordered->bdev)); +if (WARN_ON (!ordered->bdev))return ; -if (WARN_ON (btrfs_rmap_block (fs_info, orig_logical, bdev, +if (WARN_ON (btrfs_rmap_block (fs_info, orig_logical, ordered->bdev, ordered->physical, &logical, &nr, &stripe_len))) goto out;
@@ -1402,7 +1399,6 @@ void btrfs_rewrite_logical_zoned(struct btrfs_ordered_extent *ordered) out:kfree (logical); -bdput (bdev); } bool btrfs_check_meta_write_pointer(struct btrfs_fs_info *fs_info,
Signature · 1 line
2.30.2
Re: [PATCH 6/9] btrfs: store a block_device in struct btrfs_ordered_extent
Quoted 2 lines · Christoph Hellwig
Store the block device instead of the gendisk in the
btrfs_ordered_extentstructure intead of acquiring a reference to it later.
instead
Quoted 2 lines
Signed-off-by Christoph Hellwig <[email protected]>
I can add the patch to the next pull request so you can rebase your series on top of it and don't need to carry it until the next merge window.
Re: [PATCH 6/9] btrfs: store a block_device in struct btrfs_ordered_extent
Quoted 6 lines · David Sterba
Quoted 2 lines · Christoph Hellwig
Store the block device instead of the gendisk in the
btrfs_ordered_extentstructure intead of acquiring a reference to it later.instead
Quoted 1 line
Quoted 7 lines
Quoted 1 line
Signed-off-by Christoph Hellwig <[email protected]>Reviewed-by David Sterba <[email protected]>I can add the patch to the next pull request so you can rebase your series on top of it and don't need to carry it until the next merge window.
Assuming Jens is fine with starting the block tree on -rc3 that would be great.
PATCH 7/9 loop: don't grab a reference to the block device
In reply to Christoph HellwigThe whole device block device won't be removed while the disk is still alive, so don't bother to grab a reference to it.
--- drivers/block/loop.c | 5 ----- 1 file changed, 5 deletions(-)
drivers/block/loop.c +0 -5
@@ -1249,10 +1249,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,if (partscan) lo->lo_disk->flags &= ~GENHD_FL_NO_PART_SCAN ; -/* Grab the block_device to prevent its destruction after we -* put /dev/loopXX inode. Later in __loop_clr_fd() we bdput(bdev). -*/ -bdgrab (bdev);mutex_unlock (&lo->lo_mutex);if (partscan)loop_reread_partitions (lo);
@@ -1332,7 +1328,6 @@ static int __loop_clr_fd(struct loop_device *lo, bool release)blk_queue_physical_block_size (lo->lo_queue,512 );blk_queue_io_min (lo->lo_queue,512 );if (bdev) { -bdput (bdev);invalidate_bdev (bdev); bdev->bd_inode->i_mapping->wb_err =0 ; }
Signature · 1 line
2.30.2
Re: [PATCH 7/9] loop: don't grab a reference to the block device
Quoted 5 lines · Christoph Hellwig
The whole device block device won't be removed while the disk is still alive, so don't bother to grab a reference to it.
Signed-off-by Christoph Hellwig <[email protected]>Reviewed-by Josef Bacik <[email protected]>
Signature · 1 line
Ming
Re: [PATCH 7/9] loop: don't grab a reference to the block device
In reply to Christoph HellwigQuoted 5 lines · Christoph Hellwig
The whole device block device won't be removed while the disk is still alive, so don't bother to grab a reference to it.
Signed-off-by Christoph Hellwig<[email protected]>Reviewed-by Josef Bacik<[email protected]>
Signature · 1 line
-ck
PATCH 8/9 block: remove bdgrab
In reply to Christoph HellwigAll callers are gone, and no one should grab a pure inode reference to a block device anymore.
--- fs/block_dev.c | 15 --------------- include/linux/blkdev.h | 1 - 2 files changed, 16 deletions(-)
fs/block_dev.c +0 -15
@@ -921,21 +921,6 @@ void bdev_add(struct block_device *bdev, dev_t dev)insert_inode_hash (bdev->bd_inode); } -/** -* bdgrab -- Grab a reference to an already referenced block device -* @bdev: Block device to grab a reference to. -* -* Returns the block_device with an additional reference when successful, -* or NULL if the inode is already beeing freed. -*/ -struct block_device *bdgrab (struct block_device *bdev) -{ -if (!igrab (bdev->bd_inode)) -return NULL ; -return bdev; -} -EXPORT_SYMBOL (bdgrab); -long nr_blockdev_pages (void ) {struct inode *inode;
include/linux/blkdev.h +0 -1
@@ -1984,7 +1984,6 @@ void blkdev_put_no_open(struct block_device *bdev);struct block_device *bdev_alloc (struct gendisk *disk,u8 partno);void bdev_add (struct block_device *bdev,dev_t dev);struct block_device *I_BDEV (struct inode *inode); -struct block_device *bdgrab (struct block_device *bdev);void bdput (struct block_device *);int truncate_bdev_range (struct block_device *bdev,fmode_t mode,loff_t lstart,loff_t lend);
Signature · 1 line
2.30.2
PATCH 9/9 block: remove bdput
In reply to Christoph HellwigNow that we've stopped using inode references for anything meaninful in the block layer get rid of the helper to put it and just open code the call to iput on the block_device inode.
--- block/genhd.c | 4 ++-- block/partitions/core.c | 2 +- fs/block_dev.c | 6 ------ include/linux/blkdev.h | 1 - 4 files changed, 3 insertions(+), 10 deletions(-)
block/genhd.c +2 -2
@@ -1076,7 +1076,7 @@ static void disk_release(struct device *dev)xa_destroy (&disk->part_tbl);if (test_bit (GD_QUEUE_REF , &disk->state) && disk->queue)blk_put_queue (disk->queue); -bdput (disk->part0);/* frees the disk */ +iput (disk->part0->bd_inode);/* frees the disk */ }struct class block_class = { .name ="block" ,
@@ -1261,7 +1261,7 @@ struct gendisk *__alloc_disk_node(int minors, int node_id) out_destroy_part_tbl:xa_destroy (&disk->part_tbl); -bdput (disk->part0); +iput (disk->part0->bd_inode); out_free_disk:kfree (disk);return NULL ;
block/partitions/core.c +1 -1
@@ -262,7 +262,7 @@ static void part_release(struct device *dev)if (MAJOR (dev->devt) ==BLOCK_EXT_MAJOR )blk_free_ext_minor (MINOR (dev->devt));put_disk (dev_to_bdev (dev)->bd_disk); -bdput (dev_to_bdev (dev)); +iput (dev_to_bdev (dev)->bd_inode); }static int part_uevent (struct device *dev,struct kobj_uevent_env *env)
fs/block_dev.c +0 -6
@@ -934,12 +934,6 @@ long nr_blockdev_pages(void)return ret; } -void bdput (struct block_device *bdev) -{ -iput (bdev->bd_inode); -} -EXPORT_SYMBOL (bdput); -/** * bd_may_claim - test whether a block device can be claimed * @bdev: block device of interest
include/linux/blkdev.h +0 -1
@@ -1984,7 +1984,6 @@ void blkdev_put_no_open(struct block_device *bdev);struct block_device *bdev_alloc (struct gendisk *disk,u8 partno);void bdev_add (struct block_device *bdev,dev_t dev);struct block_device *I_BDEV (struct inode *inode); -void bdput (struct block_device *);int truncate_bdev_range (struct block_device *bdev,fmode_t mode,loff_t lstart,loff_t lend);
Signature · 1 line
2.30.2
Re: [PATCH 9/9] block: remove bdput
Quoted 6 lines · Christoph Hellwig
Now that we've stopped using inode references for anything meaninful in the block layer get rid of the helper to put it and just open code the call to iput on the
block_deviceinode.Signed-off-by Christoph Hellwig<[email protected]>Reviewed-by Josef Bacik<[email protected]>
Signature · 1 line
-ck
Jens Axboe
maintainerQuoted 5 lines · Christoph Hellwig
Hi Jens,
this series fixes up a possible race with the
block_devicelookup changes, and the finishes off the conversion to stop using the inode refcount for block devices.
Dropped the btrfs patch since it's in -git, and applied #1 to block-5.14, rest for 5.15.
Signature · 1 line
Jens Axboe