driver core: platform: Annotate struct irq_affinity_devres with __counted_by
PATCH 1/1 driver core: platform: Annotate struct irq_affinity_devres with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions).
As found with Coccinelle[1], add __counted_by for struct irq_affinity_devres.
--- drivers/base/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/platform.c +1 -1
@@ -291,7 +291,7 @@ EXPORT_SYMBOL_GPL(platform_irq_count);struct irq_affinity_devres {unsigned int count; -unsigned int irq[]; + unsigned int irq[] __counted_by(count); };static void platform_disable_acpi_irq (struct platform_device *pdev,int index)
Signature · 1 line
2.34.1
Quoted 9 lines · Kees Cook
Prepare for the coming implementation by GCC and Clang of the
__counted_byattribute. Flexible array members annotated with__counted_bycan have their accesses bounds-checked at run-time viaCONFIG_UBSAN_BOUNDS(for array indexing) andCONFIG_FORTIFY_SOURCE(for strcpy/memcpy-family functions).As found with Coccinelle[1], add
__counted_byfor structirq_affinity_devres.
Quoted 6 lines
Cc Greg Kroah-Hartman <[email protected]>Cc "Rafael J. Wysocki" <[email protected]>Cc "Gustavo A. R. Silva" <[email protected]>Signed-off-by Kees Cook <[email protected]>
Thanks!
Signature · 1 line
Gustavo
Quoted 17 lines
--- drivers/base/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/base/platform.c +1
-1@@ -291,7 +291,7 @@ EXPORT_SYMBOL_GPL(platform_irq_count);struct irq_affinity_devres {unsigned int count; -unsigned int irq[]; + unsigned int irq[] __counted_by(count); };static void platform_disable_acpi_irq (struct platform_device *pdev,int index)