Skip to contentSkip to conversation

usleep: fix compile errors

PATCH In review [email protected] 2 participants 3 messages Jun 6, 2024 – Jun 7, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usleep: fix compile errors

From: Kai Kang <[email protected]>

Update usleep.c to fix following compile error:

| usleep.c: In function 'main':
| usleep.c:47:43: error: passing argument 3 of 'poptGetContext' from incompatible pointer type [-Wincompatible-pointer-types]
|    47 |   optCon = poptGetContext("usleep", argc, argv, options,0);
|       |                                           ^~~~
|       |                                           |
|       |                                           char **
| In file included from usleep.c:29:
| /path_to/tmp-glibc/work/core2-64-wrs-linux/usleep/1.2/recipe-sysroot/usr/include/popt.h:217:41: note: expected 'const char **' but argument is of type 'char **'
|   217 |                 int argc, const char ** argv,
|       |                           ~~~~~~~~~~~~~~^~~~
| usleep.c:68:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
|    68 |   countStr = poptGetArg(optCon);
|       |            ^
---
 meta-oe/recipes-core/usleep/files/usleep.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/usleep/files/usleep.c +2 -2
index a5e7d9d715..dfa52ec19a 100644
@@ -34,7 +34,7 @@ int main(int argc, char **argv) {
   int showVersion = 0;
   int showOot = 0;
   int rc;
-  char * countStr = NULL;
+  const char * countStr = NULL;
   struct poptOption options[] = {
             { "version", 'v', POPT_ARG_NONE, &showVersion, 0, 
 			"Display the version of this program, and exit" },
@@ -44,7 +44,7 @@ int main(int argc, char **argv) {
             { 0, 0, 0, 0, 0 }
         };
 
-  optCon = poptGetContext("usleep", argc, argv, options,0);
+  optCon = poptGetContext("usleep", argc, (const char **)argv, options,0);
   /*poptReadDefaultConfig(optCon, 1);*/
   poptSetOtherOptionHelp(optCon, "[microseconds]");
 
Signature · 1 line
2.42.0
#1 lore raw
Quoted 5 lines · Kai Kang via lists.openembedded.org

From: Kai Kang <[email protected]>

Update usleep.c to fix following compile error:

Quoted 14 lines
| usleep.c: In function 'main':
| usleep.c:47:43: error: passing argument 3 of 'poptGetContext' from incompatible pointer type [-Wincompatible-pointer-types]
|    47 |   optCon = poptGetContext("usleep", argc, argv, options,0);
|       |                                           ^~~~
|       |                                           |
|       |                                           char **
| In file included from usleep.c:29:
| /path_to/tmp-glibc/work/core2-64-wrs-linux/usleep/1.2/recipe-sysroot/usr/include/popt.h:217:41: note: expected 'const char **' but argument is of type 'char **'
|   217 |                 int argc, const char ** argv,
|       |                           ~~~~~~~~~~~~~~^~~~
| usleep.c:68:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
|    68 |   countStr = poptGetArg(optCon);
|       |            ^

What is the upstream status of this patch ?

Quoted 39 lines
---
 meta-oe/recipes-core/usleep/files/usleep.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/usleep/files/usleep.c +2 -3
index a5e7d9d715..dfa52ec19a 100644
@@ -34,7 +34,7 @@ int main(int argc, char **argv) {
   int showVersion = 0;
   int showOot = 0;
   int rc;
-  char * countStr = NULL;
+  const char * countStr = NULL;
   struct poptOption options[] = {
             { "version", 'v', POPT_ARG_NONE, &showVersion, 0,
                        "Display the version of this program, and exit" },
@@ -44,7 +44,7 @@ int main(int argc, char **argv) {
             { 0, 0, 0, 0, 0 }
         };
 
-  optCon = poptGetContext("usleep", argc, argv, options,0);
+  optCon = poptGetContext("usleep", argc, (const char **)argv, options,0);
   /*poptReadDefaultConfig(optCon, 1);*/
   poptSetOtherOptionHelp(optCon, "[microseconds]");
 
--

2.42.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#110707): https://lists.openembedded.org/g/openembedded-devel/message/110707
Mute This Topic: https://lists.openembedded.org/mt/106517953/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

author
#2 lore raw
Quoted 20 lines · Khem Raj
Quoted 4 lines · Kai Kang via lists.openembedded.org

From: Kai Kang<[email protected]>

Update usleep.c to fix following compile error:

Quoted 14 lines
| usleep.c: In function 'main':
| usleep.c:47:43: error: passing argument 3 of 'poptGetContext' from incompatible pointer type [-Wincompatible-pointer-types]
|    47 |   optCon = poptGetContext("usleep", argc, argv, options,0);
|       |                                           ^~~~
|       |                                           |
|       |                                           char **
| In file included from usleep.c:29:
| /path_to/tmp-glibc/work/core2-64-wrs-linux/usleep/1.2/recipe-sysroot/usr/include/popt.h:217:41: note: expected 'const char **' but argument is of type 'char **'
|   217 |                 int argc, const char ** argv,
|       |                           ~~~~~~~~~~~~~~^~~~
| usleep.c:68:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
|    68 |   countStr = poptGetArg(optCon);
|       |            ^
Quoted 1 line

What is the upstream status of this patch ?

It just modify the source code usleep.c which residents in meta-oe

and not a separated patch, so not require upstream status.

Regards,
Kai

Quoted 40 lines
Quoted 40 lines
---
  meta-oe/recipes-core/usleep/files/usleep.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
meta-oe/recipes-core/usleep/files/usleep.c +2 -3
index a5e7d9d715..dfa52ec19a 100644
@@ -34,7 +34,7 @@ int main(int argc, char **argv) {
    int showVersion = 0;
    int showOot = 0;
    int rc;
-  char * countStr = NULL;
+  const char * countStr = NULL;
    struct poptOption options[] = {
              { "version", 'v', POPT_ARG_NONE, &showVersion, 0,
                         "Display the version of this program, and exit" },
@@ -44,7 +44,7 @@ int main(int argc, char **argv) {
              { 0, 0, 0, 0, 0 }
          };
 
-  optCon = poptGetContext("usleep", argc, argv, options,0);
+  optCon = poptGetContext("usleep", argc, (const char **)argv, options,0);
    /*poptReadDefaultConfig(optCon, 1);*/
    poptSetOtherOptionHelp(optCon, "[microseconds]");
 
--

2.42.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#110707):https://lists.openembedded.org/g/openembedded-devel/message/110707 Mute This Topic:https://lists.openembedded.org/mt/106517953/1997914
Group Owner:[email protected] Unsubscribe:https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Signature · 2 lines
Kai Kang
Wind River Linux