xen/pciback: Fix incorrect type warnings
Subsystems (2)
PATCH 1/1 xen/pciback: Fix incorrect type warnings
Correct enum pci_channel_io_normal should be used instead of putting integer value 1.
Fix following smatch warnings:drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:805:40: expected restricted pci_channel_state_t [usertype] statedrivers/xen/xen-pciback/pci_stub.c:805:40: got intdrivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:862:40: expected restricted pci_channel_state_t [usertype] statedrivers/xen/xen-pciback/pci_stub.c:862:40: got intdrivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:973:31: expected restricted pci_channel_state_t [usertype] statedrivers/xen/xen-pciback/pci_stub.c:973:31: got int
--- drivers/xen/xen-pciback/pci_stub.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/xen/xen-pciback/pci_stub.c +3 -3
@@ -802,7 +802,7 @@ static pci_ers_result_t xen_pcibk_slot_reset(struct pci_dev *dev) "guest with no AER driver should have been killed\n"); goto end; } - result =common_process (psdev,1 , XEN_PCI_OP_aer_slotreset, result); + result =common_process (psdev, pci_channel_io_normal, XEN_PCI_OP_aer_slotreset, result);if (result ==PCI_ERS_RESULT_NONE || result ==PCI_ERS_RESULT_DISCONNECT ) {
@@ -859,7 +859,7 @@ static pci_ers_result_t xen_pcibk_mmio_enabled(struct pci_dev *dev) "guest with no AER driver should have been killed\n"); goto end; } - result =common_process (psdev,1 , XEN_PCI_OP_aer_mmio, result); + result =common_process (psdev, pci_channel_io_normal, XEN_PCI_OP_aer_mmio, result);if (result ==PCI_ERS_RESULT_NONE || result ==PCI_ERS_RESULT_DISCONNECT ) {
@@ -970,7 +970,7 @@ static void xen_pcibk_error_resume(struct pci_dev *dev)kill_domain_by_device (psdev); goto end; } -common_process (psdev,1 , XEN_PCI_OP_aer_resume, +common_process (psdev, pci_channel_io_normal, XEN_PCI_OP_aer_resume,PCI_ERS_RESULT_RECOVERED ); end:if (psdev)
Signature · 1 line
2.25.1
Quoted 14 lines · Muhammad Usama Anjum
Correct enum
pci_channel_io_normalshould be used instead of putting integer value 1.Fix following smatch warnings:
drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:805:40: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:805:40: got intdrivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:862:40: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:862:40: got intdrivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:973:31: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:973:31: got int
Quoted 1 line
Signed-off-by Muhammad Usama Anjum <[email protected]>
Juergen
Reminder!
Quoted 21 lines · Juergen Gross
Quoted 14 lines · Muhammad Usama Anjum
Correct enum
pci_channel_io_normalshould be used instead of putting integer value 1.Fix following smatch warnings:
drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:805:40: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:805:40: got intdrivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:862:40: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:862:40: got intdrivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:973:31: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:973:31: got intQuoted 1 line
Signed-off-by Muhammad Usama Anjum <[email protected]>Reviewed-by Juergen Gross <[email protected]>Juergen
Quoted 14 lines · Muhammad Usama Anjum
Correct enum
pci_channel_io_normalshould be used instead of putting integer value 1.Fix following smatch warnings:
drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:805:40: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:805:40: got intdrivers/xen/xen-pciback/pci_stub.c:862:40: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:862:40: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:862:40: got intdrivers/xen/xen-pciback/pci_stub.c:973:31: warning: incorrect type in argument 2 (different base types)drivers/xen/xen-pciback/pci_stub.c:973:31: expected restrictedpci_channel_state_t[usertype] statedrivers/xen/xen-pciback/pci_stub.c:973:31: got int
Quoted 1 line
Signed-off-by Muhammad Usama Anjum <[email protected]>
Pushed to xen/tip.git for-linus-5.13
Juergen