Skip to contentSkip to conversation

linux-next: build failure after merge of the drm-misc tree

DISCUSSION Mark Brown 3 participants 9 messages Sep 1 – Sep 8 Linux-next tree

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/sound/soc/ti/omap-hdmi.c:408:6: error: no member named 'card' in 'struct hdmi_audio_data'

  408 |         ad->card = card;
      |         ~~  ^

Caused by commit

699e5975e2a53 (drm/omap: Report HDMI hotplug events to the ASoC HDMI codec)

I have used the tree from next-20260831 instead.

#1 lore raw
Quoted 6 lines · Mark Brown

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/sound/soc/ti/omap-hdmi.c:408:6: error: no member named 'card' in 'struct hdmi_audio_data'

Quoted 8 lines
   408 |         ad->card = card;
       |         ~~  ^

Caused by commit

699e5975e2a53 (drm/omap: Report HDMI hotplug events to the ASoC HDMI codec)

I have used the tree from next-20260831 instead.

This seems to be due to an interaction between two patches:
1. 9af2c1d4f847 (ASoC: ti: omap-hdmi: remove unused *card) / 875e906efdc4 (ASoC: ti: preparation for Card capsuling)
2. 699e5975e2a53 (drm/omap: Report HDMI hotplug events to the ASoC HDMI codec)

Both (1) patches are in the tree and remove the 'card' member from struct hdmi_audio_data, while (2) was already in transit. Patch (2) only reorders the existing ad->card = card assignment, so it still contains that reference:

+ ad->card = card;
+
+ snd_soc_card_set_drvdata(card, ad);
ret = devm_snd_soc_register_card(dev, card);
if (ret) {
dev_err(dev, "snd_soc_register_card failed (%d)\n", ret); return ret;
}

- ad->card = card;
- snd_soc_card_set_drvdata(card, ad);
-
dev_set_drvdata(dev, ad);

author maintainer
#2 lore raw
Quoted 9 lines · Ivaylo Dimitrov
Quoted 3 lines · Mark Brown

/tmp/next/build/sound/soc/ti/omap-hdmi.c:408:6: error: no member named 'card' in 'struct hdmi_audio_data'

   408 |         ad->card = card;
       |         ~~  ^

This seems to be due to an interaction between two patches:
1. 9af2c1d4f847 (ASoC: ti: omap-hdmi: remove unused *card) / 875e906efdc4 (ASoC: ti: preparation for Card capsuling)

Those are in -rc1...

Quoted 2 lines

2. 699e5975e2a53 (drm/omap: Report HDMI hotplug events to the ASoC HDMI codec)

...which the drm-misc tree has now merged so I don't expect it to build independently of any other tree. I'm a bit surprised this wasn't caught when merging up -rc1.

#3 lore raw

Hi,

Quoted 11 lines · Mark Brown
Quoted 9 lines · Ivaylo Dimitrov
Quoted 3 lines · Mark Brown

/tmp/next/build/sound/soc/ti/omap-hdmi.c:408:6: error: no member named 'card' in 'struct hdmi_audio_data'

    408 |         ad->card = card;
        |         ~~  ^

This seems to be due to an interaction between two patches:
1. 9af2c1d4f847 (ASoC: ti: omap-hdmi: remove unused *card) / 875e906efdc4 (ASoC: ti: preparation for Card capsuling)

Quoted 8 lines

Those are in -rc1...

Quoted 2 lines

2. 699e5975e2a53 (drm/omap: Report HDMI hotplug events to the ASoC HDMI codec)

...which the drm-misc tree has now merged so I don't expect it to build independently of any other tree. I'm a bit surprised this wasn't caught when merging up -rc1.

So the fix is just to remove that line. Any preference, should this go via drm or sound?

Tomi

author maintainer
#4 lore raw
Quoted 11 lines · Tomi Valkeinen
Quoted 6 lines · Mark Brown
Quoted 2 lines

2. 699e5975e2a53 (drm/omap: Report HDMI hotplug events to the ASoC HDMI codec)

...which the drm-misc tree has now merged so I don't expect it to build independently of any other tree. I'm a bit surprised this wasn't caught when merging up -rc1.

So the fix is just to remove that line. Any preference, should this go via drm or sound?

Given that the breakage is in drm-misc it needs to be fixed in drm-misc, hopefully before it starts getting cross merged everywhere.

author maintainer
#5 lore raw
In reply to Mark Brown
Quoted 8 lines · Mark Brown

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/sound/soc/ti/omap-hdmi.c:408:6: error: no member named 'card' in 'struct hdmi_audio_data'

  408 |         ad->card = card;
      |         ~~  ^

This issue is still present today.

#6 lore raw

Hi,

Quoted 11 lines · Mark Brown
Quoted 8 lines · Mark Brown

Hi all,

After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) failed like this:

/tmp/next/build/sound/soc/ti/omap-hdmi.c:408:6: error: no member named 'card' in 'struct hdmi_audio_data'

   408 |         ad->card = card;
       |         ~~  ^

This issue is still present today.

I have sent "[PATCH] ASoC: ti: omap-hdmi: Fix build error from a merge commit" ([email protected]). Waiting for a R-b so I can push it via drm-misc.

Tomi

author maintainer
#7 lore raw
Quoted 7 lines · Tomi Valkeinen
Quoted 1 line · Mark Brown

This issue is still present today.

I have sent "[PATCH] ASoC: ti: omap-hdmi: Fix build error from a merge commit" ([email protected]). Waiting for a R-b so I can push it via drm-misc.

I saw that, it is probably worth looking into what's going on with the process here if what should be a relatively simple build failure fix is taking this long to get integrated.

#8 lore raw

Hi,

Quoted 5 lines · Mark Brown
Quoted 3 lines · Tomi Valkeinen
Quoted 1 line · Mark Brown

This issue is still present today.

Quoted 7 lines
Quoted 3 lines

I have sent "[PATCH] ASoC: ti: omap-hdmi: Fix build error from a merge commit" ([email protected]). Waiting for a R-b so I can push it via drm-misc.

I saw that, it is probably worth looking into what's going on with the process here if what should be a relatively simple build failure fix is taking this long to get integrated.

I have pushed 836a0bb73c17 to drm-misc-next.

Tomi