Skip to contentSkip to conversation

tester: Fix test timeout data

PATCH Applied Inga Stotland 2 participants 2 messages Apr 10, 2021 – Apr 12, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tester: Fix test timeout data

When advancing to a next test case, create test timeout with the tester instance as user data.

Also, remove stray debug printfs.

---
 ell/tester.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)
ell/tester.c +1 -8
index eedd66b..54fbb4b 100644
@@ -131,18 +131,11 @@ static void teardown_callback(void *user_data)
 	struct l_tester *tester = user_data;
 	struct test_case *test;
 
-	printf("teardown %p\n", tester->test_entry);
-
 	test = tester->test_entry->data;
-	printf("teardown data %p\n", tester->test_entry->data);
 	test->stage = L_TESTER_STAGE_TEARDOWN;
 	test->teardown = false;
 
-	printf("Test name %p\n", test->name);
-	printf("Test name %s\n", test->name);
 	print_progress(test->name, COLOR_MAGENTA, "teardown");
-	printf("teardown\n");
-
 
 	if (test->teardown_func)
 		test->teardown_func(test->test_data);
@@ -189,7 +182,7 @@ static void next_test_case(struct l_tester *tester)
 
 	if (test->timeout > 0)
 		test->run_timer = l_timeout_create(test->timeout, test_timeout,
-								test, NULL);
+								tester, NULL);
 
 	test->stage = L_TESTER_STAGE_PRE_SETUP;
 
Signature · 1 line
2.26.3
#1 lore raw

Hi Inga,

Quoted 8 lines · Inga Stotland

When advancing to a next test case, create test timeout with the tester instance as user data.

Also, remove stray debug printfs.

---
  ell/tester.c | 9 +--------
  1 file changed, 1 insertion(+), 8 deletions(-)

Applied, thanks.

Regards,
-Denis