e1000e: Additional PHY power saving in s0ix
Subsystems (2)
PATCH 3/3 e1000e: Additional PHY power saving in s0ix
After transferring the MAC-PHY interface to the SMBus the PHY will save power in S0ix low power idle mode.
--- drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/ethernet/intel/e1000e/netdev.c +6 -0
@@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter)ew32 (CTRL_EXT , mac_data);/* DFT control: PHY bit: page769_20[0] = 1 +* page769_20[7] - PHY PLL stop +* page769_20[8] - PHY go to the electrical idle +* page769_20[9] - PHY serdes disable * Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1 */ e1e_rphy (hw,I82579_DFT_CTRL , &phy_data); phy_data |=BIT (0 ); + phy_data |=BIT (7 ); + phy_data |=BIT (8 ); + phy_data |=BIT (9 );e1e_wphy (hw,I82579_DFT_CTRL , phy_data); mac_data =er32 (EXTCNF_CTRL );
Signature · 1 line
2.25.1
Fuxbrumer
PATCH 3/3 e1000e: Additional PHY power saving in s0ix
Quoted 9 lines · Sasha Neftin
After transferring the MAC-PHY interface to the SMBus the PHY will save power in S0ix low power idle mode.
Suggested-by Dima Ruinskiy <[email protected]>Signed-off-by Sasha Neftin <[email protected]>--- drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++ 1 file changed, 6 insertions(+)
PATCH 3/3 e1000e: Additional PHY power saving in s0ix
In reply to Sasha NeftinDear Sasha, dear Dima,
Am 24.06.21 um 10:19 schrieb Sasha Neftin:
Could you please use a statement in the commit message summary? Maybe:
Quoted 4 lines
Disable additional PHY features(?) in S0ix
After transferring the MAC-PHY interface to the SMBus the PHY will save power in S0ix low power idle mode.
I do not understand this. Please rewrite, and mention the three PHY features(?) you change.
Please document how you tested this, and exactly how much power is saved.
Quoted 18 lines
Suggested-by Dima Ruinskiy <[email protected]>Signed-off-by Sasha Neftin <[email protected]>--- drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/net/ethernet/intel/e1000e/netdev.c +3
-0@@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter)ew32 (CTRL_EXT , mac_data);/* DFT control: PHY bit: page769_20[0] = 1 +* page769_20[7] - PHY PLL stop +* page769_20[8] - PHY go to the electrical idle +* page769_20[9] - PHY serdes disable
drivers/net/ethernet/intel/e1000e/netdev.c static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter) · line 6395
Quoted 10 lines
drivers/net/ethernet/intel/e1000e/netdev.c +3
-0* Gate PPW via EXTCNF_CTRL - set 0x0F00[7] = 1 */ e1e_rphy (hw,I82579_DFT_CTRL , &phy_data); phy_data |=BIT (0 ); + phy_data |=BIT (7 ); + phy_data |=BIT (8 ); + phy_data |=BIT (9 );e1e_wphy (hw,I82579_DFT_CTRL , phy_data); mac_data =er32 (EXTCNF_CTRL );
Kind regards,
Paul
PATCH 3/3 e1000e: Additional PHY power saving in s0ix
Quoted 9 lines · Paul Menzel
Dear Sasha, dear Dima,
Am 24.06.21 um 10:19 schrieb Sasha Neftin:
Could you please use a statement in the commit message summary? Maybe:
Quoted 1 line
Disable additional PHY features(?) in S0ix
Quoted 7 lines
Quoted 2 lines
After transferring the MAC-PHY interface to the SMBus the PHY will save power in S0ix low power idle mode.
I do not understand this. Please rewrite, and mention the three PHY features(?) you change.
Please document how you tested this, and exactly how much power is saved.
Dear Paul,
The PHY will save 47-85mW in s0ix. It is tested (by our electrical validation team) on a sense resistor on a specific external board over the TGL platform.
This measurement could variate from platform to platform and depends on the specific platform design.
Quoted 33 lines
Quoted 23 lines
Suggested-by Dima Ruinskiy <[email protected]>Signed-off-by Sasha Neftin <[email protected]>---
?drivers/net/ethernet/intel/e1000e/netdev.c| 6 ++++++ ? 1 file changed, 6 insertions(+)drivers/net/ethernet/intel/e1000e/netdev.c +0
-0@@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter) ????????? ew32(CTRL_EXT, mac_data);? ????????? /* DFT control: PHY bit: page769_20[0] = 1 +???????? * page769_20[7] - PHY PLL stop +???????? * page769_20[8] - PHY go to the electrical idle +???????? * page769_20[9] - PHY serdes disable ?????????? * Gate PPW via
EXTCNF_CTRL- set 0x0F00[7] = 1 ?????????? */
?????????e1e_rphy(hw, I82579_DFT_CTRL, &phy_data); ?????????phy_data|= BIT(0);Quoted 6 lines
+??????? phy_data |= BIT(7); +??????? phy_data |= BIT(8); +??????? phy_data |= BIT(9);?????????
e1e_wphy(hw, I82579_DFT_CTRL, phy_data); ? ?????????mac_data=er32(EXTCNF_CTRL);Kind regards,
Quoted 1 line
Paul
Thanks,
Sasha
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210713/4f209781/attachment-0001.html>
PATCH 3/3 e1000e: Additional PHY power saving in s0ix
Dear Sasha,
Am 13.07.21 um 18:40 schrieb Sasha Neftin:
Quoted 14 lines · Paul Menzel
Quoted 13 lines
Am 24.06.21 um 10:19 schrieb Sasha Neftin:
Could you please use a statement in the commit message summary? Maybe:
Quoted 4 lines
Disable additional PHY features(?) in S0ix
After transferring the MAC-PHY interface to the SMBus the PHY will save power in S0ix low power idle mode.
I do not understand this. Please rewrite, and mention the three PHY features(?) you change.
Quoted 8 lines
Quoted 1 line
Please document how you tested this, and exactly how much power is saved.
The PHY will save 47-85mW in s0ix. It is tested (by our electrical validation team) on a sense resistor on a specific external board over the TGL platform.
This measurement could variate from platform to platform and depends on the specific platform design.
Thank you for sharing the data. Please add it to the commit message in v2.
Quoted 20 lines
Quoted 20 lines
Quoted 20 lines
Suggested-by Dima Ruinskiy <[email protected]>Signed-off-by Sasha Neftin <[email protected]>---
?drivers/net/ethernet/intel/e1000e/netdev.c| 6 ++++++ ? 1 file changed, 6 insertions(+)drivers/net/ethernet/intel/e1000e/netdev.c +0
-0@@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter) ????????? ew32(CTRL_EXT, mac_data);? ????????? /* DFT control: PHY bit: page769_20[0] = 1 +???????? * page769_20[7] - PHY PLL stop +???????? * page769_20[8] - PHY go to the electrical idle +???????? * page769_20[9] - PHY serdes disable ?????????? * Gate PPW via
EXTCNF_CTRL- set 0x0F00[7] = 1 ?????????? */
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
?????????
e1e_rphy(hw, I82579_DFT_CTRL, &phy_data); ?????????phy_data|= BIT(0);+??????? phy_data |= BIT(7); +??????? phy_data |= BIT(8); +??????? phy_data |= BIT(9);?????????
e1e_wphy(hw, I82579_DFT_CTRL, phy_data); ? ?????????mac_data=er32(EXTCNF_CTRL);
Kind regards,
Paul
PATCH 3/3 e1000e: Additional PHY power saving in s0ix
Quoted 21 lines · Paul Menzel
Dear Sasha,
Am 13.07.21 um 18:40 schrieb Sasha Neftin:
Quoted 16 lines · Paul Menzel
Quoted 15 lines
Am 24.06.21 um 10:19 schrieb Sasha Neftin:
Could you please use a statement in the commit message summary? Maybe:
Quoted 4 lines
Disable additional PHY features(?) in S0ix
After transferring the MAC-PHY interface to the SMBus the PHY will save power in S0ix low power idle mode.
I do not understand this. Please rewrite, and mention the three PHY features(?) you change.
Please document how you tested this, and exactly how much power is saved.
Quoted 8 lines
Quoted 6 lines
The PHY will save 47-85mW in s0ix. It is tested (by our electrical validation team) on a sense resistor on a specific external board over the TGL platform.
This measurement could variate from platform to platform and depends on the specific platform design.
Thank you for sharing the data. Please add it to the commit message in v2.
Paul, I will work on this with our HW architect. We will process specification updates. I will let you know and share since it will ready.
Quoted 33 lines
Quoted 21 lines
Quoted 21 lines
Quoted 21 lines
Suggested-by Dima Ruinskiy <[email protected]>Signed-off-by Sasha Neftin <[email protected]>---
?drivers/net/ethernet/intel/e1000e/netdev.c| 6 ++++++ ? 1 file changed, 6 insertions(+)drivers/net/ethernet/intel/e1000e/netdev.c +0
-0@@ -6380,10 +6380,16 @@ static void e1000e_s0ix_entry_flow(struct e1000_adapter *adapter) ????????? ew32(CTRL_EXT, mac_data);? ????????? /* DFT control: PHY bit: page769_20[0] = 1 +???????? * page769_20[7] - PHY PLL stop +???????? * page769_20[8] - PHY go to the electrical idle +???????? * page769_20[9] - PHY serdes disable ?????????? * Gate PPW via
EXTCNF_CTRL- set 0x0F00[7] = 1 ?????????? */Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
?????????
e1e_rphy(hw, I82579_DFT_CTRL, &phy_data); ?????????phy_data|= BIT(0);+??????? phy_data |= BIT(7); +??????? phy_data |= BIT(8); +??????? phy_data |= BIT(9);?????????
e1e_wphy(hw, I82579_DFT_CTRL, phy_data); ? ?????????mac_data=er32(EXTCNF_CTRL);Kind regards,
Quoted 1 line
Paul
Sasha