Skip to contentSkip to conversation

boot/syslinux: fix build with GCC 14.x

PATCH In review lancethepants 2 participants 4 messages Jun 5, 2024 – Jun 20, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 boot/syslinux: fix build with GCC 14.x

Add missing stdio.h include. Without it results in the following error under GCC 14.x

../../../com32/lib/syslinux/debug.c: In function ‘syslinux_debug’:
../../../com32/lib/syslinux/debug.c:91:5: error: implicit declaration of function ‘printf’ [-Wimplicit-function-declaration]
91 | printf("Dynamic debug unavailable\n");

---
 .../0020-pull-in-stdio-h-for-gcc14.patch      | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +25 -0
new file mode 100644
index 0000000000..6711c7aa78
@@ -0,0 +1,25 @@
+From dfa2705100a893bc017d23406daa9a383fbc3c95 Mon Sep 17 00:00:00 2001
+From: lancethepants <[email protected]>
+Date: Wed, 5 Jun 2024 14:31:38 -0600
+Subject: [PATCH] com32/lib/syslinux/debug.c: add missing stdio.h include.
+
+Fixes building with GCC 14.x
+---
+ com32/lib/syslinux/debug.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/com32/lib/syslinux/debug.c b/com32/lib/syslinux/debug.c
+index d9ab863f..e8f53d57 100644
+--- a/com32/lib/syslinux/debug.c
++++ b/com32/lib/syslinux/debug.c
+@@ -1,6 +1,7 @@
+ #include <linux/list.h>
+ #include <string.h>
+ #include <stdbool.h>
++#include <stdio.h>
+ 
+ #ifdef DYNAMIC_DEBUG
+ 
+-- 
+2.39.2
+
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hi Lance,

Quoted 18 lines · lancethepants

Add missing stdio.h include. Without it results in the following error under GCC 14.x

../../../com32/lib/syslinux/debug.c: In function ‘syslinux_debug’:
../../../com32/lib/syslinux/debug.c:91:5: error: implicit declaration of function ‘printf’ [-Wimplicit-function-declaration]

    91 |     printf("Dynamic debug unavailable\n");
---
  .../0020-pull-in-stdio-h-for-gcc14.patch      | 25 +++++++++++++++++++
  1 file changed, 25 insertions(+)

create mode 100644 boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +0 -0
new file mode 100644
index 0000000000..6711c7aa78

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch line 6

Quoted 6 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +6 -0
@@ -0,0 +1,25 @@
+From dfa2705100a893bc017d23406daa9a383fbc3c95 Mon Sep 17 00:00:00 2001
+From: lancethepants <[email protected]>
+Date: Wed, 5 Jun 2024 14:31:38 -0600
+Subject: [PATCH] com32/lib/syslinux/debug.c: add missing stdio.h include.
+
+Fixes building with GCC 14.x

As check-package reports, the patch is missing a Signed-off-by (to indicate
that you are allowed to contribute it under the syslinux license) and an Upstream: indicator. We expect you to submit the patch upstream before you submit it to buildroot.

Regards,
Arnout

Quoted 9 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +9 -0
+---
+ com32/lib/syslinux/debug.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/com32/lib/syslinux/debug.c b/com32/lib/syslinux/debug.c
+index d9ab863f..e8f53d57 100644
+--- a/com32/lib/syslinux/debug.c
++++ b/com32/lib/syslinux/debug.c
+@@ -1,6 +1,7 @@

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch line 25

Quoted 10 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +10 -0
+ #include <linux/list.h>
+ #include <string.h>
+ #include <stdbool.h>
++#include <stdio.h>
+
+ #ifdef DYNAMIC_DEBUG
+
+--
+2.39.2
+

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

I'm not sure I understand. The patch which you included in your reply does have a "Signed-off-by" line present.  Also, the last release of syslinux was in 2014, and buildroot seems to be carrying many patches against that release, so I was under the impression upstream is probably not accepting patches at this point.

The "From" when sending this patch doesn't match my name in the "Signed-off-by" as another maintainer mentioned in another patch I sent in, but this one was also sent before I received that reply.

Lance

Quoted 45 lines · Arnout Vandecappelle

 Hi Lance,

Quoted 23 lines · lancethepants

Add missing stdio.h include. Without it results in the following error under GCC 14.x

../../../com32/lib/syslinux/debug.c: In function ‘syslinux_debug’:
../../../com32/lib/syslinux/debug.c:91:5: error: implicit declaration of function ‘printf’ [-Wimplicit-function-declaration] 91 |     printf("Dynamic debug unavailable\n");

---
  .../0020-pull-in-stdio-h-for-gcc14.patch      | 25 +++++++++++++++++++

  1 file changed, 25 insertions(+)

  create mode 100644 boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +4 -0
new file mode 100644
index 0000000000..6711c7aa78
@@ -0,0 +1,25 @@
+From dfa2705100a893bc017d23406daa9a383fbc3c95 Mon Sep 17 00:00:00 2001
+From: lancethepants <[email protected]>
+Date: Wed, 5 Jun 2024 14:31:38 -0600
+Subject: [PATCH] com32/lib/syslinux/debug.c: add missing stdio.h 

include.

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch line 6

Quoted 2 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +2 -0
+
+Fixes building with GCC 14.x

 As check-package reports, the patch is missing a Signed-off-by (to indicate that you are allowed to contribute it under the syslinux license) and an Upstream: indicator. We expect you to submit the patch upstream before you submit it to buildroot.

 Regards,
 Arnout

Quoted 11 lines
+---
+ com32/lib/syslinux/debug.c | 1 +

+ 1 file changed, 1 insertion(+)

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +8 -0
+
+diff --git a/com32/lib/syslinux/debug.c b/com32/lib/syslinux/debug.c
+index d9ab863f..e8f53d57 100644
+--- a/com32/lib/syslinux/debug.c
++++ b/com32/lib/syslinux/debug.c
+@@ -1,6 +1,7 @@
+ #include <linux/list.h>
+ #include <string.h>
Quoted 8 lines

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch line 25

Quoted 8 lines

+ #include <stdbool.h>
++#include <stdio.h>

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +6 -0
+
+ #ifdef DYNAMIC_DEBUG
+
+--
+2.39.2
+

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
Quoted 1 line · Lance Fredrickson

I'm not sure I understand. The patch which you included in your reply does have a "Signed-off-by" line present.

With "the patch" I meant 0020-pull-in-stdio-h-for-gcc14.patch, i.e. the patch
file included in the patch. Confusing, I know...

It needs a separate signoff because the licensing situation is different:
changes to Buildroot itself are licensed under Buildroot's license (GPL-2.0), while patches to a package are licensed under that package's license.

Quoted 1 line

  Also, the last release of syslinux was in 2014, and buildroot seems to be carrying many patches against that release, so I was under the impression upstream is probably not accepting patches at this point.

Yeah I didn't look at the details. You still need an Upstream: tag in that
case, something like:

Upstream: dead (last release in 2014)

Quoted 1 line

The "From" when sending this patch doesn't match my name in the "Signed-off-by" as another maintainer mentioned in another patch I sent in, but this one was also sent before I received that reply.

Yes, this happens a lot. I fix up the author when applying (when I notice), so
don't worry too much about that one. It looks like setting up git send-email is complicated :-)

Groeten,
Arnout

Quoted 48 lines

Lance

Quoted 44 lines · Arnout Vandecappelle

 Hi Lance,

Quoted 18 lines · lancethepants

Add missing stdio.h include. Without it results in the following error under GCC 14.x

../../../com32/lib/syslinux/debug.c: In function ‘syslinux_debug’:
../../../com32/lib/syslinux/debug.c:91:5: error: implicit declaration of function ‘printf’ [-Wimplicit-function-declaration] 91 |     printf("Dynamic debug unavailable\n");

---
  .../0020-pull-in-stdio-h-for-gcc14.patch      | 25 +++++++++++++++++++

  1 file changed, 25 insertions(+)

  create mode 100644 boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +0 -0
new file mode 100644
index 0000000000..6711c7aa78

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch line 6

Quoted 6 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +6 -0
@@ -0,0 +1,25 @@
+From dfa2705100a893bc017d23406daa9a383fbc3c95 Mon Sep 17 00:00:00 2001
+From: lancethepants <[email protected]>
+Date: Wed, 5 Jun 2024 14:31:38 -0600
+Subject: [PATCH] com32/lib/syslinux/debug.c: add missing stdio.h include.
+
+Fixes building with GCC 14.x

 As check-package reports, the patch is missing a Signed-off-by (to indicate that you are allowed to contribute it under the syslinux license) and an Upstream: indicator. We expect you to submit the patch upstream before you submit it to buildroot.

 Regards,
 Arnout

Quoted 11 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +11 -0
+---
+ com32/lib/syslinux/debug.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/com32/lib/syslinux/debug.c b/com32/lib/syslinux/debug.c
+index d9ab863f..e8f53d57 100644
+--- a/com32/lib/syslinux/debug.c
++++ b/com32/lib/syslinux/debug.c
+@@ -1,6 +1,7 @@
+ #include <linux/list.h>
+ #include <string.h>
Quoted 9 lines
Quoted 8 lines

boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch line 25

Quoted 8 lines
boot/syslinux/0020-pull-in-stdio-h-for-gcc14.patch new file +8 -0
+ #include <stdbool.h>
++#include <stdio.h>
+
+ #ifdef DYNAMIC_DEBUG
+
+--
+2.39.2
+

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot