net: dsa: mv88e6xxx: support in-band signalling on SGMII ports with external PHYs
Subsystems (4)
PATCH 1/1 net: dsa: mv88e6xxx: support in-band signalling on SGMII ports with external PHYs
If an external PHY is connected via SGMII and uses in-band signalling then the auto-negotiated values aren't propagated to the port, resulting in a broken link. See discussion in [0]. This patch adds this propagation. We need to call mv88e6xxx_port_setup_mac(), therefore export it from chip.c.
Successfully tested on a ZII DTU with 88E6390 switch and an Aquantia AQCS109 PHY connected via SGMII to port 9.
[0] https://marc.info/?t=155130287200001&r=1&w=2
---
I consider this rather a missing feature than a bug. Therefore net-next.
--- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++-- drivers/net/dsa/mv88e6xxx/chip.h | 3 ++ drivers/net/dsa/mv88e6xxx/serdes.c | 49 +++++++++++++++++++++++------- drivers/net/dsa/mv88e6xxx/serdes.h | 8 +++++ 4 files changed, 52 insertions(+), 14 deletions(-)
drivers/net/dsa/mv88e6xxx/chip.c +3 -3
@@ -549,9 +549,9 @@ int mv88e6xxx_update(struct mv88e6xxx_chip *chip, int addr, int reg, u16 update)return mv88e6xxx_write (chip, addr, reg, val); } -static int mv88e6xxx_port_setup_mac (struct mv88e6xxx_chip *chip,int port, -int link,int speed,int duplex,int pause, -phy_interface_t mode) +int mv88e6xxx_port_setup_mac (struct mv88e6xxx_chip *chip,int port,int link, +int speed,int duplex,int pause, +phy_interface_t mode) {int err;
drivers/net/dsa/mv88e6xxx/chip.h +3 -0
@@ -579,6 +579,9 @@ int mv88e6xxx_write(struct mv88e6xxx_chip *chip, int addr, int reg, u16 val);int mv88e6xxx_update (struct mv88e6xxx_chip *chip,int addr,int reg,u16 update);int mv88e6xxx_wait (struct mv88e6xxx_chip *chip,int addr,int reg,u16 mask); +int mv88e6xxx_port_setup_mac (struct mv88e6xxx_chip *chip,int port,int link, +int speed,int duplex,int pause, +phy_interface_t mode);struct mii_bus *mv88e6xxx_default_mdio_bus (struct mv88e6xxx_chip *chip);#endif /* _MV88E6XXX_CHIP_H */
drivers/net/dsa/mv88e6xxx/serdes.c +38 -11
59 lines not on this page · raw message
drivers/net/dsa/mv88e6xxx/serdes.h +8 -0
@@ -69,6 +69,14 @@#define MV88E6390_SGMII_INT_SYMBOL_ERROR BIT(8)#define MV88E6390_SGMII_INT_FALSE_CARRIER BIT(7)#define MV88E6390_SGMII_INT_STATUS 0xa002 +#define MV88E6390_SGMII_PHY_STATUS 0xa003 +#define MV88E6390_SGMII_PHY_STATUS_SPEED_MASK GENMASK(15, 14) +#define MV88E6390_SGMII_PHY_STATUS_SPEED_1000 0x8000 +#define MV88E6390_SGMII_PHY_STATUS_SPEED_100 0x4000 +#define MV88E6390_SGMII_PHY_STATUS_SPEED_10 0x0000 +#define MV88E6390_SGMII_PHY_STATUS_DUPLEX_FULL BIT(13) +#define MV88E6390_SGMII_PHY_STATUS_SPD_DPL_VALID BIT(11) +#define MV88E6390_SGMII_PHY_STATUS_LINK BIT(10)int mv88e6390x_serdes_get_lane (struct mv88e6xxx_chip *chip,int port);int mv88e6341_serdes_power (struct mv88e6xxx_chip *chip,int port,bool on);
Signature · 1 line
2.21.0
From: Heiner Kallweit <[email protected]>
Date: Fri, 1 Mar 2019 20:41:00 +0100
Quoted 6 lines
If an external PHY is connected via SGMII and uses in-band signalling then the auto-negotiated values aren't propagated to the port, resulting in a broken link. See discussion in [0]. This patch adds this propagation. We need to call
mv88e6xxx_port_setup_mac(), therefore export it fromchip.c.
Quoted 8 lines
Successfully tested on a ZII DTU with 88E6390 switch and an Aquantia AQCS109 PHY connected via SGMII to port 9.
[0] https://marc.info/?t=155130287200001&r=1&w=2
Signed-off-by Heiner Kallweit <[email protected]>---
I consider this rather a missing feature than a bug. Therefore net-next.
Applied to net-next, thanks Heiner.