Skip to contentSkip to conversation

x86/mm: Handle physical-virtual alignment mismatch in phys_p4d_init()

PATCH Superseded Kirill A. Shutemov 5 participants 10 messages Jun 20, 2019 – Jun 24, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/mm: Handle physical-virtual alignment mismatch in phys_p4d_init()

Kyle has reported that kernel crashes sometimes when it boots in 5-level paging mode with KASLR enabled:

[    0.000000] WARNING: CPU: 0 PID: 0 at arch/x86/mm/init_64.c:87 phys_p4d_init+0x1d4/0x1ea
[    0.000000] Modules linked in:
[    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 5.2.0-rc5+ #27
[    0.000000] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.4
[    0.000000] RIP: 0010:phys_p4d_init+0x1d4/0x1ea
[    0.000000] Code: 20 be 43 94 ff 45 cc 4c 89 e6 e9 90 fe ff ff 48 89 d8 eb 1d 48 8b 4d d0 48 8b 7d c0 45 0f b6 3
[    0.000000] RSP: 0000:ffffffff94403c70 EFLAGS: 00000046 ORIG_RAX: 0000000000000000
[    0.000000] RAX: 0000000000000000 RBX: 0000000340000000 RCX: 0000000000000007
[    0.000000] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[    0.000000] RBP: ffffffff94403cb8 R08: 0000000000000023 R09: ffffffff947fa680
[    0.000000] R10: 0000000000000008 R11: 0000000000000031 R12: 0000010000000000
[    0.000000] R13: 0000000340000000 R14: ffffffff94403d01 R15: ff484d01962014d0
[    0.000000] FS:  0000000000000000(0000) GS:ffffffff9468a000(0000) knlGS:0000000000000000
[    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.000000] CR2: ff484d0196201000 CR3: 0000000315b3e000 CR4: 00000000000016b0
[    0.000000] Call Trace:
[    0.000000]  __kernel_physical_mapping_init+0x10a/0x35c
[    0.000000]  kernel_physical_mapping_init+0xe/0x10
[    0.000000]  init_memory_mapping+0x1aa/0x3b0
[    0.000000]  init_range_memory_mapping+0xc8/0x116
[    0.000000]  init_mem_mapping+0x225/0x2eb
[    0.000000]  setup_arch+0x6ff/0xcf5
[    0.000000]  start_kernel+0x64/0x53b
[    0.000000]  ? copy_bootdata+0x1f/0xce
[    0.000000]  x86_64_start_reservations+0x24/0x26
[    0.000000]  x86_64_start_kernel+0x8a/0x8d
[    0.000000]  secondary_startup_64+0xb6/0xc0
[    0.000000] random: get_random_bytes called from print_oops_end_marker+0x3f/0x60 with crng_init=0
...
[    0.000000] BUG: unable to handle page fault for address: ff484d019580eff8
[    0.000000] #PF: supervisor read access in kernel mode
[    0.000000] #PF: error_code(0x0000) - not-present page
[    0.000000] BAD
[    0.000000] Oops: 0000 [#1] SMP NOPTI
[    0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G        W         5.2.0-rc5+ #27
[    0.000000] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-0-ga698c8995f-prebuilt.qemu.4
[    0.000000] RIP: 0010:fill_pud+0x13/0x130
[    0.000000] Code: 48 83 c4 08 b8 f4 ff ff ff 5b 41 5c 41 5d 41 5e 41 5f 5d c3 31 c0 c3 e8 2b ee d8 00 55 48 89 4
[    0.000000] RSP: 0000:ffffffff94403dc0 EFLAGS: 00000006
[    0.000000] RAX: 00000000000001ff RBX: ffffffffff5fd000 RCX: 0000000000000030
[    0.000000] RDX: 00000000000001ff RSI: ffffffffff5fd000 RDI: ff484d019580eff8
[    0.000000] RBP: ffffffff94403de0 R08: 0000000000000078 R09: 0000000000000002
[    0.000000] R10: ffffffff94403cb0 R11: 000000000000005b R12: ff484d019580eff8
[    0.000000] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
[    0.000000] FS:  0000000000000000(0000) GS:ffffffff9468a000(0000) knlGS:0000000000000000
[    0.000000] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    0.000000] CR2: ff484d019580aa40 CR3: 000000031580a000 CR4: 00000000000016b0
[    0.000000] Call Trace:
[    0.000000]  set_pte_vaddr_p4d+0x2e/0x50
[    0.000000]  set_pte_vaddr+0x6f/0xb0
[    0.000000]  __native_set_fixmap+0x28/0x40
[    0.000000]  native_set_fixmap+0x39/0x70
[    0.000000]  register_lapic_address+0x49/0xb6
[    0.000000]  early_acpi_boot_init+0xa5/0xde
[    0.000000]  setup_arch+0x944/0xcf5
[    0.000000]  start_kernel+0x64/0x53b
[    0.000000]  ? copy_bootdata+0x1f/0xce
[    0.000000]  x86_64_start_reservations+0x24/0x26
[    0.000000]  x86_64_start_kernel+0x8a/0x8d
[    0.000000]  secondary_startup_64+0xb6/0xc0
[    0.000000] Modules linked in:
[    0.000000] CR2: ff484d019580eff8

Kyle bisected the issue to commmit b569c1843498 ("x86/mm/KASLR: Reduce randomization granularity for 5-level paging to 1GB")

The commit relaxes KASLR alignment requirements and it can lead to mismatch bentween 'i' and 'p4d_index(vaddr)' inside the loop in phys_p4d_init(). The mismatch in its turn leads to clearing wrong p4d entry and eventually to the oops.

The fix is to make phys_p4d_init() walk virtual address space, not physical one.

Reported-and-tested-by Kyle Pelton <[email protected]>
Fixes b569c1843498 ("x86/mm/KASLR: Reduce randomization granularity for 5-level paging to 1GB")
Cc Baoquan He <[email protected]>
---
 arch/x86/mm/init_64.c | 39 ++++++++++++++++-----------------------
 1 file changed, 16 insertions(+), 23 deletions(-)
arch/x86/mm/init_64.c +16 -23
index 693aaf28d5fe..4628ac9105a2 100644
@@ -671,41 +671,34 @@ static unsigned long __meminit
 phys_p4d_init(p4d_t *p4d_page, unsigned long paddr, unsigned long paddr_end,
 	      unsigned long page_size_mask, bool init)
 {
-	unsigned long paddr_next, paddr_last = paddr_end;
-	unsigned long vaddr = (unsigned long)__va(paddr);
-	int i = p4d_index(vaddr);
+	unsigned long vaddr, vaddr_start, vaddr_end, vaddr_next, paddr_last;
+
+	paddr_last = paddr_end;
+	vaddr = (unsigned long)__va(paddr);
+	vaddr_end = (unsigned long)__va(paddr_end);
+	vaddr_start = vaddr;
 
 	if (!pgtable_l5_enabled())
 		return phys_pud_init((pud_t *) p4d_page, paddr, paddr_end,
 				     page_size_mask, init);
 
-	for (; i < PTRS_PER_P4D; i++, paddr = paddr_next) {
-		p4d_t *p4d;
+	for (; vaddr < vaddr_end; vaddr = vaddr_next) {
+		p4d_t *p4d = p4d_page + p4d_index(vaddr);
 		pud_t *pud;
 
-		vaddr = (unsigned long)__va(paddr);
-		p4d = p4d_page + p4d_index(vaddr);
-		paddr_next = (paddr & P4D_MASK) + P4D_SIZE;
+		vaddr_next = (vaddr & P4D_MASK) + P4D_SIZE;
 
-		if (paddr >= paddr_end) {
-			if (!after_bootmem &&
-			    !e820__mapped_any(paddr & P4D_MASK, paddr_next,
-					     E820_TYPE_RAM) &&
-			    !e820__mapped_any(paddr & P4D_MASK, paddr_next,
-					     E820_TYPE_RESERVED_KERN))
-				set_p4d_init(p4d, __p4d(0), init);
-			continue;
-		}
-
-		if (!p4d_none(*p4d)) {
-			pud = pud_offset(p4d, 0);
-			paddr_last = phys_pud_init(pud, paddr, paddr_end,
-						   page_size_mask, init);
+		if (p4d_val(*p4d)) {
+			pud = (pud_t *)p4d_page_vaddr(*p4d);
+			paddr_last = phys_pud_init(pud, __pa(vaddr),
+						   __pa(vaddr_end),
+						   page_size_mask,
+						   init);
 			continue;
 		}
 
 		pud = alloc_low_page();
-		paddr_last = phys_pud_init(pud, paddr, paddr_end,
+		paddr_last = phys_pud_init(pud, __pa(vaddr), __pa(vaddr_end),
 					   page_size_mask, init);
 
 		spin_lock(&init_mm.page_table_lock);
Signature · 1 line
2.21.0
#1 lore raw
Quoted 4 lines · Kirill A. Shutemov

The commit relaxes KASLR alignment requirements and it can lead to mismatch bentween 'i' and 'p4d_index(vaddr)' inside the loop in phys_p4d_init(). The mismatch in its turn leads to clearing wrong p4d entry and eventually to the oops.

Just curious, but what does it relax the requirement to and from?

I'm just not clearly spotting the actual bug.

#2 lore raw
Quoted 9 lines · Dave Hansen
Quoted 4 lines · Kirill A. Shutemov

The commit relaxes KASLR alignment requirements and it can lead to mismatch bentween 'i' and 'p4d_index(vaddr)' inside the loop in phys_p4d_init(). The mismatch in its turn leads to clearing wrong p4d entry and eventually to the oops.

Just curious, but what does it relax the requirement to and from?

I'm just not clearly spotting the actual bug.

Before the commit PAGE_OFFSET is always aligned to P4D_SIZE if we boot in 5-level paging mode. But now only PUD_SIZE alignment is guaranteed.

For phys_p4d_init() it means that paddr_next after the first iteration can belong to the same p4d entry.

In the case I was able to reproduce the vaddr on the first iteration is 0xff4228027fe00000 and paddr is 0x33fe00000. On the second iteration vaddr becomes 0xff42287f40000000 and paddr is 0x8000000000. The vaddr in both cases bolong to the same p4d entry.

It screws up 'i' count: we miss the last entry in the page table completely. And it confuses the branch under 'paddr >= paddr_end'
condition: the p4d entry can be cleared where must not to.

The patch makes phys_p4d_init() work like __kernel_physical_mapping_init() which deals with phys-virt mismatch already.

I hope this explanation makes any sense :P

Signature · 1 line
 Kirill A. Shutemov
#3 lore raw
Quoted 1 line · Kirill A. Shutemov

I hope this explanation makes any sense :P

Yes, thanks for the details!

#4 lore raw
In reply to Kirill A. Shutemov
Quoted 22 lines · Kirill A. Shutemov
Quoted 9 lines · Dave Hansen
Quoted 4 lines · Kirill A. Shutemov

The commit relaxes KASLR alignment requirements and it can lead to mismatch bentween 'i' and 'p4d_index(vaddr)' inside the loop in phys_p4d_init(). The mismatch in its turn leads to clearing wrong p4d entry and eventually to the oops.

Just curious, but what does it relax the requirement to and from?

I'm just not clearly spotting the actual bug.

Before the commit PAGE_OFFSET is always aligned to P4D_SIZE if we boot in 5-level paging mode. But now only PUD_SIZE alignment is guaranteed.

For phys_p4d_init() it means that paddr_next after the first iteration can belong to the same p4d entry.

In the case I was able to reproduce the vaddr on the first iteration is 0xff4228027fe00000 and paddr is 0x33fe00000. On the second iteration vaddr becomes 0xff42287f40000000 and paddr is 0x8000000000. The vaddr in both cases bolong to the same p4d entry.

Quoted 8 lines

It screws up 'i' count: we miss the last entry in the page table completely. And it confuses the branch under 'paddr >= paddr_end'
condition: the p4d entry can be cleared where must not to.

The patch makes phys_p4d_init() work like __kernel_physical_mapping_init() which deals with phys-virt mismatch already.

I hope this explanation makes any sense :P

Yes, and it should have been in the changelog right away. It's much more useful than the 63 lines of untrimmed backtrace noise, which should be condensed to the real valuable information:

  WARNING: CPU: 0 PID: 0 at arch/x86/mm/init_64.c:87 phys_p4d_init+0x1d4/0x1ea
  RIP: 0010:phys_p4d_init+0x1d4/0x1ea
  Call Trace:
   __kernel_physical_mapping_init+0x10a/0x35c
   kernel_physical_mapping_init+0xe/0x10
   init_memory_mapping+0x1aa/0x3b0
   init_range_memory_mapping+0xc8/0x116
   init_mem_mapping+0x225/0x2eb
   setup_arch+0x6ff/0xcf5
   start_kernel+0x64/0x53b
   ? copy_bootdata+0x1f/0xce
   x86_64_start_reservations+0x24/0x26
   x86_64_start_kernel+0x8a/0x8d
   secondary_startup_64+0xb6/0xc0

which causes later:

  BUG: unable to handle page fault for address: ff484d019580eff8
  #PF: supervisor read access in kernel mode
  #PF: error_code(0x0000) - not-present page
  BAD
  Oops: 0000 [#1] SMP NOPTI
  RIP: 0010:fill_pud+0x13/0x130
  Call Trace:
   set_pte_vaddr_p4d+0x2e/0x50
   set_pte_vaddr+0x6f/0xb0
   __native_set_fixmap+0x28/0x40
   native_set_fixmap+0x39/0x70
   register_lapic_address+0x49/0xb6
   early_acpi_boot_init+0xa5/0xde
   setup_arch+0x944/0xcf5
   start_kernel+0x64/0x53b

Hmm?

Thanks,

tglx

#5 lore raw
In reply to Kirill A. Shutemov

Hi Kirill,

Quoted 2 lines · Kirill A. Shutemov

Kyle has reported that kernel crashes sometimes when it boots in 5-level paging mode with KASLR enabled:

This is a great finding, thanks for the fix. I ever have modified codes to make them accommodate PMD level of randomization, this phys_p4d_init() part is included. Not sure why I missed it when later took PUD level randomization for 5-level.

https://github.com/baoquan-he/linux/commit/dc91f5292bf1f55666c9139b6621d830b5b38aa5

Have some concerns, please check.

Quoted 1 line
[    0.000000] WARNING: CPU: 0 PID: 0 at arch/x86/mm/init_64.c:87 phys_p4d_init+0x1d4/0x1ea

......

Quoted 5 lines

Kyle bisected the issue to commmit b569c1843498 ("x86/mm/KASLR: Reduce randomization granularity for 5-level paging to 1GB")

The commit relaxes KASLR alignment requirements and it can lead to mismatch bentween 'i' and 'p4d_index(vaddr)' inside the loop in

^ between

Quoted 21 lines

phys_p4d_init(). The mismatch in its turn leads to clearing wrong p4d entry and eventually to the oops.

The fix is to make phys_p4d_init() walk virtual address space, not physical one.

Reported-and-tested-by Kyle Pelton <[email protected]>
Fixes b569c1843498 ("x86/mm/KASLR: Reduce randomization granularity for 5-level paging to 1GB")
Cc Baoquan He <[email protected]>
---
 arch/x86/mm/init_64.c | 39 ++++++++++++++++-----------------------
 1 file changed, 16 insertions(+), 23 deletions(-)
arch/x86/mm/init_64.c +0 -0
index 693aaf28d5fe..4628ac9105a2 100644
@@ -671,41 +671,34 @@ static unsigned long __meminit
 phys_p4d_init(p4d_t *p4d_page, unsigned long paddr, unsigned long paddr_end,
 	      unsigned long page_size_mask, bool init)

arch/x86/mm/init_64.c static unsigned long __meminit · line 679

Quoted 10 lines
arch/x86/mm/init_64.c +6 -3
 {
-	unsigned long paddr_next, paddr_last = paddr_end;
-	unsigned long vaddr = (unsigned long)__va(paddr);
-	int i = p4d_index(vaddr);
+	unsigned long vaddr, vaddr_start, vaddr_end, vaddr_next, paddr_last;
+
+	paddr_last = paddr_end;
+	vaddr = (unsigned long)__va(paddr);
+	vaddr_end = (unsigned long)__va(paddr_end);
+	vaddr_start = vaddr;

Variable vaddr_start is not used in this patch, redundent?

Quoted 6 lines
arch/x86/mm/init_64.c +0 -1
 	if (!pgtable_l5_enabled())
 		return phys_pud_init((pud_t *) p4d_page, paddr, paddr_end,
 				     page_size_mask, init);
 
-	for (; i < PTRS_PER_P4D; i++, paddr = paddr_next) {

arch/x86/mm/init_64.c static unsigned long __meminit · line 690

Quoted 10 lines
arch/x86/mm/init_64.c +3 -4
-		p4d_t *p4d;
+	for (; vaddr < vaddr_end; vaddr = vaddr_next) {
+		p4d_t *p4d = p4d_page + p4d_index(vaddr);
 		pud_t *pud;
 
-		vaddr = (unsigned long)__va(paddr);
-		p4d = p4d_page + p4d_index(vaddr);
-		paddr_next = (paddr & P4D_MASK) + P4D_SIZE;
+		vaddr_next = (vaddr & P4D_MASK) + P4D_SIZE;
 

The code block as below is to zero p4d entries which are not coverred by the current memory range, and if haven't been mapped already. It's clearred away in this patch, could you also mention it in log, and tell why it doesn't matter now?

If it doesn't matter, should we clear away the simillar code in phys_pud_init/phys_pmd_init/phys_pte_init? Maybe a prep patch to do the clean up?

Thanks
Baoquan

Quoted 32 lines
arch/x86/mm/init_64.c +7 -15
-		if (paddr >= paddr_end) {
-			if (!after_bootmem &&
-			    !e820__mapped_any(paddr & P4D_MASK, paddr_next,
-					     E820_TYPE_RAM) &&
-			    !e820__mapped_any(paddr & P4D_MASK, paddr_next,
-					     E820_TYPE_RESERVED_KERN))
-				set_p4d_init(p4d, __p4d(0), init);
-			continue;
-		}
-
-		if (!p4d_none(*p4d)) {
-			pud = pud_offset(p4d, 0);
-			paddr_last = phys_pud_init(pud, paddr, paddr_end,
-						   page_size_mask, init);
+		if (p4d_val(*p4d)) {
+			pud = (pud_t *)p4d_page_vaddr(*p4d);
+			paddr_last = phys_pud_init(pud, __pa(vaddr),
+						   __pa(vaddr_end),
+						   page_size_mask,
+						   init);
 			continue;
 		}
 
 		pud = alloc_low_page();
-		paddr_last = phys_pud_init(pud, paddr, paddr_end,
+		paddr_last = phys_pud_init(pud, __pa(vaddr), __pa(vaddr_end),
 					   page_size_mask, init);
 
 		spin_lock(&init_mm.page_table_lock);
Signature · 1 line
2.21.0
#6 lore raw
Quoted 48 lines · Baoquan He

Hi Kirill,

Quoted 2 lines · Kirill A. Shutemov

Kyle has reported that kernel crashes sometimes when it boots in 5-level paging mode with KASLR enabled:

This is a great finding, thanks for the fix. I ever have modified codes to make them accommodate PMD level of randomization, this phys_p4d_init() part is included. Not sure why I missed it when later took PUD level randomization for 5-level.

https://github.com/baoquan-he/linux/commit/dc91f5292bf1f55666c9139b6621d830b5b38aa5

Have some concerns, please check.

Quoted 1 line
[    0.000000] WARNING: CPU: 0 PID: 0 at arch/x86/mm/init_64.c:87 phys_p4d_init+0x1d4/0x1ea

......

Quoted 5 lines

Kyle bisected the issue to commmit b569c1843498 ("x86/mm/KASLR: Reduce randomization granularity for 5-level paging to 1GB")

The commit relaxes KASLR alignment requirements and it can lead to mismatch bentween 'i' and 'p4d_index(vaddr)' inside the loop in

^ between

Quoted 25 lines

phys_p4d_init(). The mismatch in its turn leads to clearing wrong p4d entry and eventually to the oops.

The fix is to make phys_p4d_init() walk virtual address space, not physical one.

Reported-and-tested-by Kyle Pelton <[email protected]>
Fixes b569c1843498 ("x86/mm/KASLR: Reduce randomization granularity for 5-level paging to 1GB")
Cc Baoquan He <[email protected]>
---
 arch/x86/mm/init_64.c | 39 ++++++++++++++++-----------------------
 1 file changed, 16 insertions(+), 23 deletions(-)
arch/x86/mm/init_64.c +0 -3
index 693aaf28d5fe..4628ac9105a2 100644
@@ -671,41 +671,34 @@ static unsigned long __meminit
 phys_p4d_init(p4d_t *p4d_page, unsigned long paddr, unsigned long paddr_end,
 	      unsigned long page_size_mask, bool init)
 {
-	unsigned long paddr_next, paddr_last = paddr_end;
-	unsigned long vaddr = (unsigned long)__va(paddr);
-	int i = p4d_index(vaddr);
Quoted 8 lines

arch/x86/mm/init_64.c static unsigned long __meminit · line 679

Quoted 6 lines
arch/x86/mm/init_64.c +6 -0
+	unsigned long vaddr, vaddr_start, vaddr_end, vaddr_next, paddr_last;
+
+	paddr_last = paddr_end;
+	vaddr = (unsigned long)__va(paddr);
+	vaddr_end = (unsigned long)__va(paddr_end);
+	vaddr_start = vaddr;

Variable vaddr_start is not used in this patch, redundent?

Yep. I'll drop it in v2.

Quoted 22 lines
Quoted 6 lines
arch/x86/mm/init_64.c +0 -1
 	if (!pgtable_l5_enabled())
 
 		return phys_pud_init((pud_t *) p4d_page, paddr, paddr_end,
 				     page_size_mask, init);
 
-	for (; i < PTRS_PER_P4D; i++, paddr = paddr_next) {

arch/x86/mm/init_64.c static unsigned long __meminit · line 690

Quoted 10 lines
arch/x86/mm/init_64.c +3 -4
-		p4d_t *p4d;
+	for (; vaddr < vaddr_end; vaddr = vaddr_next) {
+		p4d_t *p4d = p4d_page + p4d_index(vaddr);
 		pud_t *pud;
 
-		vaddr = (unsigned long)__va(paddr);
-		p4d = p4d_page + p4d_index(vaddr);
-		paddr_next = (paddr & P4D_MASK) + P4D_SIZE;
+		vaddr_next = (vaddr & P4D_MASK) + P4D_SIZE;
 

The code block as below is to zero p4d entries which are not coverred by the current memory range, and if haven't been mapped already. It's clearred away in this patch, could you also mention it in log, and tell why it doesn't matter now?

Quoted 3 lines

If it doesn't matter, should we clear away the simillar code in phys_pud_init/phys_pmd_init/phys_pte_init? Maybe a prep patch to do the clean up?

It only matters for the levels that contains page table entries that can point to pages, not page tables. There's no p4d or pgd huge pages on x86. Otherwise we only leak page tables without any benefit.

We might have this on all leveles under p?d_large() condition and don't touch page tables at all.

BTW, it all becomes rather risky for this late in the release cycle. Maybe we should revert the original patch and try again later with more comprehansive solution?

Signature · 1 line
 Kirill A. Shutemov
#7 lore raw
Quoted 5 lines · Kirill A. Shutemov
Quoted 5 lines

The code block as below is to zero p4d entries which are not coverred by the current memory range, and if haven't been mapped already. It's clearred away in this patch, could you also mention it in log, and tell why it doesn't matter now?

Quoted 7 lines
Quoted 3 lines

If it doesn't matter, should we clear away the simillar code in phys_pud_init/phys_pmd_init/phys_pte_init? Maybe a prep patch to do the clean up?

It only matters for the levels that contains page table entries that can point to pages, not page tables. There's no p4d or pgd huge pages on x86. Otherwise we only leak page tables without any benefit.

Ah, I checked git history, didn't find why it's added. I just Have a superficial knowledge of the clearing, but in a low-efficiency way.

Quoted 3 lines

We might have this on all leveles under p?d_large() condition and don't touch page tables at all.

I see.

Quoted 4 lines

BTW, it all becomes rather risky for this late in the release cycle. Maybe we should revert the original patch and try again later with more comprehansive solution?

It's not added in one time. I am fine with your current change, would be much better if mention it in log, and also add code comment above the clearing code. Surely reverting and trying later with more comprehensive solution is also good to me, this need a little more effort.

Thanks
Baoquan

#8 lore raw
Quoted 24 lines · Baoquan He
Quoted 5 lines · Kirill A. Shutemov
Quoted 5 lines

The code block as below is to zero p4d entries which are not coverred by the current memory range, and if haven't been mapped already. It's clearred away in this patch, could you also mention it in log, and tell why it doesn't matter now?

Quoted 7 lines
Quoted 3 lines

If it doesn't matter, should we clear away the simillar code in phys_pud_init/phys_pmd_init/phys_pte_init? Maybe a prep patch to do the clean up?

It only matters for the levels that contains page table entries that can point to pages, not page tables. There's no p4d or pgd huge pages on x86. Otherwise we only leak page tables without any benefit.

Ah, I checked git history, didn't find why it's added. I just Have a superficial knowledge of the clearing, but in a low-efficiency way.

Quoted 3 lines

We might have this on all leveles under p?d_large() condition and don't touch page tables at all.

I see.

Quoted 1 line
Quoted 8 lines
Quoted 3 lines

BTW, it all becomes rather risky for this late in the release cycle. Maybe we should revert the original patch and try again later with more comprehansive solution?

It's not added in one time. I am fine with your current change, would be much better if mention it in log, and also add code comment above the clearing code. Surely reverting and trying later with more comprehensive solution is also good to me, this need a little more effort.

I've decided to keep the block for now. We can remove it later, once the fixis in. I'll post it soon

Signature · 1 line
 Kirill A. Shutemov
#9 lore raw
Quoted 29 lines · Kirill A. Shutemov
Quoted 28 lines · Baoquan He
Quoted 5 lines · Kirill A. Shutemov
Quoted 5 lines

The code block as below is to zero p4d entries which are not coverred by the current memory range, and if haven't been mapped already. It's clearred away in this patch, could you also mention it in log, and tell why it doesn't matter now?

Quoted 7 lines
Quoted 3 lines

If it doesn't matter, should we clear away the simillar code in phys_pud_init/phys_pmd_init/phys_pte_init? Maybe a prep patch to do the clean up?

It only matters for the levels that contains page table entries that can point to pages, not page tables. There's no p4d or pgd huge pages on x86. Otherwise we only leak page tables without any benefit.

Ah, I checked git history, didn't find why it's added. I just Have a superficial knowledge of the clearing, but in a low-efficiency way.

Quoted 3 lines

We might have this on all leveles under p?d_large() condition and don't touch page tables at all.

I see.

Quoted 4 lines

BTW, it all becomes rather risky for this late in the release cycle. Maybe we should revert the original patch and try again later with more comprehansive solution?

Quoted 7 lines
Quoted 4 lines

It's not added in one time. I am fine with your current change, would be much better if mention it in log, and also add code comment above the clearing code. Surely reverting and trying later with more comprehensive solution is also good to me, this need a little more effort.

I've decided to keep the block for now. We can remove it later, once the fixis in. I'll post it soon

That's great, can make those codes more understandable with clear commit log and code comment.