Skip to contentSkip to conversation

fs: ocfs2 remove unneeded break

PATCH Applied [email protected] 2 participants 2 messages Oct 19, 2020 – Oct 20, 2020 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: ocfs2 remove unneeded break

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a goto

---
 fs/ocfs2/cluster/tcp.c | 1 -
 1 file changed, 1 deletion(-)
fs/ocfs2/cluster/tcp.c +0 -1
index 79a231719460..3bd8119bed5e 100644
@@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
 			msglog(hdr, "bad magic\n");
 			ret = -EINVAL;
 			goto out;
-			break;
 	}
 
 	/* find a handler for it */
Signature · 1 line
2.18.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · trix at redhat.com

From: Tom Rix <[email protected]>

A break is not needed if it is preceded by a goto

Quoted 17 lines
---
 fs/ocfs2/cluster/tcp.c | 1 -
 1 file changed, 1 deletion(-)
fs/ocfs2/cluster/tcp.c +0 -1
index 79a231719460..3bd8119bed5e 100644
@@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc,
 			msglog(hdr, "bad magic\n");
 			ret = -EINVAL;
 			goto out;
-			break;
 	}
 
 	/* find a handler for it */