Skip to contentSkip to conversation

get rid of [softirq-NULL]

PATCH In review Remy Bohmer 2 participants 3 messages Sep 24, 2009 – Sep 25, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 get rid of [softirq-NULL]

if CONFIG_HIGH_RES_TIMERS is not configured, still the hrtimer-softirq is started, so to prevent the name 'softirq-NULL' in 'ps' output we should still define its name here.
Preventing the softirq from starting at all would touch much more code, so I chose the easy way here, it is a cosmetic fix anyway.

---
 kernel/softirq.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/softirq.c +0 -2
index aae8d45..590049c 100644
@@ -1139,9 +1139,7 @@ static const char *softirq_names [] =
   [NET_RX_SOFTIRQ]	= "net-rx",
   [BLOCK_SOFTIRQ]	= "block",
   [TASKLET_SOFTIRQ]	= "tasklet",
-#ifdef CONFIG_HIGH_RES_TIMERS
   [HRTIMER_SOFTIRQ]	= "hrtimer",
-#endif
   [RCU_SOFTIRQ]		= "rcu",
 };
 
Signature · 1 line
1.6.0.4
#1 lore raw

2009/9/24 Remy Bohmer <[email protected]>:

Quoted 7 lines

if CONFIG_HIGH_RES_TIMERS is not configured, still the hrtimer-softirq is started, so to prevent the name 'softirq-NULL' in 'ps' output we should still define its name here.
Preventing the softirq from starting at all would touch much more code, so I chose the easy way here, it is a cosmetic fix anyway.

oops... Forgot to mention that this patch applies to 2.6.31-rt11 (preempt-RT)

Quoted 19 lines

---
 kernel/softirq.c |    2 --

 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/softirq.c +0 -3
index aae8d45..590049c 100644
@@ -1139,9 +1139,7 @@ static const char *softirq_names [] =
   [NET_RX_SOFTIRQ]     = "net-rx",
   [BLOCK_SOFTIRQ]      = "block",
   [TASKLET_SOFTIRQ]    = "tasklet",
-#ifdef CONFIG_HIGH_RES_TIMERS
   [HRTIMER_SOFTIRQ]    = "hrtimer",
-#endif
   [RCU_SOFTIRQ]                = "rcu",
  };
 
--
Quoted 3 lines

1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to Remy Bohmer
Quoted 5 lines · Remy Bohmer

if CONFIG_HIGH_RES_TIMERS is not configured, still the hrtimer-softirq is started, so to prevent the name 'softirq-NULL' in 'ps' output we should still define its name here.
Preventing the softirq from starting at all would touch much more code, so I chose the easy way here, it is a cosmetic fix anyway.

Anyway, it would be the right thing to do just that.

Just un-define the enum HRTIMER_SOFTIRQ and the code that needs modification should pop up. Removing it from the enum also disables the kthread. Most of the code that raises the softirq should be guarded by CONFIG_HIGH_RES_TIMERS anyway.

HtH,
Jan