i2c-sh7760: Adjustments for sh7760_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 15:18:29 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation Improve a size determination

 drivers/i2c/busses/i2c-sh7760.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

2.16.1

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 11:46:02 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

---
 drivers/i2c/busses/i2c-sh7760.c | 1 -
 1 file changed, 1 deletion(-)

index c2005c789d2b..4d2e4d10600b 100644
@@ -445,7 +445,6 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
 
 	id = kzalloc(sizeof(struct cami2c), GFP_KERNEL);
 	if (!id) {
-		dev_err(&pdev->dev, "no mem for private data\n");
 		ret = -ENOMEM;
 		goto out0;
 	}

2.16.1

From: Markus Elfring <[email protected]>
Date: Fri, 2 Feb 2018 14:50:09 +0100

Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

---
 drivers/i2c/busses/i2c-sh7760.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 4d2e4d10600b..62bc23b9acbb 100644
@@ -443,7 +443,7 @@ static int sh7760_i2c_probe(struct platform_device *pdev)
 		goto out0;
 	}
 
-	id = kzalloc(sizeof(struct cami2c), GFP_KERNEL);
+	id = kzalloc(sizeof(*id), GFP_KERNEL);
 	if (!id) {
 		ret = -ENOMEM;
 		goto out0;

2.16.1