Skip to contentSkip to conversation

package/kodi: fix path to binary

PATCH New Yann E. MORIN 3 participants 5 messages Apr 22, 2017 – Apr 23, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kodi: fix path to binary

Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi.

In 62165ae (package/kodi: Fix path to binary in service), the path nary was changed to use the new canonical path, but the init script was eft out. This was not seen previously, becasue of the legacy symlink.

But with the adevent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works.

Do for the init script what was done two years ago for the service file.

Cc Maxime Hadjinlian <[email protected]>
Cc Bernd Kuhls <[email protected]>
---
 package/kodi/S50kodi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/kodi/S50kodi +1 -1
index f00c59c5d9..0afe7a6706 100755
@@ -4,7 +4,7 @@
 #
 
 BIN=/usr/bin/br-kodi
-KODI=/usr/lib/xbmc/kodi.bin
+KODI=/usr/lib/kodi/kodi.bin
 KODI_ARGS="--standalone -fs -n"
 PIDFILE=/var/run/kodi.pid
 
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/kodi: fix path to binary

All,

On 2017-04-22 23:05 +0200, Yann E. MORIN spake thusly:

Quoted 5 lines

Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi.

In 62165ae (package/kodi: Fix path to binary in service), the path nary

s/ nary$//

Not sure what hapenned...

Regards,
Yann E. MORIN.

Quoted 31 lines

was changed to use the new canonical path, but the init script was eft out. This was not seen previously, becasue of the legacy symlink.

But with the adevent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works.

Do for the init script what was done two years ago for the service file.

Cc Maxime Hadjinlian <[email protected]>
Cc Bernd Kuhls <[email protected]>
---
 package/kodi/S50kodi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/kodi/S50kodi +1 -1
index f00c59c5d9..0afe7a6706 100755
@@ -4,7 +4,7 @@
 #
 
 BIN=/usr/bin/br-kodi
-KODI=/usr/lib/xbmc/kodi.bin
+KODI=/usr/lib/kodi/kodi.bin
 KODI_ARGS="--standalone -fs -n"
 PIDFILE=/var/run/kodi.pid
 
Signature · 1 line
2.11.0
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/kodi: fix path to binary

In reply to Yann E. MORIN

Am Sat, 22 Apr 2017 23:05:39 +0200 schrieb Yann E. MORIN:

Quoted 26 lines

Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi.

In 62165ae (package/kodi: Fix path to binary in service), the path nary was changed to use the new canonical path, but the init script was eft out. This was not seen previously, becasue of the legacy symlink.

But with the adevent of Kodi 17 (Krypton), that legacy symlink is no more, and the init script no longer works.

Do for the init script what was done two years ago for the service file.

Signed-off-by: "Yann E. MORIN"
<[email protected]> Cc: Maxime Hadjinlian
<[email protected]>
Cc: Bernd Kuhls <[email protected]>

---
 package/kodi/S50kodi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/kodi/S50kodi index renamed from package/kodi/S50kodi +0 -0

f00c59c5d9..0afe7a6706 100755 --- a/package/kodi/S50kodi +++ b/package/kodi/S50kodi @@ -4,7 +4,7 @@
#

Quoted 3 lines

BIN=/usr/bin/br-kodi
-KODI=/usr/lib/xbmc/kodi.bin +KODI=/usr/lib/kodi/kodi.bin
KODI_ARGS="--standalone -fs -n" PIDFILE=/var/run/kodi.pid

#3 lore raw

PATCH 1/1 package/kodi: fix path to binary

In reply to Yann E. MORIN

Hey Yann,

Quoted 6 lines · Yann E. MORIN

Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi.

In 62165ae (package/kodi: Fix path to binary in service), the path nary was changed to use the new canonical path, but the init script was eft

Another typo here 'eft'.

Quoted 3 lines

out. This was not seen previously, becasue of the legacy symlink.

But with the adevent of Kodi 17 (Krypton), that legacy symlink is no

And here 'adevent'.

Quoted 1 line

[...]

Best wishes,
Marcus

#4 lore raw

PATCH 1/1 package/kodi: fix path to binary

Marcus, All,

On 2017-04-22 23:22 +0200, Marcus Hoffmann spake thusly:

Quoted 8 lines · Yann E. MORIN
Quoted 6 lines

Since XBMC was renamed to Kodi, upstream is progressively propagating the rename to directories and files, and in some cases kept a legacy symlink xbmc->kodi, like /usr/lib/xbmc pointing to /usr/lib/kodi.

In 62165ae (package/kodi: Fix path to binary in service), the path nary was changed to use the new canonical path, but the init script was eft

Quoted 7 lines

Another typo here 'eft'.

Quoted 3 lines

out. This was not seen previously, becasue of the legacy symlink.

But with the adevent of Kodi 17 (Krypton), that legacy symlink is no

And here 'adevent'.

Thanks, I'll respin.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'