drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
PATCH v2 1/1 drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c, which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without setting CONFIG_PPC_RTAS throws the following errors:
ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and CONFIG_PPC_RTAS was not set. Logs are here:
http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/Kconfig +1 -1
@@ -1688,7 +1688,7 @@ config MEN_A21_WDT config WATCHDOG_RTAS tristate "RTAS watchdog" - depends on PPC_RTAS || (PPC64 && COMPILE_TEST) + depends on PPC_RTAS help This driver adds watchdog support for the RTAS watchdog.
Signature · 1 line
2.9.4
Quoted 13 lines · Murilo Opsfelder Araujo
drivers/watchdog/wdrtas.cuses symbols defined inarch/powerpc/kernel/rtas.c, which are exported iffCONFIG_PPC_RTASis selected. Buildingwdrtas.cwithout settingCONFIG_PPC_RTASthrows the following errors:ERROR: ".rtas_token" [
drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!This was identified during a randconfig build where
CONFIG_WATCHDOG_RTAS=mandCONFIG_PPC_RTASwas not set. Logs are here:
Quoted 6 lines
http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/This patch fixes the issue by updating
CONFIG_WATCHDOG_RTASto depend on justCONFIG_PPC_RTAS, removingCOMPILE_TESTentirely.Signed-off-by Murilo Opsfelder Araujo <[email protected]>
Quoted 18 lines
--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/watchdog/Kconfig +1
-1@@ -1688,7 +1688,7 @@ config MEN_A21_WDT config WATCHDOG_RTAS tristate "RTAS watchdog" - depends on PPC_RTAS || (PPC64 && COMPILE_TEST) + depends on PPC_RTAS help This driver adds watchdog support for the RTAS watchdog.
Quoted 15 lines · Murilo Opsfelder Araujo
drivers/watchdog/wdrtas.cuses symbols defined inarch/powerpc/kernel/rtas.c, which are exported iffCONFIG_PPC_RTASis selected. Buildingwdrtas.cwithout settingCONFIG_PPC_RTASthrows the following errors:ERROR: ".rtas_token" [
drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!This was identified during a randconfig build where
CONFIG_WATCHDOG_RTAS=mandCONFIG_PPC_RTASwas not set. Logs are here:http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
Quoted 7 lines
This patch fixes the issue by updating
CONFIG_WATCHDOG_RTASto depend on justCONFIG_PPC_RTAS, removingCOMPILE_TESTentirely.Signed-off-by Murilo Opsfelder Araujo <[email protected]>--- drivers/watchdog/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
cheers
Michael Ellerman
AppliedQuoted 13 lines · Murilo Opsfelder Araujo
drivers/watchdog/wdrtas.cuses symbols defined inarch/powerpc/kernel/rtas.c, which are exported iffCONFIG_PPC_RTASis selected. Buildingwdrtas.cwithout settingCONFIG_PPC_RTASthrows the following errors:ERROR: ".rtas_token" [
drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!This was identified during a randconfig build where
CONFIG_WATCHDOG_RTAS=mandCONFIG_PPC_RTASwas not set. Logs are here:
Quoted 8 lines
http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/This patch fixes the issue by updating
CONFIG_WATCHDOG_RTASto depend on justCONFIG_PPC_RTAS, removingCOMPILE_TESTentirely.Signed-off-by Murilo Opsfelder Araujo <[email protected]>Reviewed-by Guenter Roeck <[email protected]>Acked-by Michael Ellerman <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/42bed042556261b56aa92e05f4f388
cheers