Skip to contentSkip to conversation

powerpc/powernv: Use early_radix_enabled in POWER9 tlb flush

PATCH Applied Nicholas Piggin 3 participants 3 messages Sep 27, 2017 – Oct 5, 2017 PowerPC

lore
Share & tools
lore

Nicholas Piggin

author reviewer
#0 lore raw

PATCH 1/1 powerpc/powernv: Use early_radix_enabled in POWER9 tlb flush

This code is used at boot and machine checks, so it should be using early_radix_enabled() (which is usable any time).

---
 arch/powerpc/kernel/mce_power.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/kernel/mce_power.c +1 -1
index b76ca198e09c..d37e612050b5 100644
@@ -128,7 +128,7 @@ void __flush_tlb_power9(unsigned int action)
 {
 	unsigned int num_sets;
 
-	if (radix_enabled())
+	if (early_radix_enabled())
 		num_sets = POWER9_TLB_SETS_RADIX;
 	else
 		num_sets = POWER9_TLB_SETS_HASH;
Signature · 1 line
2.13.3
#1 lore raw

Nick,  I applied your patch = into linux kernel 4.13, rebuild it, installed it, then had a test, still ca= n not boot OS. System hung here, the same as before. Would you please have= a look? The system is going d= own NOW! Sent SIGTERM to all processes
Sent SIGKILL to all processes[  104.755810] kexec=5Fcore: Starting new kernel
[  126.157= 029744,5] OPAL: Switch to big-endian OS     Best Regards!
Meng Li
IBM Op= enPOWER Application Engineer     ----- Original message -----
From: Nicholas Piggin &l= t;[email protected]>
To: [email protected]
Cc: Nichola= s Piggin <[email protected]>, Jeremy Kerr <[email protected]>, Meng= YK Li <[email protected]>
Subject: [PATCH] powerpc/powernv: Use= early=5Fradix=5Fenabled in POWER9 tlb flush
Date: Wed, Sep 27, 2017 1:4= 6 PM
  This code is used at boot and machine checks, so it should be usingearly=5Fradix=5Fenabled() (which is usable any time).

Signed-off-by= : Nicholas Piggin <[email protected]>
---
 arch/powerpc/ke= rnel/mce=5Fpower.c | 2 +-

 1 file changed, 1 insertion(+), 1 deleti= on(-)
arch/powerpc/kernel/mce=5Fpower.c@@ -128,7 +128,7 @@ void =5F=5Fflush=5Ftlb=5Fpower9(unsigned int action)= renamed from ar= ch/powerpc/kernel/mce=5Fpower.c +0 -0
index b76ca198e09c..d37e612050b5 100644

 {
  unsigned int num=5Fsets;

- if (radix=5Fe= nabled())
+ if (early=5Fradix=5Fenabled())
  num=5Fsets =3D POWE= R9=5FTLB=5FSETS=5FRADIX;
  else
  num=5Fsets =3D POWER9=5FT= LB=5FSETS=5FHASH;
--
2.13.3