cleanup single_open usage in dma.c

PATCH New Jeff Muizelaar 1 participant 1 message Jan 16, 2004

lore

Share & tools

lore

Jeff Muizelaar

author

2004-01-16 03:22 UTC #0 lore raw

PATCH 1/1 cleanup single_open usage in dma.c

The attached patch lets the seq_file api take care of buffer allocation instead of doing it by hand.

-Jeff

kernel/dma.c +1 ~~-14~~

diff -ur linux-2.6.1-mm3/kernel/dma.c linux-2.6.1-mm3-dma-proc/kernel/dma.c
@@ -136,20 +136,7 @@
 
 static int proc_dma_open(struct inode *inode, struct file *file)
 {
-	char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
-	struct seq_file *m;
-	int res;
-
-	if (!buf)
-		return -ENOMEM;
-	res = single_open(file, proc_dma_show, NULL);
-	if (!res) {
-		m = file->private_data;
-		m->buf = buf;
-		m->size = PAGE_SIZE;
-	} else
-		kfree(buf);
-	return res;
+	return single_open(file, proc_dma_show, NULL);
 }
 
 static struct file_operations proc_dma_operations = {