Skip to contentSkip to conversation

clk: samsung: exynos4: Correct SRC_MFC register

PATCH New Seung-Woo Kim 3 participants 5 messages Nov 22, 2013 – Dec 30, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: samsung: exynos4: Correct SRC_MFC register

The SRC_MFC register was incorrect. This patch corrects it.

---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/clk/samsung/clk-exynos4.c +1 -1
index ad5ff50..1a7c1b9 100644
@@ -39,7 +39,7 @@
 #define SRC_TOP1		0xc214
 #define SRC_CAM			0xc220
 #define SRC_TV			0xc224
-#define SRC_MFC			0xcc28
+#define SRC_MFC			0xc228
 #define SRC_G3D			0xc22c
 #define E4210_SRC_IMAGE		0xc230
 #define SRC_LCD0		0xc234
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 clk: samsung: exynos4: Correct SRC_MFC register

Hi Seung-Woo,

Quoted 6 lines · On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:

The SRC_MFC register was incorrect. This patch corrects it.

---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Good catch.

I guess this could go as a fix for current rc, through clk-fixes. Mike, what do you think?

Best regards,
Tomasz

Applied
#2 lore raw

PATCH 1/1 clk: samsung: exynos4: Correct SRC_MFC register

In reply to Seung-Woo Kim
Quoted 13 lines · On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:

The SRC_MFC register was incorrect. This patch corrects it.

---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/clk/samsung/clk-exynos4.c +0 -0
index ad5ff50..1a7c1b9 100644

drivers/clk/samsung/clk-exynos4.c line 45

Quoted 8 lines
drivers/clk/samsung/clk-exynos4.c +1 -1
@@ -39,7 +39,7 @@
 #define SRC_TOP1		0xc214
 #define SRC_CAM			0xc220
 #define SRC_TV			0xc224
-#define SRC_MFC			0xcc28
+#define SRC_MFC			0xc228
 #define SRC_G3D			0xc22c
 #define E4210_SRC_IMAGE		0xc230
 #define SRC_LCD0		0xc234

Applied into samsung-clk fixes branch.

Best regards,
Tomasz

#3 lore raw

PATCH 1/1 clk: samsung: exynos4: Correct SRC_MFC register

Quoting Tomasz Figa (2013-12-18 06:54:30)

Quoted 8 lines · On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:
Quoted 7 lines

The SRC_MFC register was incorrect. This patch corrects it.

---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 16 lines
Quoted 6 lines
drivers/clk/samsung/clk-exynos4.c +0 -0
index ad5ff50..1a7c1b9 100644

drivers/clk/samsung/clk-exynos4.c line 45

Quoted 8 lines
drivers/clk/samsung/clk-exynos4.c +1 -1
@@ -39,7 +39,7 @@
 #define SRC_TOP1             0xc214
 #define SRC_CAM                      0xc220
 #define SRC_TV                       0xc224
-#define SRC_MFC                      0xcc28
+#define SRC_MFC                      0xc228
 #define SRC_G3D                      0xc22c
 #define E4210_SRC_IMAGE              0xc230
 #define SRC_LCD0             0xc234

Applied into samsung-clk fixes branch.

It's always nice when a fix for the -rc cycle includes a description of the user-visible regression that it fixes.

Regards,
Mike

Quoted 4 lines

Best regards,
Tomasz

#4 lore raw

PATCH 1/1 clk: samsung: exynos4: Correct SRC_MFC register

Quoted 26 lines · On Wednesday 18 of December 2013 20:23:10 Mike Turquette wrote:

Quoting Tomasz Figa (2013-12-18 06:54:30)

Quoted 8 lines · On Friday 22 of November 2013 14:21:08 Seung-Woo Kim wrote:
Quoted 7 lines

The SRC_MFC register was incorrect. This patch corrects it.

---
 drivers/clk/samsung/clk-exynos4.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 16 lines
Quoted 6 lines
drivers/clk/samsung/clk-exynos4.c +0 -0
index ad5ff50..1a7c1b9 100644

drivers/clk/samsung/clk-exynos4.c line 45

Quoted 8 lines
drivers/clk/samsung/clk-exynos4.c +1 -1
@@ -39,7 +39,7 @@
 #define SRC_TOP1             0xc214
 #define SRC_CAM                      0xc220
 #define SRC_TV                       0xc224
-#define SRC_MFC                      0xcc28
+#define SRC_MFC                      0xc228
 #define SRC_G3D                      0xc22c
 #define E4210_SRC_IMAGE              0xc230
 #define SRC_LCD0             0xc234

Applied into samsung-clk fixes branch.

Quoted 2 lines

It's always nice when a fix for the -rc cycle includes a description of the user-visible regression that it fixes.

I have updated the description when applying.

Best regards,
Tomasz