error?
Hi,
I noticed in the function 'linux-2.6/drivers/parisc/lba_pci.c:lba_pat_resources( )' the following lines:
---------------------------------------------------------------
case PAT_GMMIO:
r = &(lba_dev->hba.gmmio_space); r->name = "LBA GMMIO"; r->start = p->start; r->end = p->end; r->flags = IORESOURCE_MEM; r->parent = r->sibling = r->child = NULL; break; lba_dev->gmmio_base = p->start; break;
case PAT_NPIOP:
printk(KERN_WARNING MODULE_NAME
" range[%d] : ignoring NPIOP (0x%lx)\n",
i, p->start); break;
-------------------------------------------------------------------
Please note the extra lines after the 'break;'. The version of 'lba_pci.c' is 1.7. Seems to have happened due to oversight.
Thanks,
Naresh.
Quoted 8 lines · Naresh Kumar
r->end = p->end; r->flags = IORESOURCE_MEM; r->parent = r->sibling = r->child = NULL; break; lba_dev->gmmio_base = p->start; break;case
PAT_NPIOP:
Quoted 8 lines
printk(KERN_WARNING MODULE_NAME " range[%d] : ignoring NPIOP (0x%lx)\n", i, p->start);break;
-------------------------------------------------------------------Please note the extra lines after the 'break;'. The version of '
lba_pci.c' is 1.7. Seems to have happened due to oversight.
Those are "extra"?
The version of code in linux-2.4 CVS has:
case PAT_GMMIO:
printk(KERN_WARNING MODULE_NAME
" range[%d] : ignoring GMMIO (0x%lx)\n",
i, p->start);
lba_dev->gmmio_base = p->start;
break;The code you quoted is missing the "case PAT_GMMIO" and printk.
thanks,
grant
Quoted 20 lines · Grant Grundler
Quoted 8 lines · Naresh Kumar
r->end = p->end; r->flags = IORESOURCE_MEM; r->parent = r->sibling = r->child = NULL; break; lba_dev->gmmio_base = p->start; break;case
PAT_NPIOP:Quoted 8 lines
printk(KERN_WARNING MODULE_NAME " range[%d] : ignoring NPIOP (0x%lx)\n", i, p->start);break;
-------------------------------------------------------------------Please note the extra lines after the 'break;'. The version of '
lba_pci.c' is 1.7. Seems to have happened due to oversight.Those are "extra"?
The version of code in linux-2.4 CVS has:
Quoted 8 lines
case PAT_GMMIO: printk(KERN_WARNING MODULE_NAME " range[%d] : ignoring GMMIO (0x%lx)\n", i, p->start); lba_dev->gmmio_base = p->start; break;The code you quoted is missing the "case
PAT_GMMIO" and printk.
The bit he's referring to is:
Quoted 3 lines
break; lba_dev->gmmio_base = p->start; break;
which is clearly bogus.
Signature · 6 lines
"Next the statesmen will invent cheap lies, putting the blame upon the nation that is attacked, and every man will be glad of those conscience-soothing falsities, and will diligently study them, and refuse to examine any refutations of them; and thus he will by and by convince himself that the war is just, and will thank God for the better sleep he enjoys after this process of grotesque self-deception." -- Mark Twain
Grant,
I was referring to linux-2.6. There are two 'break' statements in 'case PAT_GMMIO:'. Removing the first 'break' will do.
Regards,
Naresh.
Quoted 13 lines
Those are "extra"?
The version of code in linux-2.4 CVS has:case PAT_GMMIO: printk(KERN_WARNING MODULE_NAME " range[%d] : ignoring GMMIO (0x%lx)\n", i, p->start); lba_dev->gmmio_base = p->start; break;The code you quoted is missing the "case
PAT_GMMIO" and printk.thanks,
grant