Skip to contentSkip to conversation

XFS: remove warning in xfs_log_recover, 2.6.2-rc2

PATCH New Michael Veeck 1 participant 1 message Jan 27, 2004 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 XFS: remove warning in xfs_log_recover, 2.6.2-rc2

Compiling the 2.6.2-rc2 kernel on my machine with allyesconfig and gcc 3.3.1 triggers the following warning:

CC fs/xfs/xfs_log_recover.o
fs/xfs/xfs_log_recover.c: In function `xlog_recover_reorder_trans':
fs/xfs/xfs_log_recover.c:1534: warning: `flags' might be used uninitialized in this function

I've added an "= 0" to the appropiate line which lets it cleanly compile now. Attached patch fixes the warning and is against 2.6.2-rc2. Apply with patch -p1 < patch-XFSwarning.

Best regards
Michael Veeck

fs/xfs/xfs_log_recover.c +1 -1
diff -Naur a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c
@@ -1531,7 +1531,7 @@
 	xlog_recover_item_t	*first_item, *itemq, *itemq_next;
 	xfs_buf_log_format_t	*buf_f;
 	xfs_buf_log_format_v1_t	*obuf_f;
-	ushort			flags;
+	ushort			flags = 0;
 
 	first_item = itemq = trans->r_itemq;
 	trans->r_itemq = NULL;

[PATCH] xfs has uninitialized flags-variable in xfs_log_recover. init it to 0. from [email protected]