Midlayer initiated START_UNIT

PATCH In review Brian King 3 participants 4 messages Jan 29, 2004 – Feb 17, 2004 SCSI

lore

Share & tools

lore

Brian King

author

2004-01-29 22:15 UTC #0 lore raw

PATCH 1/1 Midlayer initiated START_UNIT

James,

This is a patch to issue a START_UNIT command from the midlayer error handler. The ipr driver, which is currently out for review needs this to function properly. Any time the adapter gets reset, the disk array resources under the ipr adapter require another START_UNIT command. This causes problems with the current error handling and these devices get taken offline when this occurs.

This was being handled by the ipr driver itself, but Christoph did not like seeing a LLDD issuing commands to devices, hence the patch.

http://marc.theaimsgroup.com/?l=linux-scsi&m=107462193622673&w=2

Patch is against 2.6.2-rc2.

Thanks

Signature · 3 lines

Brian King
eServer Storage I/O
IBM Linux Technology Center

Sachin Mhatre (smhatre)

2004-02-17 07:36 UTC #1 lore raw

Has this patch been included in the linux 2.6.X kernel? This patch would also help the iscsi LLDD as it is also facing the same START_UNIT problem.
I would really appreciate any help on this matter.

Thanks,
Sachin

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Brian King
Sent: Friday, January 30, 2004 3:45 AM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] Midlayer initiated START_UNIT

James,

This was being handled by the ipr driver itself, but Christoph did not like seeing a LLDD issuing commands to devices, hence the patch.

http://marc.theaimsgroup.com/?l=linux-scsi&m=107462193622673&w=2

Patch is against 2.6.2-rc2.

Thanks

Signature · 8 lines

Brian King
eServer Storage I/O
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected] More majordomo info
at  http://vger.kernel.org/majordomo-info.html

Matthew Dharm

2004-02-17 08:04 UTC #2 lore raw

Umm... I hope that the issuing of START_UNIT will only occur in very narrowly defined cases.

If you just issue START_UNIT semi-arbitrarily, you'll break most USB devices.

Matt

Quoted 52 lines · Sachin Mhatre (smhatre)

Has this patch been included in the linux 2.6.X kernel? This patch would also help the iscsi LLDD as it is also facing the same START_UNIT problem.
I would really appreciate any help on this matter.
Thanks,
Sachin
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Brian King
Sent: Friday, January 30, 2004 3:45 AM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] Midlayer initiated START_UNIT
James,
This is a patch to issue a START_UNIT command from the midlayer error handler. The ipr driver, which is currently out for review needs this to function properly. Any time the adapter gets reset, the disk array resources under the ipr adapter require another START_UNIT command. This causes problems with the current error handling and these devices get taken offline when this occurs.
This was being handled by the ipr driver itself, but Christoph did not like seeing a LLDD issuing commands to devices, hence the patch.
http://marc.theaimsgroup.com/?l=linux-scsi&m=107462193622673&w=2
Patch is against 2.6.2-rc2.
Thanks
Signature · 13 lines
Brian King
eServer Storage I/O
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected] More majordomo info
at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Signature · 6 lines

Matthew Dharm                              Home: [email protected] 
Maintainer, Linux USB Mass Storage Driver

I'm a pink gumdrop! How can anything be worse?!!
					-- Erwin
User Friendly, 10/4/1998

Brian King

author

2004-02-17 14:27 UTC #3 lore raw

Quoted 5 lines · Matthew Dharm

Umm... I hope that the issuing of START_UNIT will only occur in very narrowly defined cases.
If you just issue START_UNIT semi-arbitrarily, you'll break most USB devices.

And the patch allows for this. With the patch, devices will only get this new behavior if a flag gets set in their scsi_device struct by the LLD in its slave_configure routine.

-Brian

Quoted 56 lines · Sachin Mhatre (smhatre)

Quoted 53 lines
Has this patch been included in the linux 2.6.X kernel? This patch would also help the iscsi LLDD as it is also facing the same START_UNIT problem.
I would really appreciate any help on this matter.
Thanks,
Sachin
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Brian King
Sent: Friday, January 30, 2004 3:45 AM
To: [email protected]
Cc: [email protected]
Subject: [PATCH] Midlayer initiated START_UNIT
James,
This is a patch to issue a START_UNIT command from the midlayer error handler. The ipr driver, which is currently out for review needs this to function properly. Any time the adapter gets reset, the disk array resources under the ipr adapter require another START_UNIT command. This causes problems with the current error handling and these devices get taken offline when this occurs.
This was being handled by the ipr driver itself, but Christoph did not like seeing a LLDD issuing commands to devices, hence the patch.
http://marc.theaimsgroup.com/?l=linux-scsi&m=107462193622673&w=2
Patch is against 2.6.2-rc2.
Thanks
Signature · 13 lines
Brian King
eServer Storage I/O
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected] More majordomo info
at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Signature · 3 lines

Brian King
eServer Storage I/O
IBM Linux Technology Center