Skip to contentSkip to conversation

dovecot: rename downloaded file name

PATCH In review Wang Mingyu 3 participants 5 messages Apr 13

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dovecot: rename downloaded file name

From: Wang Mingyu <[email protected]>

Add downloadfilename to SRC_URI to ensure the downloaded file has a consistent local name, avoiding potential future filename conflicts.

---
 meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +1 -1
index a6b78ea781..9b3666863c 100644
@@ -9,7 +9,7 @@ SECTION = "mail"
 LICENSE = "LGPL-2.1-only & MIT & Unicode-3.0 & BSD-3-Clause & PD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=cb805cc6bdb95ba8fc2398a55fd50877"
 
-SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz \
+SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz;downloadfilename=${BP}.tar.gz \
            file://0001-configure.ac-convert-AC_TRY_RUN-to-AC_TRY_LINK-state.patch \
            file://dovecot.service \
            file://dovecot.socket \
Signature · 1 line
2.43.0
#1 lore raw
Quoted 16 lines · wangmy via lists.openembedded.org

From: Wang Mingyu <[email protected]>

Add downloadfilename to SRC_URI to ensure the downloaded file has a consistent local name, avoiding potential future filename conflicts.

---
 meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +0 -0
index a6b78ea781..9b3666863c 100644

meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb SECTION = "mail" · line 12

Quoted 5 lines
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +1 -1
@@ -9,7 +9,7 @@ SECTION = "mail"
 LICENSE = "LGPL-2.1-only & MIT & Unicode-3.0 & BSD-3-Clause & PD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=cb805cc6bdb95ba8fc2398a55fd50877"
 
-SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz \
+SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz;downloadfilename=${BP}.tar.gz \

dovecot-${PV}.tar.gz is ${BP}.tar.gz, isn't it?

To avoid the issue with modified tarball I was assuming something like:

# 2.4.3 tarball was recreated, see
# https://dovecot.org/mailman3/archives/list/[email protected]/thread/V37BEIZTNQODMWIHMTQK5DSOM5RDJ7NF/
SRC_URI = "https://dovecot.org/releases/2.4/${BP}.tar.gz;downloadfilename=${BP}-recreated.tar.gz \

Quoted 15 lines
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +0 -1
            file://0001-configure.ac-convert-AC_TRY_RUN-to-AC_TRY_LINK-state.patch \
            file://dovecot.service \
            file://dovecot.socket \
--

2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#126264): https://lists.openembedded.org/g/openembedded-devel/message/126264
Mute This Topic: https://lists.openembedded.org/mt/118798933/3617156
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw
Quoted 29 lines · Martin Jansa via lists.openembedded.org
Quoted 6 lines · wangmy via lists.openembedded.org

From: Wang Mingyu <[email protected]>

Add downloadfilename to SRC_URI to ensure the downloaded file has a consistent local name, avoiding potential future filename conflicts.

Review

Quoted 6 lines
---
 meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb

meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb SECTION = "mail" · line 12

Quoted 9 lines

index a6b78ea781..9b3666863c 100644

meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +1 -1
@@ -9,7 +9,7 @@ SECTION = "mail"
 LICENSE = "LGPL-2.1-only & MIT & Unicode-3.0 & BSD-3-Clause & PD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=cb805cc6bdb95ba8fc2398a55fd50877"
 
-SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz \
+SRC_URI = "

https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz;downloadfilename=${BP}.tar.gz
\

dovecot-${PV}.tar.gz is ${BP}.tar.gz, isn't it?

Quoted 9 lines

To avoid the issue with modified tarball I was assuming something like:

# 2.4.3 tarball was recreated, see
#
https://dovecot.org/mailman3/archives/list/[email protected]/thread/V37BEIZTNQODMWIHMTQK5DSOM5RDJ7NF/
SRC_URI = "
https://dovecot.org/releases/2.4/${BP}.tar.gz;downloadfilename=${BP}-recreated.tar.gz
\

I think the problem is that we might have to purge the old tarball since upstream has regenerated it with same name+version

Quoted 24 lines
Quoted 3 lines

file://0001-configure.ac-convert-AC_TRY_RUN-to-AC_TRY_LINK-state.patch \

Quoted 8 lines
            file://dovecot.service \
            file://dovecot.socket \

--
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#126269):
https://lists.openembedded.org/g/openembedded-devel/message/126269
Mute This Topic: https://lists.openembedded.org/mt/118798933/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#3 lore raw
Quoted 33 lines · Khem Raj
Quoted 29 lines · Martin Jansa via lists.openembedded.org
Quoted 16 lines · wangmy via lists.openembedded.org

From: Wang Mingyu <[email protected]>

Add downloadfilename to SRC_URI to ensure the downloaded file has a consistent local name, avoiding potential future filename conflicts.

---
 meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +0 -0
index a6b78ea781..9b3666863c 100644

meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb SECTION = "mail" · line 12

Quoted 5 lines
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +1 -1
@@ -9,7 +9,7 @@ SECTION = "mail"
 LICENSE = "LGPL-2.1-only & MIT & Unicode-3.0 & BSD-3-Clause & PD"
 LIC_FILES_CHKSUM = "file://COPYING;md5=cb805cc6bdb95ba8fc2398a55fd50877"
 
-SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz \
+SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz;downloadfilename=${BP}.tar.gz \

dovecot-${PV}.tar.gz is ${BP}.tar.gz, isn't it?

To avoid the issue with modified tarball I was assuming something like:

Quoted 7 lines
Quoted 4 lines

# 2.4.3 tarball was recreated, see
# https://dovecot.org/mailman3/archives/list/[email protected]/thread/V37BEIZTNQODMWIHMTQK5DSOM5RDJ7NF/
SRC_URI = "https://dovecot.org/releases/2.4/${BP}.tar.gz;downloadfilename=${BP}-recreated.tar.gz \

I think the problem is that we might have to purge the old tarball since upstream has regenerated it with same name+version

That's why I've asked Wagmy to add downloadfilename so that it uses different filename then the original tarball with not matching checksum. Then we don't need to manually purge anything, even allows to re-build the older metadata still using the old checksum, right?

Cheers,

Quoted 21 lines
Quoted 21 lines
Quoted 7 lines
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +0 -1
            file://0001-configure.ac-convert-AC_TRY_RUN-to-AC_TRY_LINK-state.patch \
            file://dovecot.service \
            file://dovecot.socket \
--
Quoted 5 lines

2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#126269): https://lists.openembedded.org/g/openembedded-devel/message/126269
Mute This Topic: https://lists.openembedded.org/mt/118798933/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#4 lore raw
Quoted 40 lines · Martin Jansa
Quoted 39 lines · Khem Raj
Quoted 33 lines · Martin Jansa via lists.openembedded.org
Quoted 16 lines · wangmy via lists.openembedded.org

From: Wang Mingyu <[email protected]>

Add downloadfilename to SRC_URI to ensure the downloaded file has a consistent local name, avoiding potential future filename conflicts.

---
  meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +0 -0
index a6b78ea781..9b3666863c 100644

meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb SECTION = "mail" · line 12

Quoted 5 lines
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +1 -1
@@ -9,7 +9,7 @@ SECTION = "mail"
  LICENSE = "LGPL-2.1-only & MIT & Unicode-3.0 & BSD-3-Clause & PD"
  LIC_FILES_CHKSUM = "file://COPYING;md5=cb805cc6bdb95ba8fc2398a55fd50877"
 
-SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz \
+SRC_URI = "https://dovecot.org/releases/2.4/dovecot-${PV}.tar.gz;downloadfilename=${BP}.tar.gz \

dovecot-${PV}.tar.gz is ${BP}.tar.gz, isn't it?

To avoid the issue with modified tarball I was assuming something like:

# 2.4.3 tarball was recreated, see
# https://dovecot.org/mailman3/archives/list/[email protected]/thread/V37BEIZTNQODMWIHMTQK5DSOM5RDJ7NF/
SRC_URI = "https://dovecot.org/releases/2.4/${BP}.tar.gz;downloadfilename=${BP}-recreated.tar.gz \

Quoted 7 lines
Quoted 1 line

I think the problem is that we might have to purge the old tarball since upstream has regenerated it with same name+version

That's why I've asked Wagmy to add downloadfilename so that it uses different filename then the original tarball with not matching checksum. Then we don't need to manually purge anything, even allows to re-build the older metadata still using the old checksum, right?

yeah I guess thats reasonable.

Quoted 23 lines

Cheers,

Quoted 21 lines
Quoted 21 lines
Quoted 7 lines
meta-networking/recipes-support/dovecot/dovecot_2.4.3.bb +0 -1
             file://0001-configure.ac-convert-AC_TRY_RUN-to-AC_TRY_LINK-state.patch \
             file://dovecot.service \
             file://dovecot.socket \
--
Quoted 5 lines

2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#126269): https://lists.openembedded.org/g/openembedded-devel/message/126269
Mute This Topic: https://lists.openembedded.org/mt/118798933/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-