Minor cross-compile issues
PATCH 1/1 Minor cross-compile issues
Attached are 2 patches
asm-boot.patch - Fixes include path for build.c so that it finds asm/boot.h. /usr/include/asm/boot.h may not be present when cross-compiling on a non-Linux machine.
shell.patch - Use $(CONFIG_SHELL) instead of sh.
Pratik.
===== arch/i386/boot/Makefile 1.28 vs edited =====
arch/i386/boot/Makefile +2 -0
@@ -31,6 +31,8 @@ host-progs := tools/build +HOSTCFLAGS_build.o := -I$(TOPDIR)/include + # --------------------------------------------------------------------------- $(obj)/zImage: IMAGE_OFFSET := 0x1000
===== init/Makefile 1.26 vs edited =====
init/Makefile +1 -1
@@ -23,4 +23,4 @@ include/linux/compile.h: FORCE @echo ' CHK $@' - @sh $(srctree)/scripts/mkcompile_h $@ "$(UTS_MACHINE)" "$(CONFIG_SMP)" "$(CC) $(CFLAGS)" + @$(CONFIG_SHELL) $(srctree)/scripts/mkcompile_h $@ "$(UTS_MACHINE)" "$(CONFIG_SMP)" "$(CC) $(CFLAGS)"
Quoted 5 lines · Pratik Solanki
Attached are 2 patches
asm-boot.patch - Fixes include path for
build.cso that it findsasm/boot.h./usr/include/asm/boot.hmay not be present when cross-compiling on a non-Linux machine.
OK - but see minor comemnt.
Quoted 1 line
shell.patch - Use $(CONFIG_SHELL) instead of sh.
OK
Sam
arch/i386/boot/Makefile line 34
Quoted 8 lines
=====
arch/i386/boot/Makefile1.28 vs edited =====arch/i386/boot/Makefile +1
-0@@ -31,6 +31,8 @@ host-progs := tools/build +HOSTCFLAGS_build.o := -I$(TOPDIR)/include
Do not use absolute paths here.
arch/i386/boot/Makefile line 35
Quoted 1 line
arch/i386/boot/Makefile +1
-0+HOSTCFLAGS_build.o := -Iinclude
Is the preferred way to do it.
Sam
Quoted 36 lines · Sam Ravnborg
Quoted 5 lines · Pratik Solanki
Attached are 2 patches
asm-boot.patch - Fixes include path for
build.cso that it findsasm/boot.h./usr/include/asm/boot.hmay not be present when cross-compiling on a non-Linux machine.OK - but see minor comemnt.
Quoted 3 lines
shell.patch - Use $(CONFIG_SHELL) instead of sh.
OK
Sam
Quoted 10 lines
=====
arch/i386/boot/Makefile1.28 vs edited =====arch/i386/boot/Makefile +0
-0@@ -31,6 +31,8 @@host-progs :=
tools/build+HOSTCFLAGS_build.o := -I$(TOPDIR)/include
Do not use absolute paths here.
Quoted 6 lines
Quoted 3 lines
+HOSTCFLAGS_build.o := -Iinclude
Is the preferred way to do it.
Thanks Sam. Would you be checking in your proposed change or should I send a new patch?
Pratik.
Quoted 3 lines · Pratik Solanki
Thanks Sam. Would you be checking in your proposed change or should I send a new patch?
Please send an updated patch to Andrew Morton.
Sam
Andrew,
Based on Sam's suggestion, here's the updated patch.
Pratik.
Quoted 12 lines · Sam Ravnborg
Quoted 3 lines · Pratik Solanki
Thanks Sam. Would you be checking in your proposed change or should I send a new patch?
Please send an updated patch to Andrew Morton.
Sam
===== arch/i386/boot/Makefile 1.28 vs edited =====
arch/i386/boot/Makefile +2 -0
@@ -31,6 +31,8 @@ host-progs := tools/build +HOSTCFLAGS_build.o := -Iinclude + # --------------------------------------------------------------------------- $(obj)/zImage: IMAGE_OFFSET := 0x1000