ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

RFC PATCH New Alim Akhtar 4 participants 8 messages Oct 19, 2015 – Oct 21, 2015

Subsystems (2)

Arm (32-bit) Arm Samsung Exynos

lore

Share & tools

lore

Alim Akhtar

author reviewer

2015-10-19 10:48 UTC #0 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.

Signed-off-by Alim Akhtar <[email protected]>

---
Every time I build exynos_defconfig, I need to manually change RAM_SIZE to match my ramdisk image size. I am not sure what is the best ramdisk size might be, but bumping it to 64K might be a reasonable one.

 arch/arm/configs/exynos_defconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/configs/exynos_defconfig +1 -1

index 3349713e6c63..e692aaa2cb8c 100644
@@ -52,7 +52,7 @@ CONFIG_CMA_SIZE_MBYTES=64
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_CRYPTOLOOP=y
 CONFIG_BLK_DEV_RAM=y
-CONFIG_BLK_DEV_RAM_SIZE=8192
+CONFIG_BLK_DEV_RAM_SIZE=65536
 CONFIG_SCSI=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_SG=y

Signature · 1 line

1.7.10.4

Javier Martinez Canillas

2015-10-19 11:48 UTC #1 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

Hello Alim,

Quoted 6 lines · Alim Akhtar

CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.
Signed-off-by Alim Akhtar <[email protected]>
---

I agree that 8KiB is too small and that should be bumped, I'm also not sure what the best size would be but 64KiB sounds reasonable to me. So for this patch:

Reviewed-by Javier Martinez Canillas <[email protected]>

Quoted 4 lines

Every time I build exynos_defconfig, I need to manually change RAM_SIZE to match my ramdisk image size. I am not sure what is the best ramdisk size might be, but bumping it to 64K might be a reasonable one.

In case you are interested, I got some stats by doing grep on the ARM defconfigs using this [0]. Of course the sizes depends on the platform but just to have an idea about what sizes are more popular than others.

SIZE COUNT
1024 17
8192 43
10240 1
16384 20
20000 25
32768 36
65536 15

[0]: http://hastebin.com/buqukimede.bash

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Russell King - ARM Linux

2015-10-19 11:51 UTC #2 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

Quoted 7 lines · Javier Martinez Canillas

Hello Alim,
Quoted 4 lines · Alim Akhtar
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.

Quoted 6 lines

Quoted 2 lines
Signed-off-by Alim Akhtar <[email protected]>
---
I agree that 8KiB is too small and that should be bumped, I'm also not sure what the best size would be but 64KiB sounds reasonable to me. So for this patch:

It's _not_ 8KiB or 64KiB.

config BLK_DEV_RAM_SIZE
int "Default RAM disk size (kbytes)"

It's 8MiB or 64MiB - the value you place here is in units of 1024 bytes.

Signature · 2 lines

FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Alim Akhtar

author reviewer

2015-10-19 11:53 UTC #3 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

Hi Russell,

Quoted 15 lines · Russell King - ARM Linux

Quoted 7 lines · Javier Martinez Canillas
Hello Alim,
Quoted 4 lines · Alim Akhtar
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Alim Akhtar <[email protected]>
---
I agree that 8KiB is too small and that should be bumped, I'm also not sure what the best size would be but 64KiB sounds reasonable to me. So for this patch:

Quoted 7 lines

It's _not_ 8KiB or 64KiB.
config BLK_DEV_RAM_SIZE
int "Default RAM disk size (kbytes)"
It's 8MiB or 64MiB - the value you place here is in units of 1024 bytes.

Thanks for correcting, will correct it.

Javier Martinez Canillas

2015-10-19 12:06 UTC #4 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

In reply to Russell King - ARM Linux

Hello Russell,

Quoted 15 lines · Russell King - ARM Linux

Quoted 7 lines · Javier Martinez Canillas
Hello Alim,
Quoted 4 lines · Alim Akhtar
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Alim Akhtar <[email protected]>
---
I agree that 8KiB is too small and that should be bumped, I'm also not sure what the best size would be but 64KiB sounds reasonable to me. So for this patch:

Quoted 7 lines

It's _not_ 8KiB or 64KiB.
config BLK_DEV_RAM_SIZE
int "Default RAM disk size (kbytes)"
It's 8MiB or 64MiB - the value you place here is in units of 1024 bytes.

Err, right. I got confused by the patch's commit message, sorry about that and thanks for the clarification.

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Alim Akhtar

author reviewer

2015-10-19 11:55 UTC #5 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

In reply to Javier Martinez Canillas

Hi Javier,

Quoted 7 lines · Javier Martinez Canillas

Hello Alim,
Quoted 4 lines · Alim Akhtar
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.

Quoted 9 lines

Quoted 2 lines
Signed-off-by Alim Akhtar <[email protected]>
---
I agree that 8KiB is too small and that should be bumped, I'm also not sure what the best size would be but 64KiB sounds reasonable to me. So for this patch:
Reviewed-by Javier Martinez Canillas <[email protected]>

Thanks

Quoted 9 lines

Quoted 4 lines
Every time I build exynos_defconfig, I need to manually change RAM_SIZE to match my ramdisk image size. I am not sure what is the best ramdisk size might be, but bumping it to 64K might be a reasonable one.
In case you are interested, I got some stats by doing grep on the ARM defconfigs using this [0]. Of course the sizes depends on the platform but just to have an idea about what sizes are more popular than others.

Quoted 9 lines

SIZE COUNT
1024 17
8192 43
10240 1
16384 20
20000 25
32768 36
65536 15

This is informative.

Quoted 4 lines

[0]: http://hastebin.com/buqukimede.bash
Best regards,

Arnd Bergmann

2015-10-19 13:22 UTC #6 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

In reply to Alim Akhtar

Quoted 10 lines · On Monday 19 October 2015 16:18:35 Alim Akhtar wrote:

Spam Status: CRM114
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.
Signed-off-by Alim Akhtar <[email protected]>
---
Every time I build exynos_defconfig, I need to manually change RAM_SIZE to match my ramdisk image size. I am not sure what is the best ramdisk size might be, but bumping it to 64K might be a reasonable one.

Is there still a reason to use ramdisks these days? If 8MB is not enough to have a useful initrd, that might mean that everyone else uses initramfs and you should just do the same thing?

Then we can also remove this option here.

Arnd

Alim Akhtar

author reviewer

2015-10-21 04:56 UTC #7 lore raw

RFC PATCH 1/1 ARM: exynos_defconfig: Increase CONFIG_BLK_DEV_RAM_SIZE to 64K

Hi Arnd

Quoted 12 lines · Arnd Bergmann

Quoted 10 lines · On Monday 19 October 2015 16:18:35 Alim Akhtar wrote:
Spam Status: CRM114
CONFIG_BLK_DEV_RAM_SIZE is currently set to 8K, which is a bit on the smaller side, lets bump it up to 64K so that a bigger RAM_DISK can be used with defconfig.
Signed-off-by Alim Akhtar <[email protected]>
---
Every time I build exynos_defconfig, I need to manually change RAM_SIZE to match my ramdisk image size. I am not sure what is the best ramdisk size might be, but bumping it to 64K might be a reasonable one.

Quoted 4 lines

Is there still a reason to use ramdisks these days? If 8MB is not enough to have a useful initrd, that might mean that everyone else uses initramfs and you should just do the same thing?

There is not specific reason to still use ramdisks, but I feel till we remove this config, lets modify it to be used by few like me. I am ok with either way.
Thanks

Quoted 4 lines

Then we can also remove this option here.
Arnd