:/proc/fs/nfsd/
PATCH 1/1 :/proc/fs/nfsd/
Hi,
Kernel Version: 2.6.3
Even if NFSD is not selected, the proc entry /proc/fs/nfsd is getting created.
The following patch fixes it.
Pls apply.
/Raj
fs/proc/root.c +4 -0
@@ -65,7 +65,11 @@ void __init proc_root_init(void)#endif proc_root_fs =proc_mkdir ("fs" ,0 ); proc_root_driver =proc_mkdir ("driver" ,0 ); + +#if defined(CONFIG_NFSD ) || defined(CONFIG_NFSD_MODULE )proc_mkdir ("fs/nfsd" ,0 );/* somewhere for the nfsd filesystem to be mounted */ +#endif +#if defined(CONFIG_SUN_OPENPROMFS ) || defined(CONFIG_SUN_OPENPROMFS_MODULE )/* just give it a mountpoint */ proc_mkdir ("openprom" ,0 );
Quoted 5 lines · On Friday March 5, [email protected] wrote:
Hi,
Kernel Version: 2.6.3
Even if NFSD is not selected, the proc entry/proc/fs/nfsdis getting created.
Is it a problem??
Quoted 2 lines
The following patch fixes it.
Does it need fixing??
If you remove this, then people who compile a kernel without nfsd support, and then later decide to compile an nfsd module and load it, will not be able to mount the nfsd filesystem at the right place.
You might say "that won't happen", but it does, and has. You might say "they shouldn't do that", and maybe they shouldn't. But it still causes a support burden on the mailing list.
I think it is a very small cost, and a measurable gain, to leave it there.
Do you really think otherwise?
NeilBRown
Quoted 18 lines
Pls apply.
/Raj
fs/proc/root.c +4
-0@@ -65,7 +65,11 @@ void __init proc_root_init(void)#endif proc_root_fs =proc_mkdir ("fs" ,0 ); proc_root_driver =proc_mkdir ("driver" ,0 ); + +#if defined(CONFIG_NFSD ) || defined(CONFIG_NFSD_MODULE )proc_mkdir ("fs/nfsd" ,0 );/* somewhere for the nfsd filesystem to be mounted */ +#endif +#if defined(CONFIG_SUN_OPENPROMFS ) || defined(CONFIG_SUN_OPENPROMFS_MODULE )/* just give it a mountpoint */ proc_mkdir ("openprom" ,0 );
Quoted 13 lines · Neil Brown
Quoted 6 lines · On Friday March 5, [email protected] wrote:
Hi,
Kernel Version: 2.6.3
Even if NFSD is not selected, the proc entry/proc/fs/nfsdis getting created.Is it a problem??
Theoritically no, but behavior wise , yes.
Quoted 6 lines
Quoted 5 lines
The following patch fixes it.
Quoted 7 lines
Does it need fixing??
If you remove this, then people who compile a kernel without nfsd support, and then later decide to compile an nfsd module and load it, will not be able to mount the nfsd filesystem at the right place.
I guess choosing nfsd either builtin or as a module will cause a rebuild of some components of the main kernel and hence a reboot is anyway need. Pls correct me if i am wrong.
Quoted 30 lines
Quoted 12 lines
Pls apply.
/Raj
fs/proc/root.c +0
-0@@ -65,7 +65,11 @@ void __init proc_root_init(void)#endif fs/proc/root.c void __init proc_root_init(void) · line 75
Quoted 10 lines
fs/proc/root.c +4
-0proc_root_fs =proc_mkdir ("fs" ,0 ); proc_root_driver =proc_mkdir ("driver" ,0 ); + +#if defined(CONFIG_NFSD ) || defined(CONFIG_NFSD_MODULE )proc_mkdir ("fs/nfsd" ,0 );/* somewhere for the nfsd filesystem to be mounted */ +#endif +#if defined(CONFIG_SUN_OPENPROMFS ) || defined(CONFIG_SUN_OPENPROMFS_MODULE )/* just give it a mountpoint */ proc_mkdir ("openprom" ,0 );-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Quoted 10 lines · Raj
Neil Brown wrote:
...Quoted 7 lines
Does it need fixing??
If you remove this, then people who compile a kernel without nfsd support, and then later decide to compile an nfsd module and load it, will not be able to mount the nfsd filesystem at the right place.
Quoted 3 lines
I guess choosing nfsd either builtin or as a module will cause a rebuild of some components of the main kernel and hence a
reboot is anyway need. Pls correct me if i am wrong.
You are wrong.
If choosing nfsd as a module, no component of the main kernel needs to be changed to load the module on i386.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed