2.6.5-mm1
CC arch/x86_64/kernel/setup.oarch/x86_64/kernel/setup.c:258: warning: initialization from incompatible pointer type arch/x86_64/kernel/setup.c: In function `setup_arch':arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared (first use in this function) arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is reported only once arch/x86_64/kernel/setup.c:411: error: for each function it appears in.)
make[1]: *** [arch/x86_64/kernel/setup.o] Error 1
make: *** [arch/x86_64/kernel] Error 2
-------------------------------------------------------------------strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE);
Regards
Sid.
Signature · 2 lines
Sid Boyce .... Hamradio G3VBV and keen Flyer Linux Only Shop.
Quoted 5 lines · Sid Boyce
CC
arch/x86_64/kernel/setup.oarch/x86_64/kernel/setup.c:258: warning: initialization from incompatible pointer typearch/x86_64/kernel/setup.c: In function `setup_arch':arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared
Quoted 8 lines
(first use in this function)
arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is reported only oncearch/x86_64/kernel/setup.c:411: error: for each function it appears in.) make[1]: *** [arch/x86_64/kernel/setup.o] Error 1
make: *** [arch/x86_64/kernel] Error 2
-------------------------------------------------------------------strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE);
Yes, something like this is needed, on top of Rusty's early_param patch:
include/linux/init.h renamed from include/linux/init.h~fix-rusty +1 -0
@@ -143,6 +143,7 @@ extern void setup_arch(void);/* Relies on saved_command_line being set */ void __init parse_early_options (void ); +extern char saved_command_line[];#endif /* __ASSEMBLY__ */ /**
Assuming that is, that arch/x86_64/kernel/setup.c has #include <linux/init.h>, which I assume it does.
Signature · 2 lines
Tom Rini http://gate.crashing.org/~trini/
Quoted 30 lines · Tom Rini
Quoted 12 lines · Sid Boyce
CC
arch/x86_64/kernel/setup.oarch/x86_64/kernel/setup.c:258: warning: initialization from incompatible pointer typearch/x86_64/kernel/setup.c: In function `setup_arch':arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared (first use in this function)arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is reported only oncearch/x86_64/kernel/setup.c:411: error: for each function it appears in.)
make[1]: *** [arch/x86_64/kernel/setup.o] Error 1
make: *** [arch/x86_64/kernel] Error 2
-------------------------------------------------------------------strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE);Yes, something like this is needed, on top of Rusty's
early_parampatch:
diff -puNinclude/linux/init.h~fix-rustyinclude/linux/init.hinclude/linux/init.h renamed from include/linux/init.h~fix-rusty +1
-0@@ -143,6 +143,7 @@ extern void setup_arch(void);/* Relies on saved_command_line being set */ void __init parse_early_options (void ); +extern char saved_command_line[];#endif /* __ASSEMBLY__ */ /**
Quoted 5 lines
Assuming that is, that
arch/x86_64/kernel/setup.chas #include <linux/init.h>, which I assume it does.
That fixes it.
Regards
Sid.
Signature · 2 lines
Sid Boyce .... Hamradio G3VBV and keen Flyer Linux Only Shop.
This is the first kernel since 2.6.5-rc2 to have booted without locking up on the laptop. Regards
Sid.
Quoted 35 lines · Tom Rini
Quoted 12 lines · Sid Boyce
CC
arch/x86_64/kernel/setup.oarch/x86_64/kernel/setup.c:258: warning: initialization from incompatible pointer typearch/x86_64/kernel/setup.c: In function `setup_arch':arch/x86_64/kernel/setup.c:411: error: `saved_command_line' undeclared (first use in this function)arch/x86_64/kernel/setup.c:411: error: (Each undeclared identifier is reported only oncearch/x86_64/kernel/setup.c:411: error: for each function it appears in.)
make[1]: *** [arch/x86_64/kernel/setup.o] Error 1
make: *** [arch/x86_64/kernel] Error 2
-------------------------------------------------------------------strlcpy(saved_command_line, early_command_line, COMMAND_LINE_SIZE);Yes, something like this is needed, on top of Rusty's
early_parampatch:
diff -puNinclude/linux/init.h~fix-rustyinclude/linux/init.hinclude/linux/init.h renamed from include/linux/init.h~fix-rusty +1
-0@@ -143,6 +143,7 @@ extern void setup_arch(void);/* Relies on saved_command_line being set */ void __init parse_early_options (void ); +extern char saved_command_line[];#endif /* __ASSEMBLY__ */ /** Assuming that is, that
arch/x86_64/kernel/setup.chas #include <linux/init.h>, which I assume it does.
Signature · 2 lines
Sid Boyce .... Hamradio G3VBV and keen Flyer Linux Only Shop.