Skip to contentSkip to conversation

video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

PATCH In review SF Markus Elfring 3 participants 3 messages Nov 27, 2017 – Mar 28, 2018

Subsystems (3)
Kernel janitors Framebuffer layer Freescale diu framebuffer driver
lore
Share & tools
lore

SF Markus Elfring

author
#0 lore raw

PATCH 1/1 video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

From: Markus Elfring <[email protected]>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by Markus Elfring <[email protected]>
---
 drivers/video/fbdev/fsl-diu-fb.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/video/fbdev/fsl-diu-fb.c +1 -5
index 25abbcf38913..1bfd13cbd4e3 100644
@@ -1960,12 +1960,8 @@ static int __init fsl_diu_init(void)
 
 	of_node_put(np);
 	coherence_data = vmalloc(coherence_data_size);
-	if (!coherence_data) {
-		pr_err("fsl-diu-fb: could not allocate coherence data "
-		       "(size=%zu)\n", coherence_data_size);
+	if (!coherence_data)
 		return -ENOMEM;
-	}
-
 #endif
 
 	ret = platform_driver_register(&fsl_diu_driver);
Signature · 1 line
2.15.0
#2 lore raw
Quoted 11 lines · Timur Tabi
Quoted 8 lines · SF Markus Elfring

From: Markus Elfring<[email protected]>
Date: Mon, 27 Nov 2017 09:56:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by Markus Elfring<[email protected]>
Acked-by Timur Tabi <[email protected]>

Patch queued for 4.17, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics