Skip to contentSkip to conversation

MAINTAINERS: Split Audio section

PATCH In review Philippe Mathieu-Daudé 3 participants 11 messages Aug 16, 2021 – Aug 18, 2021

lore
Share & tools
lore
#0 lore raw

cover MAINTAINERS: Split Audio section

Split the current 'Audio' entry in multiple ones, allowing developers with different interests to add their contact to the relevant entries.

Philippe Mathieu-Daudé (3):
MAINTAINERS: Split Audio backends VS frontends
MAINTAINERS: Remove SPICE from Audio backends section
MAINTAINERS: Split Audio backends sections

 MAINTAINERS | 61 +++++++++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 54 insertions(+), 7 deletions(-)
Signature · 1 line
2.31.1
#1 lore raw

PATCH 1/3 MAINTAINERS: Split Audio backends VS frontends

---
 MAINTAINERS | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)
MAINTAINERS +11 -7
index 6b3697962c1..9ec6baa7e4c 100644
@@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c
 
 Devices
 -------
+Overall Audio frontends
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: hw/audio/
+F: include/hw/audio/
+F: tests/qtest/ac97-test.c
+F: tests/qtest/es1370-test.c
+F: tests/qtest/intel-hda-test.c
+F: tests/qtest/fuzz-sb16-test.c
+
 Xilinx CAN
 M: Vikram Garhwal <[email protected]>
 M: Francisco Iglesias <[email protected]>
@@ -2256,17 +2266,11 @@ F: include/net/can_*.h
 
 Subsystems
 ----------
-Audio
+Overall Audio backends
 M: Gerd Hoffmann <[email protected]>
 S: Odd Fixes
 F: audio/
-F: hw/audio/
-F: include/hw/audio/
 F: qapi/audio.json
-F: tests/qtest/ac97-test.c
-F: tests/qtest/es1370-test.c
-F: tests/qtest/intel-hda-test.c
-F: tests/qtest/fuzz-sb16-test.c
 
 Block layer core
 M: Kevin Wolf <[email protected]>
Signature · 1 line
2.31.1
#2 lore raw

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Quoted 13 lines · On Montag, 16. August 2021 21:10:12 CEST Philippe Mathieu-Daudé wrote:
---
 MAINTAINERS | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)
MAINTAINERS +0 -0
index 6b3697962c1..9ec6baa7e4c 100644
@@ -1660,6 +1660,16 @@ F: hw/net/opencores_eth.c
 
 Devices
 -------

MAINTAINERS F: hw/net/opencores_eth.c · line 1672

Quoted 10 lines
MAINTAINERS +10 -0
+Overall Audio frontends
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: hw/audio/
+F: include/hw/audio/
+F: tests/qtest/ac97-test.c
+F: tests/qtest/es1370-test.c
+F: tests/qtest/intel-hda-test.c
+F: tests/qtest/fuzz-sb16-test.c
+

I would call that "Audio Hardware Emulation" instead of "Overall Audio frontends".

And probably it would make sense to further subdivide this section into the individual hardware models (Sound Blaster, Adlib, PC Speaker, VIA AC97, ...), similar to patch 3. Could be split subsequently as well of course.

Quoted 12 lines
MAINTAINERS +1 -1
 Xilinx CAN
 M: Vikram Garhwal <[email protected]>
 M: Francisco Iglesias <[email protected]>
@@ -2256,17 +2266,11 @@ F: include/net/can_*.h
 
 Subsystems
 ----------
-Audio
+Overall Audio backends
 M: Gerd Hoffmann <[email protected]>
 S: Odd Fixes
 F: audio/

MAINTAINERS F: include/net/can_*.h · line 2276

Quoted 10 lines
MAINTAINERS +0 -6
-F: hw/audio/
-F: include/hw/audio/
 F: qapi/audio.json
-F: tests/qtest/ac97-test.c
-F: tests/qtest/es1370-test.c
-F: tests/qtest/intel-hda-test.c
-F: tests/qtest/fuzz-sb16-test.c
 
 Block layer core
 M: Kevin Wolf <[email protected]>

Likewise I would call this section "Shared/common QEMU audio library/ subsystem" or something like that instead of "Overall Audio backends".

Best regards,
Christian Schoenebeck

#3 lore raw

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Hi,

Quoted 9 lines
Quoted 1 line

+Overall Audio frontends

I would call that "Audio Hardware Emulation" instead of "Overall Audio frontends".

Quoted 1 line

+Overall Audio backends

Likewise I would call this section "Shared/common QEMU audio library/ subsystem" or something like that instead of "Overall Audio backends".

Well, frontend/backend is common qemu terminology, with "frontend" being the emulated/virtual device as seen by the guest and "backend" being the host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)

take care,
Gerd

#4 lore raw

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Quoted 12 lines · On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:

Hi,

Quoted 9 lines
Quoted 1 line

+Overall Audio frontends

I would call that "Audio Hardware Emulation" instead of "Overall Audio frontends".

Quoted 1 line

+Overall Audio backends

Likewise I would call this section "Shared/common QEMU audio library/ subsystem" or something like that instead of "Overall Audio backends".

Quoted 6 lines

Well, frontend/backend is common qemu terminology, with "frontend" being the emulated/virtual device as seen by the guest and "backend" being the host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)

take care,
Gerd

Yeah, I was seeing this (like usual) more from an external/new developer perspective where the semantic for "frontend"/"backend" is not that obvious here.

But okay ...

Best regards,
Christian Schoenebeck

#5 lore raw

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Quoted 17 lines · Christian Schoenebeck
Quoted 16 lines · On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:

Hi,

Quoted 9 lines
Quoted 1 line

+Overall Audio frontends

I would call that "Audio Hardware Emulation" instead of "Overall Audio frontends".

Quoted 1 line

+Overall Audio backends

Likewise I would call this section "Shared/common QEMU audio library/ subsystem" or something like that instead of "Overall Audio backends".

Well, frontend/backend is common qemu terminology, with "frontend" being the emulated/virtual device as seen by the guest and "backend" being the host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)

Quoted 6 lines
Quoted 2 lines

take care,
Gerd

Yeah, I was seeing this (like usual) more from an external/new developer perspective where the semantic for "frontend"/"backend" is not that obvious here.

"Audio Backends" is in the "Subsystems" meta-section, and "Audio Frontends" in the "Devices" one.

Maybe we using the === separator for meta-sections (like rST) instead of --- would help seeing the difference.

I don't want to use parenthesis in the descriptions because this then breaks the get_maintainer.pl output when parsed by (git) scripts.

Quoted 9 lines

But okay ...

Best regards,
Christian Schoenebeck

#6 lore raw

Re: [PATCH 1/3] MAINTAINERS: Split Audio backends VS frontends

Quoted 27 lines · On Dienstag, 17. August 2021 19:57:21 CEST Philippe Mathieu-Daudé wrote:
Quoted 17 lines · Christian Schoenebeck
Quoted 16 lines · On Dienstag, 17. August 2021 14:41:27 CEST Gerd Hoffmann wrote:

Hi,

Quoted 9 lines
Quoted 1 line

+Overall Audio frontends

I would call that "Audio Hardware Emulation" instead of "Overall Audio frontends".

Quoted 1 line

+Overall Audio backends

Likewise I would call this section "Shared/common QEMU audio library/ subsystem" or something like that instead of "Overall Audio backends".

Well, frontend/backend is common qemu terminology, with "frontend" being the emulated/virtual device as seen by the guest and "backend" being the host-side wireup (i.e. -audiodev / -blockdev / -chardev / -netdev / ...)

Quoted 8 lines
Quoted 3 lines

take care,

Gerd

Yeah, I was seeing this (like usual) more from an external/new developer perspective where the semantic for "frontend"/"backend" is not that obvious
here.

Quoted 5 lines

"Audio Backends" is in the "Subsystems" meta-section, and "Audio Frontends" in the "Devices" one.

Maybe we using the === separator for meta-sections (like rST) instead of --- would help seeing the difference.

No need for now. On the long-term the MAINTAINERS structure might be improved in some way to make specific tree structures more clear, but for now it's Ok.

Thanks!

Best regards,
Christian Schoenebeck

#7 lore raw

PATCH 2/3 MAINTAINERS: Remove SPICE from Audio backends section

In reply to Philippe Mathieu-Daudé

SPICE audio is already covered in the SPICE section, so remove it from the Audio backends one.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 9ec6baa7e4c..f18fcd76450 100644
@@ -2270,6 +2270,7 @@ Overall Audio backends
 M: Gerd Hoffmann <[email protected]>
 S: Odd Fixes
 F: audio/
+X: audio/spiceaudio.c
 F: qapi/audio.json
 
 Block layer core
Signature · 1 line
2.31.1
Reviewed-by on v1 2/3
#8 lore raw

Re: [PATCH 2/3] MAINTAINERS: Remove SPICE from Audio backends section

Quoted 13 lines · On Montag, 16. August 2021 21:10:13 CEST Philippe Mathieu-Daudé wrote:

SPICE audio is already covered in the SPICE section, so remove it from the Audio backends one.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index 9ec6baa7e4c..f18fcd76450 100644

MAINTAINERS Overall Audio backends · line 2276

Quoted 7 lines
MAINTAINERS +1 -0
@@ -2270,6 +2270,7 @@ Overall Audio backends
 M: Gerd Hoffmann <[email protected]>
 S: Odd Fixes
 F: audio/
+X: audio/spiceaudio.c
 F: qapi/audio.json
 
 Block layer core

Best regards,
Christian Schoenebeck

#9 lore raw

PATCH 3/3 MAINTAINERS: Split Audio backends sections

In reply to Philippe Mathieu-Daudé

Split the Audio backends into multiple sections (OS / framework / library), allowing developers with different interests to add their contact to the relevant entries.

---
 MAINTAINERS | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
MAINTAINERS +42 -0
index f18fcd76450..94dea726e05 100644
@@ -2270,9 +2270,51 @@ Overall Audio backends
 M: Gerd Hoffmann <[email protected]>
 S: Odd Fixes
 F: audio/
+X: audio/alsaaudio.c
+X: audio/coreaudio.c
+X: audio/dsound*
+X: audio/jackaudio.c
+X: audio/ossaudio.c
+X: audio/paaudio.c
+X: audio/sdlaudio.c
 X: audio/spiceaudio.c
 F: qapi/audio.json
 
+ALSA Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/alsaaudio.c
+
+Core Audio framework backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/coreaudio.c
+
+DSound Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/dsound*
+
+JACK Audio Connection Kit backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/jackaudio.c
+
+Open Sound System (OSS) Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/ossaudio.c
+
+PulseAudio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/paaudio.c
+
+SDL Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/sdlaudio.c
+
 Block layer core
 M: Kevin Wolf <[email protected]>
 M: Hanna Reitz <[email protected]>
Signature · 1 line
2.31.1
Reviewed-by on v1 3/3
#10 lore raw

Re: [PATCH 3/3] MAINTAINERS: Split Audio backends sections

Quoted 56 lines · On Montag, 16. August 2021 21:10:14 CEST Philippe Mathieu-Daudé wrote:

Split the Audio backends into multiple sections (OS / framework / library), allowing developers with different interests to add their contact to the relevant entries.

---
 MAINTAINERS | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
MAINTAINERS +35 -0
index f18fcd76450..94dea726e05 100644
@@ -2270,9 +2270,51 @@ Overall Audio backends
 M: Gerd Hoffmann <[email protected]>
 S: Odd Fixes
 F: audio/
+X: audio/alsaaudio.c
+X: audio/coreaudio.c
+X: audio/dsound*
+X: audio/jackaudio.c
+X: audio/ossaudio.c
+X: audio/paaudio.c
+X: audio/sdlaudio.c
 X: audio/spiceaudio.c
 F: qapi/audio.json
 
+ALSA Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/alsaaudio.c
+
+Core Audio framework backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/coreaudio.c
+
+DSound Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/dsound*
+
+JACK Audio Connection Kit backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/jackaudio.c
+
+Open Sound System (OSS) Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/ossaudio.c
+
+PulseAudio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes

MAINTAINERS Overall Audio backends · line 2320

Quoted 10 lines
MAINTAINERS +7 -0
+F: audio/paaudio.c
+
+SDL Audio backend
+M: Gerd Hoffmann <[email protected]>
+S: Odd Fixes
+F: audio/sdlaudio.c
+
 Block layer core
 M: Kevin Wolf <[email protected]>
 M: Hanna Reitz <[email protected]>

Best regards,
Christian Schoenebeck